diff options
author | Simon Knox <simon@gitlab.com> | 2019-08-08 03:06:45 +0300 |
---|---|---|
committer | Mike Greiling <mike@pixelcog.com> | 2019-08-08 03:06:45 +0300 |
commit | 055a7b973dd99185f2dee01a3d4774f9f0a5e1b6 (patch) | |
tree | 61c1032a084b9b996a9fa639bad263ea784b76c8 /spec/javascripts/monitoring/utils_spec.js | |
parent | eec1ed522d4103ee7d347c305f1021db33173def (diff) |
Simplify getTimeDiff function
Pass keyname instead of translated string
Diffstat (limited to 'spec/javascripts/monitoring/utils_spec.js')
-rw-r--r-- | spec/javascripts/monitoring/utils_spec.js | 28 |
1 files changed, 19 insertions, 9 deletions
diff --git a/spec/javascripts/monitoring/utils_spec.js b/spec/javascripts/monitoring/utils_spec.js index 5570d57b8b2..e22e8cdc03d 100644 --- a/spec/javascripts/monitoring/utils_spec.js +++ b/spec/javascripts/monitoring/utils_spec.js @@ -3,28 +3,38 @@ import { timeWindows } from '~/monitoring/constants'; import { graphDataPrometheusQuery, graphDataPrometheusQueryRange } from './mock_data'; describe('getTimeDiff', () => { + function secondsBetween({ start, end }) { + return (new Date(end) - new Date(start)) / 1000; + } + + function minutesBetween(timeRange) { + return secondsBetween(timeRange) / 60; + } + + function hoursBetween(timeRange) { + return minutesBetween(timeRange) / 60; + } + it('defaults to an 8 hour (28800s) difference', () => { const params = getTimeDiff(); - expect(params.end - params.start).toEqual(28800); + expect(hoursBetween(params)).toEqual(8); }); it('accepts time window as an argument', () => { - const params = getTimeDiff(timeWindows.thirtyMinutes); + const params = getTimeDiff('thirtyMinutes'); - expect(params.end - params.start).not.toEqual(28800); + expect(minutesBetween(params)).toEqual(30); }); it('returns a value for every defined time window', () => { const nonDefaultWindows = Object.keys(timeWindows).filter(window => window !== 'eightHours'); - nonDefaultWindows.forEach(window => { - const params = getTimeDiff(timeWindows[window]); - const diff = params.end - params.start; + nonDefaultWindows.forEach(timeWindow => { + const params = getTimeDiff(timeWindow); - // Ensure we're not returning the default, 28800 (the # of seconds in 8 hrs) - expect(diff).not.toEqual(28800); - expect(typeof diff).toEqual('number'); + // Ensure we're not returning the default + expect(hoursBetween(params)).not.toEqual(8); }); }); }); |