diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-11-17 14:33:21 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-11-17 14:33:21 +0300 |
commit | 7021455bd1ed7b125c55eb1b33c5a01f2bc55ee0 (patch) | |
tree | 5bdc2229f5198d516781f8d24eace62fc7e589e9 /spec/lib/banzai/reference_parser/commit_range_parser_spec.rb | |
parent | 185b095e93520f96e9cfc31d9c3e69b498cdab7c (diff) |
Add latest changes from gitlab-org/gitlab@15-6-stable-eev15.6.0-rc42
Diffstat (limited to 'spec/lib/banzai/reference_parser/commit_range_parser_spec.rb')
-rw-r--r-- | spec/lib/banzai/reference_parser/commit_range_parser_spec.rb | 40 |
1 files changed, 38 insertions, 2 deletions
diff --git a/spec/lib/banzai/reference_parser/commit_range_parser_spec.rb b/spec/lib/banzai/reference_parser/commit_range_parser_spec.rb index 2f64aef4fb7..172347fc421 100644 --- a/spec/lib/banzai/reference_parser/commit_range_parser_spec.rb +++ b/spec/lib/banzai/reference_parser/commit_range_parser_spec.rb @@ -12,12 +12,30 @@ RSpec.describe Banzai::ReferenceParser::CommitRangeParser do let(:link) { empty_html_link } describe '#nodes_visible_to_user' do - context 'when the link has a data-issue attribute' do + context 'when the link has a data-project attribute' do before do - link['data-commit-range'] = '123..456' + link['data-project'] = project.id.to_s end it_behaves_like "referenced feature visibility", "repository" + + it 'includes the link if can_read_reference? returns true' do + expect(subject).to receive(:can_read_reference?).with(user, project, link).and_return(true) + + expect(subject.nodes_visible_to_user(user, [link])).to contain_exactly(link) + end + + it 'excludes the link if can_read_reference? returns false' do + expect(subject).to receive(:can_read_reference?).with(user, project, link).and_return(false) + + expect(subject.nodes_visible_to_user(user, [link])).to be_empty + end + end + + context 'when the link does not have a data-project attribute' do + it 'returns the nodes' do + expect(subject.nodes_visible_to_user(user, [link])).to match_array([link]) + end end end @@ -136,4 +154,22 @@ RSpec.describe Banzai::ReferenceParser::CommitRangeParser do end end end + + context 'when checking commits ranges on another projects', :request_store do + let!(:control_links) do + [commit_range_link] + end + + let!(:actual_links) do + control_links + [commit_range_link, commit_range_link] + end + + def commit_range_link + project = create(:project, :repository, :public) + + Nokogiri::HTML.fragment(%(<a data-commit-range="123...456" data-project="#{project.id}"></a>)).children[0] + end + + it_behaves_like 'no project N+1 queries' + end end |