diff options
author | Douwe Maan <douwe@gitlab.com> | 2016-02-29 16:22:38 +0300 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2016-02-29 16:22:38 +0300 |
commit | cd391b66e9d480c3143b63d32f893c6a1015f04e (patch) | |
tree | 8916890c65f15a7899b0abae5f50923fc568e934 /spec/lib | |
parent | 2ea8f71bb42e63caf58ab285d0c4e483c2c4de19 (diff) | |
parent | 989946f33717685065812d72e9ed4490fe969104 (diff) |
Merge branch 'rs-data-links' into 'master'
Sanitize `data` and `vbscript` links
Closes #13625
Closes https://dev.gitlab.org/gitlab/gitlabhq/issues/2660
See merge request !2905
Diffstat (limited to 'spec/lib')
-rw-r--r-- | spec/lib/banzai/filter/sanitization_filter_spec.rb | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/spec/lib/banzai/filter/sanitization_filter_spec.rb b/spec/lib/banzai/filter/sanitization_filter_spec.rb index e14a6dbf922..4a7b00c7660 100644 --- a/spec/lib/banzai/filter/sanitization_filter_spec.rb +++ b/spec/lib/banzai/filter/sanitization_filter_spec.rb @@ -156,13 +156,27 @@ describe Banzai::Filter::SanitizationFilter, lib: true do } protocols.each do |name, data| - it "handles #{name}" do + it "disallows #{name}" do doc = filter(data[:input]) expect(doc.to_html).to eq data[:output] end end + it 'disallows data links' do + input = '<a href="data:text/html;base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4K">XSS</a>' + output = filter(input) + + expect(output.to_html).to eq '<a>XSS</a>' + end + + it 'disallows vbscript links' do + input = '<a href="vbscript:alert(document.domain)">XSS</a>' + output = filter(input) + + expect(output.to_html).to eq '<a>XSS</a>' + end + it 'allows non-standard anchor schemes' do exp = %q{<a href="irc://irc.freenode.net/git">IRC</a>} act = filter(exp) |