diff options
author | Robert Schilling <rschilling@student.tugraz.at> | 2019-02-14 13:40:28 +0300 |
---|---|---|
committer | Robert Schilling <rschilling@student.tugraz.at> | 2019-08-26 11:45:37 +0300 |
commit | efafc98bd8ca7d4ed4c86f19325eb2aa51edd227 (patch) | |
tree | 3a0c83856bbab2356b06fc1747053413d0b8f99e /spec/requests/api | |
parent | 41412f73604159ca735420396df73f7b6eef6f86 (diff) |
Move promote to put and add more specs
Diffstat (limited to 'spec/requests/api')
-rw-r--r-- | spec/requests/api/labels_spec.rb | 34 |
1 files changed, 29 insertions, 5 deletions
diff --git a/spec/requests/api/labels_spec.rb b/spec/requests/api/labels_spec.rb index 047e8b6c507..f7df9bb1b3f 100644 --- a/spec/requests/api/labels_spec.rb +++ b/spec/requests/api/labels_spec.rb @@ -473,23 +473,47 @@ describe API::Labels do end end - describe 'POST /projects/:id/labels/promote' do + describe 'PUT /projects/:id/labels/promote' do + let(:group) { create(:group) } + + before do + project.update(group: group) + end + it 'returns 200 if label is promoted' do - post api("/projects/#{project.id}/labels/promote", user), params: { name: 'label1' } + put api("/projects/#{project.id}/labels/promote", user), params: { name: label1.name } expect(response).to have_gitlab_http_status(200) expect(json_response['name']).to eq(label1.name) - expect(json_response['color']).to eq('#FFFFFF') + expect(json_response['color']).to eq(label1.color) + end + + it 'returns 400 if group label already exists' do + create(:group_label, title: label1.name, group: group) + + put api("/projects/#{project.id}/labels/promote", user), params: { name: label1.name } + + expect(response).to have_gitlab_http_status(400) + expect(json_response['message']).to eq('Failed to promote project label to group label') + end + + it 'returns 403 if guest promotes label' do + guest = create(:user) + project.add_guest(guest) + + put api("/projects/#{project.id}/labels/promote", guest), params: { name: label1.name } + + expect(response).to have_gitlab_http_status(403) end it 'returns 404 if label does not exist' do - post api("/projects/#{project.id}/labels/promote", user), params: { name: 'unknown' } + put api("/projects/#{project.id}/labels/promote", user), params: { name: 'unknown' } expect(response).to have_gitlab_http_status(404) end it 'returns 400 if no label name given' do - post api("/projects/#{project.id}/labels/promote", user) + put api("/projects/#{project.id}/labels/promote", user) expect(response).to have_gitlab_http_status(400) expect(json_response['error']).to eq('name is missing') |