Create PipelineDetailsEntity

Now we have a PipelineEntity which is a bit smaller, mostly in bytes
needing to send to the frontend. PipelineDetailsEntity is the default
for the PipelineSerializer, limiting the changes needed.

This commit also incorporates the review.

1 files changed, 10 insertions, 4 deletions

diff --git a/spec/serializers/build_details_entity_spec.rb b/spec/serializers/build_details_entity_spec.rb
index 4b827a0994c..99829348348 100644
--- a/spec/serializers/build_details_entity_spec.rb
+++ b/spec/serializers/build_details_entity_spec.rb
@@ -7,7 +7,6 @@ describe BuildDetailsEntity do
 
   describe '#as_json' do
     let(:project) { create(:project, :repository) }
-    let(:user) { create(:user) }
     let!(:build) { create(:ci_build, :failed, project: project) }
     let(:request) { double('request') }
     let(:entity) { described_class.new(build, request: request, current_user: user, project: project) }
@@ -15,12 +14,17 @@ describe BuildDetailsEntity do
 
     before do
       allow(request).to receive(:current_user).and_return(user)
-
-      project.add_master(user)
     end
 
     context 'when the user has access to issues and merge requests' do
-      let!(:merge_request) { create(:merge_request, source_project: project) }
+      let(:user) { create(:admin) }
+      let!(:merge_request) do
+        create(:merge_request, source_project: project, source_branch: build.ref)
+      end
+
+      before do
+        allow(build).to receive(:merge_request).and_return(merge_request)
+      end
 
       it 'contains the needed key value pairs' do
         expect(subject).to include(:coverage, :erased_at, :duration)
@@ -30,6 +34,8 @@ describe BuildDetailsEntity do
     end
 
     context 'when the user can only read the build' do
+      let(:user) { create(:user) }
+
       it "won't display the paths to issues and merge requests" do
         expect(subject['new_issue_path']).to be_nil
         expect(subject['merge_request_path']).to be_nil