Move permission check of manual actions of deployments

2 files changed, 32 insertions, 2 deletions

diff --git a/spec/serializers/deployment_entity_spec.rb b/spec/serializers/deployment_entity_spec.rb
index cfa5414b40f..894fd7a0a12 100644
--- a/spec/serializers/deployment_entity_spec.rb
+++ b/spec/serializers/deployment_entity_spec.rb
@@ -1,14 +1,22 @@
 require 'spec_helper'
 
 describe DeploymentEntity do
-  let(:user) { create(:user) }
+  let(:user) { developer }
+  let(:developer) { create(:user) }
+  let(:reporter) { create(:user) }
+  let(:project) { create(:project) }
   let(:request) { double('request') }
-  let(:deployment) { create(:deployment) }
+  let(:deployment) { create(:deployment, deployable: build, project: project) }
+  let(:build) { create(:ci_build, :manual, pipeline: pipeline) }
+  let(:pipeline) { create(:ci_pipeline, project: project, user: user) }
   let(:entity) { described_class.new(deployment, request: request) }
   subject { entity.as_json }
 
   before do
+    project.add_developer(developer)
+    project.add_reporter(reporter)
     allow(request).to receive(:current_user).and_return(user)
+    allow(request).to receive(:project).and_return(project)
   end
 
   it 'exposes internal deployment id' do
@@ -23,6 +31,24 @@ describe DeploymentEntity do
     expect(subject).to include(:created_at)
   end
 
+  context 'when the pipeline has another manual action' do
+    let(:other_build) { create(:ci_build, :manual, name: 'another deploy', pipeline: pipeline) }
+    let!(:other_deployment) { create(:deployment, deployable: other_build) }
+
+    it 'returns another manual action' do
+      expect(subject[:manual_actions].count).to eq(1)
+      expect(subject[:manual_actions].first[:name]).to eq('another deploy')
+    end
+
+    context 'when user is a reporter' do
+      let(:user) { reporter }
+
+      it 'returns another manual action' do
+        expect(subject[:manual_actions]).not_to be_present
+      end
+    end
+  end
+
   describe 'scheduled_actions' do
     let(:project) { create(:project, :repository) }
     let(:pipeline) { create(:ci_pipeline, project: project, user: user) }
diff --git a/spec/serializers/environment_serializer_spec.rb b/spec/serializers/environment_serializer_spec.rb
index 87493a28d1f..3541bd5f12e 100644
--- a/spec/serializers/environment_serializer_spec.rb
+++ b/spec/serializers/environment_serializer_spec.rb
@@ -10,6 +10,10 @@ describe EnvironmentSerializer do
       .represent(resource)
   end
 
+  before do
+    project.add_developer(user)
+  end
+
   context 'when there is a single object provided' do
     let(:project) { create(:project, :repository) }
     let(:deployable) { create(:ci_build) }