diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-05-04 09:10:10 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-05-04 09:10:10 +0300 |
commit | 2fa68d3a97fd31bf469050e130f0fc95e8944316 (patch) | |
tree | 5c00585c55c44917765c152426cb58c803b4f57f /spec/services/design_management | |
parent | 21be9646a94e2c145897e25d9c521523d55e1614 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services/design_management')
-rw-r--r-- | spec/services/design_management/design_user_notes_count_service_spec.rb | 52 |
1 files changed, 52 insertions, 0 deletions
diff --git a/spec/services/design_management/design_user_notes_count_service_spec.rb b/spec/services/design_management/design_user_notes_count_service_spec.rb new file mode 100644 index 00000000000..f4808542995 --- /dev/null +++ b/spec/services/design_management/design_user_notes_count_service_spec.rb @@ -0,0 +1,52 @@ +# frozen_string_literal: true + +require 'spec_helper' + +describe DesignManagement::DesignUserNotesCountService, :use_clean_rails_memory_store_caching do + let_it_be(:design) { create(:design, :with_file) } + + subject { described_class.new(design) } + + it_behaves_like 'a counter caching service' + + describe '#count' do + it 'returns the count of notes' do + create_list(:diff_note_on_design, 3, noteable: design) + + expect(subject.count).to eq(3) + end + end + + describe '#cache_key' do + it 'contains the `VERSION` and `design.id`' do + expect(subject.cache_key).to eq(['designs', 'notes_count', DesignManagement::DesignUserNotesCountService::VERSION, design.id]) + end + end + + # TODO These tests are being temporarily skipped unless run in EE, + # as we are in the process of moving Design Management to FOSS in 13.0 + # in steps. In the current step the services have not yet been moved. + # + # See https://gitlab.com/gitlab-org/gitlab/-/issues/212566#note_327724283. + describe 'cache invalidation' do + it 'changes when a new note is created' do + skip 'See https://gitlab.com/gitlab-org/gitlab/-/issues/212566#note_327724283' unless Gitlab.ee? + + new_note_attrs = attributes_for(:diff_note_on_design, noteable: design) + + expect do + Notes::CreateService.new(design.project, create(:user), new_note_attrs).execute + end.to change { subject.count }.by(1) + end + + it 'changes when a note is destroyed' do + skip 'See https://gitlab.com/gitlab-org/gitlab/-/issues/212566#note_327724283' unless Gitlab.ee? + + note = create(:diff_note_on_design, noteable: design) + + expect do + Notes::DestroyService.new(note.project, note.author).execute(note) + end.to change { subject.count }.by(-1) + end + end +end |