diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-08-29 06:09:26 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-08-29 06:09:26 +0300 |
commit | 676bd22b8df8e1ed169fd6cb03a2ac18946bebde (patch) | |
tree | d77d37a58990d081ee9504bd47266b7a417340c7 /spec/services/design_management | |
parent | 96e582ee80deeb4bd2b4f3a3cf48d1f9260f25aa (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services/design_management')
-rw-r--r-- | spec/services/design_management/delete_designs_service_spec.rb | 8 | ||||
-rw-r--r-- | spec/services/design_management/save_designs_service_spec.rb | 10 |
2 files changed, 11 insertions, 7 deletions
diff --git a/spec/services/design_management/delete_designs_service_spec.rb b/spec/services/design_management/delete_designs_service_spec.rb index 22570a14443..b6a80cf26cc 100644 --- a/spec/services/design_management/delete_designs_service_spec.rb +++ b/spec/services/design_management/delete_designs_service_spec.rb @@ -12,7 +12,7 @@ RSpec.describe DesignManagement::DeleteDesignsService, feature_category: :design subject(:service) { described_class.new(project, user, issue: issue, designs: designs) } - # Defined as a method so that the reponse is not cached. We also construct + # Defined as a method so that the response is not cached. We also construct # a new service executor each time to avoid the intermediate cached values # it constructs during its execution. def run_service(delenda = nil) @@ -173,8 +173,10 @@ RSpec.describe DesignManagement::DeleteDesignsService, feature_category: :design run_service end - it_behaves_like 'issue_edit snowplow tracking' do - let(:property) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_DESIGNS_REMOVED } + it_behaves_like 'internal event tracking' do + let(:action) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_DESIGNS_REMOVED } + let(:namespace) { project.namespace } + subject(:service_action) { run_service } end end diff --git a/spec/services/design_management/save_designs_service_spec.rb b/spec/services/design_management/save_designs_service_spec.rb index 7ce99fdd71f..24e37f2a840 100644 --- a/spec/services/design_management/save_designs_service_spec.rb +++ b/spec/services/design_management/save_designs_service_spec.rb @@ -121,8 +121,9 @@ RSpec.describe DesignManagement::SaveDesignsService, feature_category: :design_m ) end - it_behaves_like 'issue_edit snowplow tracking' do - let(:property) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_DESIGNS_ADDED } + it_behaves_like 'internal event tracking' do + let(:action) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_DESIGNS_ADDED } + let(:namespace) { project.namespace } subject(:service_action) { run_service } end @@ -219,8 +220,9 @@ RSpec.describe DesignManagement::SaveDesignsService, feature_category: :design_m run_service end - it_behaves_like 'issue_edit snowplow tracking' do - let(:property) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_DESIGNS_MODIFIED } + it_behaves_like 'internal event tracking' do + let(:action) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_DESIGNS_MODIFIED } + let(:namespace) { project.namespace } subject(:service_action) { run_service } end |