diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-01-11 15:10:41 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-01-11 15:10:41 +0300 |
commit | f469daf1dc805d4c6a689067094112d4ed68d775 (patch) | |
tree | 18f779bf1dac8825066090239d9c1c80f67c286d /spec/services/members | |
parent | c2dcc63e6db8e9ee3365c45356451d8144eb0c23 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services/members')
-rw-r--r-- | spec/services/members/create_service_spec.rb | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/spec/services/members/create_service_spec.rb b/spec/services/members/create_service_spec.rb index 7fd6b3e5b8d..50efee9f43c 100644 --- a/spec/services/members/create_service_spec.rb +++ b/spec/services/members/create_service_spec.rb @@ -13,14 +13,20 @@ RSpec.describe Members::CreateService, :clean_gitlab_redis_shared_state, :sideki subject(:execute_service) { described_class.new(user, params).execute(source) } before do - source.is_a?(Project) ? source.add_maintainer(user) : source.add_owner(user) + if source.is_a?(Project) + source.add_maintainer(user) + OnboardingProgress.onboard(source.namespace) + else + source.add_owner(user) + OnboardingProgress.onboard(source) + end end context 'when passing valid parameters' do it 'adds a user to members' do expect(execute_service[:status]).to eq(:success) expect(source.users).to include member - expect(NamespaceOnboardingAction.completed?(source.namespace, :user_added)).to be(true) + expect(OnboardingProgress.completed?(source.namespace, :user_added)).to be(true) end context 'when executing on a group' do @@ -29,7 +35,7 @@ RSpec.describe Members::CreateService, :clean_gitlab_redis_shared_state, :sideki it 'adds a user to members' do expect(execute_service[:status]).to eq(:success) expect(source.users).to include member - expect(NamespaceOnboardingAction.completed?(source, :user_added)).to be(true) + expect(OnboardingProgress.completed?(source, :user_added)).to be(true) end end end @@ -41,7 +47,7 @@ RSpec.describe Members::CreateService, :clean_gitlab_redis_shared_state, :sideki expect(execute_service[:status]).to eq(:error) expect(execute_service[:message]).to be_present expect(source.users).not_to include member - expect(NamespaceOnboardingAction.completed?(source.namespace, :user_added)).to be(false) + expect(OnboardingProgress.completed?(source.namespace, :user_added)).to be(false) end end @@ -52,7 +58,7 @@ RSpec.describe Members::CreateService, :clean_gitlab_redis_shared_state, :sideki expect(execute_service[:status]).to eq(:error) expect(execute_service[:message]).to be_present expect(source.users).not_to include member - expect(NamespaceOnboardingAction.completed?(source.namespace, :user_added)).to be(false) + expect(OnboardingProgress.completed?(source.namespace, :user_added)).to be(false) end end @@ -63,7 +69,7 @@ RSpec.describe Members::CreateService, :clean_gitlab_redis_shared_state, :sideki expect(execute_service[:status]).to eq(:error) expect(execute_service[:message]).to include("#{member.username}: Access level is not included in the list") expect(source.users).not_to include member - expect(NamespaceOnboardingAction.completed?(source.namespace, :user_added)).to be(false) + expect(OnboardingProgress.completed?(source.namespace, :user_added)).to be(false) end end @@ -73,7 +79,7 @@ RSpec.describe Members::CreateService, :clean_gitlab_redis_shared_state, :sideki it 'does not add a member' do expect(execute_service[:status]).to eq(:error) expect(execute_service[:message]).to eq('Invite email has already been taken') - expect(NamespaceOnboardingAction.completed?(source.namespace, :user_added)).to be(false) + expect(OnboardingProgress.completed?(source.namespace, :user_added)).to be(false) end end end |