Add latest changes from gitlab-org/gitlab@master

4 files changed, 245 insertions, 0 deletions

diff --git a/spec/services/packages/rubygems/create_dependencies_service_spec.rb b/spec/services/packages/rubygems/create_dependencies_service_spec.rb
new file mode 100644
index 00000000000..b6e12b1cc61
--- /dev/null
+++ b/spec/services/packages/rubygems/create_dependencies_service_spec.rb
@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe Packages::Rubygems::CreateDependenciesService do
+  include RubygemsHelpers
+
+  let_it_be(:package) { create(:rubygems_package) }
+  let_it_be(:package_file) { create(:package_file, :gem) }
+  let_it_be(:gem) { gem_from_file(package_file.file) }
+  let_it_be(:gemspec) { gem.spec }
+
+  let(:service) { described_class.new(package, gemspec) }
+
+  describe '#execute' do
+    subject { service.execute }
+
+    it 'creates dependencies', :aggregate_failures do
+      expect { subject }.to change { Packages::Dependency.count }.by(4)
+
+      gemspec.dependencies.each do |dependency|
+        persisted_dependency = Packages::Dependency.find_by(name: dependency.name)
+
+        expect(persisted_dependency.version_pattern).to eq dependency.requirement.to_s
+      end
+    end
+
+    it 'links dependencies to the package' do
+      expect { subject }.to change { package.dependency_links.count }.by(4)
+
+      expect(package.dependency_links.first).to be_dependencies
+    end
+  end
+end
diff --git a/spec/services/packages/rubygems/create_gemspec_service_spec.rb b/spec/services/packages/rubygems/create_gemspec_service_spec.rb
new file mode 100644
index 00000000000..4d5061933e0
--- /dev/null
+++ b/spec/services/packages/rubygems/create_gemspec_service_spec.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe Packages::Rubygems::CreateGemspecService do
+  include RubygemsHelpers
+
+  let_it_be(:package) { create(:rubygems_package) }
+  let_it_be(:package_file) { create(:package_file, :gem) }
+  let_it_be(:gem) { gem_from_file(package_file.file) }
+  let_it_be(:gemspec) { gem.spec }
+
+  let(:service) { described_class.new(package, gemspec) }
+
+  describe '#execute' do
+    subject { service.execute }
+
+    it 'creates a new package file', :aggregate_failures do
+      expect { subject }.to change { package.package_files.count }.by(1)
+
+      gemspec_file = package.package_files.find_by(file_name: "#{gemspec.name}.gemspec")
+      expect(gemspec_file.file).not_to be_nil
+      expect(gemspec_file.size).not_to be_nil
+      expect(gemspec_file.file_md5).not_to be_nil
+      expect(gemspec_file.file_sha1).not_to be_nil
+      expect(gemspec_file.file_sha256).not_to be_nil
+    end
+  end
+end
diff --git a/spec/services/packages/rubygems/metadata_extraction_service_spec.rb b/spec/services/packages/rubygems/metadata_extraction_service_spec.rb
new file mode 100644
index 00000000000..b308daad8f5
--- /dev/null
+++ b/spec/services/packages/rubygems/metadata_extraction_service_spec.rb
@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'rubygems/package'
+
+RSpec.describe Packages::Rubygems::MetadataExtractionService do
+  include RubygemsHelpers
+
+  let_it_be(:package) { create(:rubygems_package) }
+  let_it_be(:package_file) { create(:package_file, :gem) }
+  let_it_be(:gem) { gem_from_file(package_file.file) }
+  let_it_be(:gemspec) { gem.spec }
+
+  let(:service) { described_class.new(package, gemspec) }
+
+  describe '#execute' do
+    subject { service.execute }
+
+    it 'creates the metadata' do
+      expect { subject }.to change { Packages::Rubygems::Metadatum.count }.by(1)
+    end
+
+    it 'stores the metadata', :aggregate_failures do
+      subject
+
+      metadata = package.rubygems_metadatum
+
+      expect(metadata.authors).to eq(gemspec.authors.to_json)
+      expect(metadata.files).to eq(gemspec.files.to_json)
+      expect(metadata.summary).to eq(gemspec.summary)
+      expect(metadata.description).to eq(gemspec.description)
+      expect(metadata.email).to eq(gemspec.email)
+      expect(metadata.homepage).to eq(gemspec.homepage)
+      expect(metadata.licenses).to eq(gemspec.licenses.to_json)
+      expect(metadata.metadata).to eq(gemspec.metadata.to_json)
+      expect(metadata.author).to eq(gemspec.author)
+      expect(metadata.bindir).to eq(gemspec.bindir)
+      expect(metadata.executables).to eq(gemspec.executables.to_json)
+      expect(metadata.extensions).to eq(gemspec.extensions.to_json)
+      expect(metadata.extra_rdoc_files).to eq(gemspec.extra_rdoc_files.to_json)
+      expect(metadata.platform).to eq(gemspec.platform)
+      expect(metadata.post_install_message).to eq(gemspec.post_install_message)
+      expect(metadata.rdoc_options).to eq(gemspec.rdoc_options.to_json)
+      expect(metadata.require_paths).to eq(gemspec.require_paths.to_json)
+      expect(metadata.required_ruby_version).to eq(gemspec.required_ruby_version.to_s)
+      expect(metadata.required_rubygems_version).to eq(gemspec.required_rubygems_version.to_s)
+      expect(metadata.requirements).to eq(gemspec.requirements.to_json)
+      expect(metadata.rubygems_version).to eq(gemspec.rubygems_version)
+    end
+  end
+end
diff --git a/spec/services/packages/rubygems/process_gem_service_spec.rb b/spec/services/packages/rubygems/process_gem_service_spec.rb
new file mode 100644
index 00000000000..83e868d9579
--- /dev/null
+++ b/spec/services/packages/rubygems/process_gem_service_spec.rb
@@ -0,0 +1,134 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Packages::Rubygems::ProcessGemService do
+  include ExclusiveLeaseHelpers
+  include RubygemsHelpers
+
+  let_it_be_with_reload(:package) { create(:rubygems_package, :processing, name: 'temp_name', version: '0.0.0') }
+
+  let(:package_file) { create(:package_file, :unprocessed_gem, package: package) }
+  let(:gem) { gem_from_file(package_file.file) }
+  let(:gemspec) { gem.spec }
+  let(:service) { described_class.new(package_file) }
+
+  describe '#execute' do
+    subject { service.execute }
+
+    context 'no gem file', :aggregate_failures do
+      let(:package_file) { nil }
+
+      it 'returns an error' do
+        expect(subject.error?).to be(true)
+        expect(subject.message).to eq('Gem was not processed')
+      end
+    end
+
+    context 'success' do
+      let(:sub_service) { double }
+
+      before do
+        expect(Packages::Rubygems::MetadataExtractionService).to receive(:new).with(package, gemspec).and_return(sub_service)
+        expect(Packages::Rubygems::CreateGemspecService).to receive(:new).with(package, gemspec).and_return(sub_service)
+        expect(Packages::Rubygems::CreateDependenciesService).to receive(:new).with(package, gemspec).and_return(sub_service)
+
+        expect(sub_service).to receive(:execute).exactly(3).times.and_return(true)
+      end
+
+      it 'returns successfully', :aggregate_failures do
+        result = subject
+
+        expect(result.success?).to be true
+        expect(result.payload[:package]).to eq(package)
+      end
+
+      it 'updates the package name and version', :aggregate_failures do
+        expect(package.name).to eq('temp_name')
+        expect(package.version).to eq('0.0.0')
+        expect(package).to be_processing
+
+        subject
+
+        expect(package.reload.name).to eq('package')
+        expect(package.version).to eq('0.0.1')
+        expect(package).to be_default
+      end
+
+      it 'updates the package file name', :aggregate_failures do
+        expect(package_file.file_name).to eq('package.gem')
+
+        subject
+
+        expect(package_file.reload.file_name).to eq('package-0.0.1.gem')
+      end
+    end
+
+    context 'when the package already exists' do
+      let_it_be(:existing_package) { create(:rubygems_package, name: 'package', version: '0.0.1', project: package.project) }
+
+      let(:sub_service) { double }
+
+      before do
+        expect(Packages::Rubygems::MetadataExtractionService).to receive(:new).with(existing_package, gemspec).and_return(sub_service)
+        expect(Packages::Rubygems::CreateGemspecService).to receive(:new).with(existing_package, gemspec).and_return(sub_service)
+        expect(Packages::Rubygems::CreateDependenciesService).to receive(:new).with(existing_package, gemspec).and_return(sub_service)
+
+        expect(sub_service).to receive(:execute).exactly(3).times.and_return(true)
+      end
+
+      it 'assigns the package_file to the existing package and deletes the temporary package', :aggregate_failures do
+        expect(package).to receive(:destroy)
+
+        expect { subject }.to change { existing_package.package_files.count }.by(1)
+
+        expect(package_file.reload.package).to eq(existing_package)
+      end
+    end
+
+    context 'sub-service failure' do
+      before do
+        expect(Packages::Rubygems::MetadataExtractionService).to receive(:new).with(package, gemspec).and_raise(::Packages::Rubygems::ProcessGemService::ExtractionError.new('failure'))
+      end
+
+      it 'returns an error' do
+        expect { subject }.to raise_error(::Packages::Rubygems::ProcessGemService::ExtractionError, 'failure')
+      end
+    end
+
+    context 'bad gem file' do
+      before do
+        expect(Gem::Package).to receive(:new).and_raise(ArgumentError)
+      end
+
+      it 'returns an error' do
+        expect { subject }.to raise_error(::Packages::Rubygems::ProcessGemService::ExtractionError, 'Unable to read gem file')
+      end
+    end
+
+    context 'without obtaining an exclusive lease' do
+      let(:lease_key) { "packages:rubygems:process_gem_service:package:#{package.id}" }
+
+      before do
+        stub_exclusive_lease_taken(lease_key, timeout: 1.hour)
+      end
+
+      it 'does not perform the services', :aggregate_failures do
+        # The #use_file call triggers a separate lease on the package file being opened
+        # for use with the gem. We don't want to test that here, so we allow the call to proceed
+        expect(Gitlab::ExclusiveLease).to receive(:new).with("object_storage_migrate:Packages::PackageFile:#{package_file.id}", anything).and_call_original
+
+        expect(Packages::Rubygems::MetadataExtractionService).not_to receive(:new)
+        expect(Packages::Rubygems::CreateGemspecService).not_to receive(:new)
+        expect(Packages::Rubygems::CreateDependenciesService).not_to receive(:new)
+
+        subject
+
+        expect(package.reload.name).to eq('temp_name')
+        expect(package.version).to eq('0.0.0')
+        expect(package).to be_processing
+        expect(package_file.reload.file_name).to eq('package.gem')
+      end
+    end
+  end
+end