diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-07-15 00:09:03 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-07-15 00:09:03 +0300 |
commit | f9cda7671cfb07795d9ea01a7117f7d6c6511d0d (patch) | |
tree | 71233af70149f655249c475e764a8c2cd560b096 /spec/services/snippets | |
parent | 18ffa5e88194d8f3fd63bee0221de5bc1fbdfe94 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services/snippets')
-rw-r--r-- | spec/services/snippets/create_service_spec.rb | 33 | ||||
-rw-r--r-- | spec/services/snippets/update_service_spec.rb | 14 |
2 files changed, 27 insertions, 20 deletions
diff --git a/spec/services/snippets/create_service_spec.rb b/spec/services/snippets/create_service_spec.rb index f8e69b4b4bb..d0b2dde6ee4 100644 --- a/spec/services/snippets/create_service_spec.rb +++ b/spec/services/snippets/create_service_spec.rb @@ -177,10 +177,8 @@ RSpec.describe Snippets::CreateService do end it 'returns a generic error' do - response = subject - - expect(response).to be_error - expect(response.payload[:snippet].errors[:repository]).to eq ['Error creating the snippet'] + expect(subject).to be_error + expect(snippet.errors[:repository]).to eq ['Error creating the snippet'] end end @@ -250,7 +248,7 @@ RSpec.describe Snippets::CreateService do end it 'commit the files to the repository' do - subject + expect(subject).to be_success blob = snippet.repository.blob_at('master', file_path) @@ -261,10 +259,7 @@ RSpec.describe Snippets::CreateService do let(:extra_opts) { { content: 'foo', file_name: 'path' } } it 'a validation error is raised' do - response = subject - snippet = response.payload[:snippet] - - expect(response).to be_error + expect(subject).to be_error expect(snippet.errors.full_messages_for(:content)).to eq ['Content and snippet files cannot be used together'] expect(snippet.errors.full_messages_for(:file_name)).to eq ['File name and snippet files cannot be used together'] expect(snippet.repository.exists?).to be_falsey @@ -275,10 +270,7 @@ RSpec.describe Snippets::CreateService do let(:snippet_files) { [{ action: 'invalid_action', file_path: 'snippet_file_path.rb', content: 'snippet_content' }] } it 'a validation error is raised' do - response = subject - snippet = response.payload[:snippet] - - expect(response).to be_error + expect(subject).to be_error expect(snippet.errors.full_messages_for(:snippet_files)).to eq ['Snippet files have invalid data'] expect(snippet.repository.exists?).to be_falsey end @@ -288,14 +280,21 @@ RSpec.describe Snippets::CreateService do let(:snippet_files) { [{ action: 'delete', file_path: 'snippet_file_path.rb' }] } it 'a validation error is raised' do - response = subject - snippet = response.payload[:snippet] - - expect(response).to be_error + expect(subject).to be_error expect(snippet.errors.full_messages_for(:snippet_files)).to eq ['Snippet files have invalid data'] expect(snippet.repository.exists?).to be_falsey end end + + context 'when "create" operation does not have file_path or is empty' do + let(:snippet_files) { [{ action: 'create', content: content }, { action: 'create', content: content, file_path: '' }] } + + it 'generates the file path for the files' do + expect(subject).to be_success + expect(snippet.repository.blob_at('master', 'snippetfile1.txt').data).to eq content + expect(snippet.repository.blob_at('master', 'snippetfile2.txt').data).to eq content + end + end end context 'when ProjectSnippet' do diff --git a/spec/services/snippets/update_service_spec.rb b/spec/services/snippets/update_service_spec.rb index b16c4d64af3..5587668e9ed 100644 --- a/spec/services/snippets/update_service_spec.rb +++ b/spec/services/snippets/update_service_spec.rb @@ -537,10 +537,18 @@ RSpec.describe Snippets::UpdateService do it_behaves_like 'returns an error', 'Snippet files have invalid data' end - context 'when file_path is not present' do - let(:snippet_files) { [{ action: :create, content: content }] } + context 'when file_path is not present or empty' do + let(:snippet_files) { [{ action: :create, content: content }, { action: :create, file_path: '', content: content }] } - it_behaves_like 'returns an error', 'Snippet files have invalid data' + it 'generates the file path for the files' do + expect(blob('snippetfile1.txt')).to be_nil + expect(blob('snippetfile2.txt')).to be_nil + + expect(subject).to be_success + + expect(blob('snippetfile1.txt').data).to eq content + expect(blob('snippetfile2.txt').data).to eq content + end end context 'when file_path already exists in the repository' do |