diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-03-31 21:09:19 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-03-31 21:09:19 +0300 |
commit | 676109e1b32682bdbdd94a9ffbd8743784f35521 (patch) | |
tree | 71f0394c68455c1736a14c215992de6aa5fe358c /spec/services | |
parent | 5facc34f44ce8736078127a5df174a7b52d922b4 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services')
-rw-r--r-- | spec/services/members/invite_service_spec.rb | 70 | ||||
-rw-r--r-- | spec/services/projects/fork_service_spec.rb | 2 | ||||
-rw-r--r-- | spec/services/projects/unlink_fork_service_spec.rb | 11 |
3 files changed, 52 insertions, 31 deletions
diff --git a/spec/services/members/invite_service_spec.rb b/spec/services/members/invite_service_spec.rb index cced93896a5..82793d2e73c 100644 --- a/spec/services/members/invite_service_spec.rb +++ b/spec/services/members/invite_service_spec.rb @@ -2,29 +2,43 @@ require 'spec_helper' -RSpec.describe Members::InviteService, :aggregate_failures do +RSpec.describe Members::InviteService, :aggregate_failures, :clean_gitlab_redis_shared_state, :sidekiq_inline do let_it_be(:project) { create(:project) } let_it_be(:user) { project.owner } let_it_be(:project_user) { create(:user) } + let_it_be(:namespace) { project.namespace } let(:params) { {} } - let(:base_params) { { access_level: Gitlab::Access::GUEST } } + let(:base_params) { { access_level: Gitlab::Access::GUEST, source: project } } - subject(:result) { described_class.new(user, base_params.merge(params)).execute(project) } + subject(:result) { described_class.new(user, base_params.merge(params) ).execute } - context 'when email is previously unused by current members' do + context 'when there is a valid member invited' do let(:params) { { email: 'email@example.org' } } it 'successfully creates a member' do - expect { result }.to change(ProjectMember, :count).by(1) + expect_to_create_members(count: 1) expect(result[:status]).to eq(:success) end + + it_behaves_like 'records an onboarding progress action', :user_added + end + + context 'when email is not a valid email' do + let(:params) { { email: '_bogus_' } } + + it 'returns an error' do + expect_not_to_create_members + expect(result[:message]['_bogus_']).to eq("Invite email is invalid") + end + + it_behaves_like 'does not record an onboarding progress action' end context 'when emails are passed as an array' do let(:params) { { email: %w[email@example.org email2@example.org] } } it 'successfully creates members' do - expect { result }.to change(ProjectMember, :count).by(2) + expect_to_create_members(count: 2) expect(result[:status]).to eq(:success) end end @@ -33,33 +47,23 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: '' } } it 'returns an error' do - expect(result[:status]).to eq(:error) + expect_not_to_create_members expect(result[:message]).to eq('Email cannot be blank') end end context 'when email param is not included' do it 'returns an error' do - expect(result[:status]).to eq(:error) + expect_not_to_create_members expect(result[:message]).to eq('Email cannot be blank') end end - context 'when email is not a valid email' do - let(:params) { { email: '_bogus_' } } - - it 'returns an error' do - expect { result }.not_to change(ProjectMember, :count) - expect(result[:status]).to eq(:error) - expect(result[:message]['_bogus_']).to eq("Invite email is invalid") - end - end - context 'when duplicate email addresses are passed' do let(:params) { { email: 'email@example.org,email@example.org' } } it 'only creates one member per unique address' do - expect { result }.to change(ProjectMember, :count).by(1) + expect_to_create_members(count: 1) expect(result[:status]).to eq(:success) end end @@ -71,8 +75,7 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: emails } } it 'limits the number of emails to 100' do - expect { result }.not_to change(ProjectMember, :count) - expect(result[:status]).to eq(:error) + expect_not_to_create_members expect(result[:message]).to eq('Too many users specified (limit is 100)') end end @@ -81,8 +84,7 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: 'email@example.org,email2@example.org', limit: 1 } } it 'limits the number of emails to the limit supplied' do - expect { result }.not_to change(ProjectMember, :count) - expect(result[:status]).to eq(:error) + expect_not_to_create_members expect(result[:message]).to eq('Too many users specified (limit is 1)') end end @@ -91,7 +93,7 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: emails, limit: -1 } } it 'does not limit number of emails' do - expect { result }.to change(ProjectMember, :count).by(101) + expect_to_create_members(count: 101) expect(result[:status]).to eq(:success) end end @@ -101,7 +103,7 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: project_user.email } } it 'adds an existing user to members' do - expect { result }.to change(ProjectMember, :count).by(1) + expect_to_create_members(count: 1) expect(result[:status]).to eq(:success) expect(project.users).to include project_user end @@ -111,8 +113,7 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: project_user.email, access_level: -1 } } it 'returns an error' do - expect { result }.not_to change(ProjectMember, :count) - expect(result[:status]).to eq(:error) + expect_not_to_create_members expect(result[:message][project_user.email]).to eq("Access level is not included in the list") end end @@ -122,7 +123,7 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: "#{invited_member.invite_email},#{project_user.email}" } } it 'adds new email and returns an error for the already invited email' do - expect { result }.to change(ProjectMember, :count).by(1) + expect_to_create_members(count: 1) expect(result[:status]).to eq(:error) expect(result[:message][invited_member.invite_email]).to eq("Member already invited to #{project.name}") expect(project.users).to include project_user @@ -134,7 +135,7 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: "#{requested_member.user.email},#{project_user.email}" } } it 'adds new email and returns an error for the already invited email' do - expect { result }.to change(ProjectMember, :count).by(1) + expect_to_create_members(count: 1) expect(result[:status]).to eq(:error) expect(result[:message][requested_member.user.email]) .to eq("Member cannot be invited because they already requested to join #{project.name}") @@ -147,10 +148,19 @@ RSpec.describe Members::InviteService, :aggregate_failures do let(:params) { { email: "#{existing_member.user.email},#{project_user.email}" } } it 'adds new email and returns an error for the already invited email' do - expect { result }.to change(ProjectMember, :count).by(1) + expect_to_create_members(count: 1) expect(result[:status]).to eq(:error) expect(result[:message][existing_member.user.email]).to eq("Already a member of #{project.name}") expect(project.users).to include project_user end end + + def expect_to_create_members(count:) + expect { result }.to change(ProjectMember, :count).by(count) + end + + def expect_not_to_create_members + expect { result }.not_to change(ProjectMember, :count) + expect(result[:status]).to eq(:error) + end end diff --git a/spec/services/projects/fork_service_spec.rb b/spec/services/projects/fork_service_spec.rb index df02f8ea15d..276656656ec 100644 --- a/spec/services/projects/fork_service_spec.rb +++ b/spec/services/projects/fork_service_spec.rb @@ -403,7 +403,7 @@ RSpec.describe Projects::ForkService do end context 'when forking with object pools' do - let(:fork_from_project) { create(:project, :public) } + let(:fork_from_project) { create(:project, :repository, :public) } let(:forker) { create(:user) } context 'when no pool exists' do diff --git a/spec/services/projects/unlink_fork_service_spec.rb b/spec/services/projects/unlink_fork_service_spec.rb index 2a8965e62ce..90def365fca 100644 --- a/spec/services/projects/unlink_fork_service_spec.rb +++ b/spec/services/projects/unlink_fork_service_spec.rb @@ -207,6 +207,17 @@ RSpec.describe Projects::UnlinkForkService, :use_clean_rails_memory_store_cachin end end + context 'a project with pool repository' do + let(:project) { create(:project, :public, :repository) } + let!(:pool_repository) { create(:pool_repository, :ready, source_project: project) } + + subject { described_class.new(project, user) } + + it 'when unlinked leaves pool repository' do + expect { subject.execute }.to change { project.reload.has_pool_repository? }.from(true).to(false) + end + end + context 'when given project is not part of a fork network' do let!(:project_without_forks) { create(:project, :public) } |