diff options
author | Yorick Peterse <yorickpeterse@gmail.com> | 2019-03-04 21:36:52 +0300 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2019-03-04 21:36:52 +0300 |
commit | b50ad884608668c5db50eb1b0287f613e32aef25 (patch) | |
tree | 0e2fd877999ae2d3ab1e83b62a4d69ad4ab2e9ea /spec/services | |
parent | 03340f0987ac61ef4c884d4730e2fd3cbff113c5 (diff) | |
parent | 211c4e5985bf40afe7cf2391c76a6cfde153fb49 (diff) |
Merge branch '2802-security-add-public-internal-groups-as-members-to-your-project-idor' into 'master'
Add public/internal groups as members to your Project(IDOR)
See merge request gitlab/gitlabhq!2898
Diffstat (limited to 'spec/services')
-rw-r--r-- | spec/services/projects/group_links/create_service_spec.rb | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/spec/services/projects/group_links/create_service_spec.rb b/spec/services/projects/group_links/create_service_spec.rb index ffb270d277e..68fd82b4cbe 100644 --- a/spec/services/projects/group_links/create_service_spec.rb +++ b/spec/services/projects/group_links/create_service_spec.rb @@ -12,6 +12,10 @@ describe Projects::GroupLinks::CreateService, '#execute' do end let(:subject) { described_class.new(project, user, opts) } + before do + group.add_developer(user) + end + it 'adds group to project' do expect { subject.execute(group) }.to change { project.project_group_links.count }.from(0).to(1) end @@ -19,4 +23,8 @@ describe Projects::GroupLinks::CreateService, '#execute' do it 'returns false if group is blank' do expect { subject.execute(nil) }.not_to change { project.project_group_links.count } end + + it 'returns error if user is not allowed to share with a group' do + expect { subject.execute(create :group) }.not_to change { project.project_group_links.count } + end end |