diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-05-31 21:10:31 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-05-31 21:10:31 +0300 |
commit | e9885f7a36065b9b45a35feb6c427c7742a906a4 (patch) | |
tree | bffa88df5eadcdf282eb0904a925b7c3cec13027 /spec/services | |
parent | fab00cd7efb84b369dfb45cabb797f7feace4b66 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services')
-rw-r--r-- | spec/services/packages/ml_model/create_package_file_service_spec.rb | 94 | ||||
-rw-r--r-- | spec/services/packages/ml_model/find_or_create_package_service_spec.rb | 67 |
2 files changed, 161 insertions, 0 deletions
diff --git a/spec/services/packages/ml_model/create_package_file_service_spec.rb b/spec/services/packages/ml_model/create_package_file_service_spec.rb new file mode 100644 index 00000000000..d749aee227a --- /dev/null +++ b/spec/services/packages/ml_model/create_package_file_service_spec.rb @@ -0,0 +1,94 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Packages::MlModel::CreatePackageFileService, feature_category: :mlops do + describe '#execute' do + let_it_be(:project) { create(:project) } + let_it_be(:user) { create(:user) } + let_it_be(:pipeline) { create(:ci_pipeline, user: user, project: project) } + let_it_be(:file_name) { 'myfile.tar.gz.1' } + + let(:build) { instance_double(Ci::Build, pipeline: pipeline) } + + let(:sha256) { '440e5e148a25331bbd7991575f7d54933c0ebf6cc735a18ee5066ac1381bb590' } + let(:temp_file) { Tempfile.new("test") } + let(:file) { UploadedFile.new(temp_file.path, sha256: sha256) } + let(:package_service) { double } + + subject(:execute_service) { described_class.new(project, user, params).execute } + + before do + FileUtils.touch(temp_file) + end + + after do + FileUtils.rm_f(temp_file) + end + + context 'without existing package' do + let(:params) do + { + package_name: 'new_model', + package_version: '1.0.0', + file: file, + file_name: file_name + } + end + + it 'creates package file', :aggregate_failures do + expect { execute_service } + .to change { project.packages.ml_model.count }.by(1) + .and change { Packages::PackageFile.count }.by(1) + .and change { Packages::PackageFileBuildInfo.count }.by(0) + + new_model = project.packages.ml_model.last + package_file = new_model.package_files.last + + aggregate_failures do + expect(new_model.name).to eq('new_model') + expect(new_model.version).to eq('1.0.0') + expect(new_model.status).to eq('default') + expect(package_file.package).to eq(new_model) + expect(package_file.file_name).to eq(file_name) + expect(package_file.size).to eq(file.size) + expect(package_file.file_sha256).to eq(sha256) + end + end + end + + context 'with existing package' do + let_it_be(:model) { create(:ml_model_package, creator: user, project: project, version: '0.1.0') } + + let(:params) do + { + package_name: model.name, + package_version: model.version, + file: file, + file_name: file_name, + status: :hidden, + build: build + } + end + + it 'adds the package file and updates status and ci_build', :aggregate_failures do + expect { execute_service } + .to change { project.packages.ml_model.count }.by(0) + .and change { model.package_files.count }.by(1) + .and change { Packages::PackageFileBuildInfo.count }.by(1) + + model.reload + + package_file = model.package_files.last + + expect(model.build_infos.first.pipeline).to eq(build.pipeline) + expect(model.status).to eq('hidden') + + expect(package_file.package).to eq(model) + expect(package_file.file_name).to eq(file_name) + expect(package_file.size).to eq(file.size) + expect(package_file.file_sha256).to eq(sha256) + end + end + end +end diff --git a/spec/services/packages/ml_model/find_or_create_package_service_spec.rb b/spec/services/packages/ml_model/find_or_create_package_service_spec.rb new file mode 100644 index 00000000000..6e1e17da0e6 --- /dev/null +++ b/spec/services/packages/ml_model/find_or_create_package_service_spec.rb @@ -0,0 +1,67 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Packages::MlModel::FindOrCreatePackageService, feature_category: :mlops do + let_it_be(:project) { create(:project) } + let_it_be(:user) { project.creator } + let_it_be(:ci_build) { create(:ci_build, :running, user: user, project: project) } + + let(:base_params) do + { + name: 'mymodel', + version: '0.0.1' + } + end + + let(:params) { base_params } + + describe '#execute' do + subject(:execute_service) { described_class.new(project, user, params).execute } + + context 'when model does not exist' do + it 'creates the model' do + expect { subject }.to change { project.packages.ml_model.count }.by(1) + + package = project.packages.ml_model.last + + aggregate_failures do + expect(package.creator).to eq(user) + expect(package.package_type).to eq('ml_model') + expect(package.name).to eq('mymodel') + expect(package.version).to eq('0.0.1') + expect(package.build_infos.count).to eq(0) + end + end + + context 'when build is provided' do + let(:params) { base_params.merge(build: ci_build) } + + it 'creates package and package build info' do + expect { subject }.to change { project.packages.ml_model.count }.by(1) + + package = project.packages.ml_model.last + + aggregate_failures do + expect(package.creator).to eq(user) + expect(package.package_type).to eq('ml_model') + expect(package.name).to eq('mymodel') + expect(package.version).to eq('0.0.1') + expect(package.build_infos.first.pipeline).to eq(ci_build.pipeline) + end + end + end + end + + context 'when model already exists' do + it 'does not create a new model', :aggregate_failures do + model = project.packages.ml_model.create!(params) + + expect do + new_model = subject + expect(new_model).to eq(model) + end.not_to change { project.packages.ml_model.count } + end + end + end +end |