diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-11-10 18:12:01 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-11-10 18:12:01 +0300 |
commit | a45283fcd27598eebd66a97041fa7d79d5a33aa5 (patch) | |
tree | a4152ef9cc78afd4596feb5d3905b0488bced2ac /spec/tooling/danger | |
parent | 43d1fef975a24dcaac3ad9bbf20ae9839f5ec9ed (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/tooling/danger')
-rw-r--r-- | spec/tooling/danger/customer_success_spec.rb | 26 | ||||
-rw-r--r-- | spec/tooling/danger/datateam_spec.rb | 46 | ||||
-rw-r--r-- | spec/tooling/danger/sidekiq_queues_spec.rb | 12 |
3 files changed, 42 insertions, 42 deletions
diff --git a/spec/tooling/danger/customer_success_spec.rb b/spec/tooling/danger/customer_success_spec.rb index fd3ead7b2d6..40ab7c79418 100644 --- a/spec/tooling/danger/customer_success_spec.rb +++ b/spec/tooling/danger/customer_success_spec.rb @@ -17,53 +17,53 @@ RSpec.describe Tooling::Danger::CustomerSuccess do where do { 'with data category changes to Ops and no Customer Success::Impact Check label' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['-data_category: cat1', '+data_category: operational'], customer_labeled: false, impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with data category changes and Customer Success::Impact Check label' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml], changed_lines: ['-data_category: cat1', '+data_category: operational'], customer_labeled: true, impacted: false, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with metric file changes and no data category changes' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml], changed_lines: ['-product_stage: growth'], customer_labeled: false, impacted: false, impacted_files: [] }, 'with data category changes from Ops' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['-data_category: operational', '+data_category: cat2'], customer_labeled: false, impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with data category removed' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['-data_category: operational'], customer_labeled: false, impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with data category added' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+data_category: operational'], customer_labeled: false, impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with data category in uppercase' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+data_category: Operational'], customer_labeled: false, impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] } } end diff --git a/spec/tooling/danger/datateam_spec.rb b/spec/tooling/danger/datateam_spec.rb index 85fcc20fd7c..9d8aaf08520 100644 --- a/spec/tooling/danger/datateam_spec.rb +++ b/spec/tooling/danger/datateam_spec.rb @@ -17,95 +17,95 @@ RSpec.describe Tooling::Danger::Datateam do where do { 'with structure.sql subtraction changes and no Data Warehouse::Impact Check label' => { - modified_files: %w(db/structure.sql app/models/user.rb), + modified_files: %w[db/structure.sql app/models/user.rb], changed_lines: ['-group_id bigint NOT NULL'], mr_labels: [], impacted: true, - impacted_files: %w(db/structure.sql) + impacted_files: %w[db/structure.sql] }, 'with structure.sql subtraction changes and Data Warehouse::Impact Check label' => { - modified_files: %w(db/structure.sql), + modified_files: %w[db/structure.sql], changed_lines: ['-group_id bigint NOT NULL)'], mr_labels: ['Data Warehouse::Impact Check'], impacted: false, - impacted_files: %w(db/structure.sql) + impacted_files: %w[db/structure.sql] }, 'with structure.sql addition changes and no Data Warehouse::Impact Check label' => { - modified_files: %w(db/structure.sql app/models/user.rb), + modified_files: %w[db/structure.sql app/models/user.rb], changed_lines: ['+group_id bigint NOT NULL'], mr_labels: [], impacted: false, - impacted_files: %w(db/structure.sql) + impacted_files: %w[db/structure.sql] }, 'with user model changes' => { - modified_files: %w(app/models/users.rb), + modified_files: %w[app/models/users.rb], changed_lines: ['+has_one :namespace'], mr_labels: [], impacted: false, impacted_files: [] }, 'with perfomance indicator changes and no Data Warehouse::Impact Check label' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+-gmau'], mr_labels: [], impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with perfomance indicator changes and Data Warehouse::Impact Check label' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml], changed_lines: ['+-gmau'], mr_labels: ['Data Warehouse::Impact Check'], impacted: false, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with metric file changes and no performance indicator changes' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml], changed_lines: ['-product_stage: growth'], mr_labels: [], impacted: false, impacted_files: [] }, 'with metric file changes and no performance indicator changes and other label' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml], changed_lines: ['-product_stage: growth'], mr_labels: ['type::maintenance'], impacted: false, impacted_files: [] }, 'with performance indicator changes and other label' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+-gmau'], mr_labels: ['type::maintenance'], impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with performance indicator changes, Data Warehouse::Impact Check and other label' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+-gmau'], mr_labels: ['type::maintenance', 'Data Warehouse::Impact Check'], impacted: false, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with performance indicator changes and other labels' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+-gmau'], mr_labels: ['type::maintenance', 'Data Warehouse::Impacted'], impacted: false, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with metric status removed' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+status: removed'], mr_labels: ['type::maintenance'], impacted: true, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] }, 'with metric status active' => { - modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb), + modified_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb], changed_lines: ['+status: active'], mr_labels: ['type::maintenance'], impacted: false, - impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml) + impacted_files: %w[config/metrics/20210216182127_user_secret_detection_jobs.yml] } } end diff --git a/spec/tooling/danger/sidekiq_queues_spec.rb b/spec/tooling/danger/sidekiq_queues_spec.rb index 5ebcb018cc3..143ea9732cd 100644 --- a/spec/tooling/danger/sidekiq_queues_spec.rb +++ b/spec/tooling/danger/sidekiq_queues_spec.rb @@ -17,12 +17,12 @@ RSpec.describe Tooling::Danger::SidekiqQueues do using RSpec::Parameterized::TableSyntax where(:modified_files, :changed_queue_files) do - %w(app/workers/all_queues.yml ee/app/workers/all_queues.yml foo) | %w(app/workers/all_queues.yml ee/app/workers/all_queues.yml) - %w(app/workers/all_queues.yml ee/app/workers/all_queues.yml) | %w(app/workers/all_queues.yml ee/app/workers/all_queues.yml) - %w(app/workers/all_queues.yml foo) | %w(app/workers/all_queues.yml) - %w(ee/app/workers/all_queues.yml foo) | %w(ee/app/workers/all_queues.yml) - %w(foo) | %w() - %w() | %w() + %w[app/workers/all_queues.yml ee/app/workers/all_queues.yml foo] | %w[app/workers/all_queues.yml ee/app/workers/all_queues.yml] + %w[app/workers/all_queues.yml ee/app/workers/all_queues.yml] | %w[app/workers/all_queues.yml ee/app/workers/all_queues.yml] + %w[app/workers/all_queues.yml foo] | %w[app/workers/all_queues.yml] + %w[ee/app/workers/all_queues.yml foo] | %w[ee/app/workers/all_queues.yml] + %w[foo] | %w[] + %w[] | %w[] end with_them do |