diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-10 18:11:01 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-10 18:11:01 +0300 |
commit | ae1b3d982482280f22a907faba2c9ba02f4d1db1 (patch) | |
tree | 5c3312879a2c554e1e73a175878ea7eb7a87ac10 /spec/tooling | |
parent | e1bfa7aef2346a8c2d4e0ae0c69bf7649896f556 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/tooling')
-rw-r--r-- | spec/tooling/danger/stable_branch_spec.rb | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/spec/tooling/danger/stable_branch_spec.rb b/spec/tooling/danger/stable_branch_spec.rb index 08fd25b30e0..87c69a3f9f8 100644 --- a/spec/tooling/danger/stable_branch_spec.rb +++ b/spec/tooling/danger/stable_branch_spec.rb @@ -34,6 +34,14 @@ RSpec.describe Tooling::Danger::StableBranch, feature_category: :delivery do end end + shared_examples 'with a warning' do |failure_message| + it 'fails' do + expect(stable_branch).to receive(:warn).with(failure_message) + + subject + end + end + context 'when not applicable' do where(:stable_branch?, :security_mr?) do true | true @@ -103,17 +111,13 @@ RSpec.describe Tooling::Danger::StableBranch, feature_category: :delivery do context 'when not an applicable version' do let(:target_branch) { '14-9-stable-ee' } - it_behaves_like 'with a failure', described_class::VERSION_ERROR_MESSAGE + it_behaves_like 'with a warning', described_class::VERSION_ERROR_MESSAGE end context 'when the version API request fails' do let(:response_success) { false } - it 'adds a warning' do - expect(stable_branch).to receive(:warn).with(described_class::FAILED_VERSION_REQUEST_MESSAGE) - - subject - end + it_behaves_like 'with a warning', described_class::FAILED_VERSION_REQUEST_MESSAGE end context 'when more than one page of versions is needed' do |