diff options
author | Douwe Maan <douwe@selenight.nl> | 2017-11-03 21:48:15 +0300 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2017-11-06 16:46:53 +0300 |
commit | a10925e1c37e7dab19de346c553311adfaccb86c (patch) | |
tree | ee211cc4bc6a830284a23583cd3d06e529793b10 /spec/validators/project_path_validator_spec.rb | |
parent | 97b80fefeb5da20798423b62b63fa9faa08ac118 (diff) |
Reallow project paths ending in periods
Diffstat (limited to 'spec/validators/project_path_validator_spec.rb')
-rw-r--r-- | spec/validators/project_path_validator_spec.rb | 38 |
1 files changed, 38 insertions, 0 deletions
diff --git a/spec/validators/project_path_validator_spec.rb b/spec/validators/project_path_validator_spec.rb new file mode 100644 index 00000000000..8bb5e72dc22 --- /dev/null +++ b/spec/validators/project_path_validator_spec.rb @@ -0,0 +1,38 @@ +require 'spec_helper' + +describe ProjectPathValidator do + let(:validator) { described_class.new(attributes: [:path]) } + + describe '.valid_path?' do + it 'handles invalid utf8' do + expect(described_class.valid_path?("a\0weird\255path")).to be_falsey + end + end + + describe '#validates_each' do + it 'adds a message when the path is not in the correct format' do + project = build(:project) + + validator.validate_each(project, :path, "Path with spaces, and comma's!") + + expect(project.errors[:path]).to include(Gitlab::PathRegex.project_path_format_message) + end + + it 'adds a message when the path is reserved when creating' do + project = build(:project, path: 'blob') + + validator.validate_each(project, :path, 'blob') + + expect(project.errors[:path]).to include('blob is a reserved name') + end + + it 'adds a message when the path is reserved when updating' do + project = create(:project) + project.path = 'blob' + + validator.validate_each(project, :path, 'blob') + + expect(project.errors[:path]).to include('blob is a reserved name') + end + end +end |