diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-06-09 18:09:21 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-06-09 18:09:21 +0300 |
commit | d2675fa4de909714fcc6dc1bdd7bee9ce5e3af34 (patch) | |
tree | 0c0fbdd55fbb3a1616b10775113bf8320c9529c8 /spec/workers/delete_container_repository_worker_spec.rb | |
parent | 48d25238c386a89e8a6af218eeb290936a8f7595 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/workers/delete_container_repository_worker_spec.rb')
-rw-r--r-- | spec/workers/delete_container_repository_worker_spec.rb | 120 |
1 files changed, 104 insertions, 16 deletions
diff --git a/spec/workers/delete_container_repository_worker_spec.rb b/spec/workers/delete_container_repository_worker_spec.rb index ec040eab2d4..a011457444a 100644 --- a/spec/workers/delete_container_repository_worker_spec.rb +++ b/spec/workers/delete_container_repository_worker_spec.rb @@ -3,31 +3,119 @@ require 'spec_helper' RSpec.describe DeleteContainerRepositoryWorker do - let(:registry) { create(:container_repository) } - let(:project) { registry.project } - let(:user) { project.first_owner } + let_it_be(:repository) { create(:container_repository) } - subject { described_class.new } + let(:project) { repository.project } + let(:user) { project.first_owner } + let(:worker) { described_class.new } describe '#perform' do + let(:user_id) { user.id } + let(:repository_id) { repository.id } + + subject(:perform) { worker.perform(user_id, repository_id) } + it 'executes the destroy service' do - service = instance_double(Projects::ContainerRepository::DestroyService) - expect(service).to receive(:execute) - expect(Projects::ContainerRepository::DestroyService).to receive(:new).with(project, user).and_return(service) + expect_destroy_service_execution + + perform + end + + context 'with an invalid user id' do + let(:user_id) { -1 } + + it { expect { perform }.not_to raise_error } + end - subject.perform(user.id, registry.id) + context 'with an invalid repository id' do + let(:repository_id) { -1 } + + it { expect { perform }.not_to raise_error } end - it 'does not raise error when user could not be found' do - expect do - subject.perform(-1, registry.id) - end.not_to raise_error + context 'with a repository being migrated', :freeze_time do + before do + stub_application_setting( + container_registry_pre_import_tags_rate: 0.5, + container_registry_import_timeout: 10.minutes.to_i + ) + end + + shared_examples 'destroying the repository' do + it 'does destroy the repository' do + expect_next_found_instance_of(ContainerRepository) do |container_repository| + expect(container_repository).not_to receive(:tags_count) + end + expect(described_class).not_to receive(:perform_in) + expect_destroy_service_execution + + perform + end + end + + shared_examples 'not re enqueuing job if feature flag is disabled' do + before do + stub_feature_flags(container_registry_migration_phase2_delete_container_repository_worker_support: false) + end + + it_behaves_like 'destroying the repository' + end + + context 'with migration state set to pre importing' do + let_it_be(:repository) { create(:container_repository, :pre_importing) } + + let(:tags_count) { 60 } + let(:delay) { (tags_count * 0.5).seconds + 10.minutes + described_class::FIXED_DELAY } + + it 'does not destroy the repository and re enqueue the job' do + expect_next_found_instance_of(ContainerRepository) do |container_repository| + expect(container_repository).to receive(:tags_count).and_return(tags_count) + end + expect(described_class).to receive(:perform_in).with(delay.from_now) + expect(worker).to receive(:log_extra_metadata_on_done).with(:delete_postponed, delay) + expect(::Projects::ContainerRepository::DestroyService).not_to receive(:new) + + perform + end + + it_behaves_like 'not re enqueuing job if feature flag is disabled' + end + + %i[pre_import_done importing import_aborted].each do |migration_state| + context "with migration state set to #{migration_state}" do + let_it_be(:repository) { create(:container_repository, migration_state) } + + let(:delay) { 10.minutes + described_class::FIXED_DELAY } + + it 'does not destroy the repository and re enqueue the job' do + expect_next_found_instance_of(ContainerRepository) do |container_repository| + expect(container_repository).not_to receive(:tags_count) + end + expect(described_class).to receive(:perform_in).with(delay.from_now) + expect(worker).to receive(:log_extra_metadata_on_done).with(:delete_postponed, delay) + expect(::Projects::ContainerRepository::DestroyService).not_to receive(:new) + + perform + end + + it_behaves_like 'not re enqueuing job if feature flag is disabled' + end + end + + %i[default import_done import_skipped].each do |migration_state| + context "with migration state set to #{migration_state}" do + let_it_be(:repository) { create(:container_repository, migration_state) } + + it_behaves_like 'destroying the repository' + it_behaves_like 'not re enqueuing job if feature flag is disabled' + end + end end - it 'does not raise error when registry could not be found' do - expect do - subject.perform(user.id, -1) - end.not_to raise_error + def expect_destroy_service_execution + service = instance_double(Projects::ContainerRepository::DestroyService) + expect(service).to receive(:execute) + expect(Projects::ContainerRepository::DestroyService).to receive(:new).with(project, user).and_return(service) end end end |