Add latest changes from gitlab-org/gitlab@master

14 files changed, 329 insertions, 93 deletions

diff --git a/spec/factories/gitlab/database/background_migration/batched_migrations.rb b/spec/factories/gitlab/database/background_migration/batched_migrations.rb
index 03ae2e664f0..b45f6ff037b 100644
--- a/spec/factories/gitlab/database/background_migration/batched_migrations.rb
+++ b/spec/factories/gitlab/database/background_migration/batched_migrations.rb
@@ -6,7 +6,7 @@ FactoryBot.define do
     batch_size { 5 }
     sub_batch_size { 1 }
     interval { 2.minutes }
-    job_class_name { 'Gitlab::BackgroundMigration::CopyColumnUsingBackgroundMigrationJob' }
+    job_class_name { 'CopyColumnUsingBackgroundMigrationJob' }
     table_name { :events }
     column_name { :id }
   end
diff --git a/spec/features/projects/active_tabs_spec.rb b/spec/features/projects/active_tabs_spec.rb
index 8001ce0f454..86fe59f003f 100644
--- a/spec/features/projects/active_tabs_spec.rb
+++ b/spec/features/projects/active_tabs_spec.rb
@@ -132,13 +132,13 @@ RSpec.describe 'Project active tab' do
       it_behaves_like 'page has active sub tab', _('Value Stream')
     end
 
-    context 'on project Analytics/"CI / CD"' do
+    context 'on project Analytics/"CI/CD"' do
       before do
-        click_tab(_('CI / CD'))
+        click_tab(_('CI/CD'))
       end
 
       it_behaves_like 'page has active tab', _('Analytics')
-      it_behaves_like 'page has active sub tab', _('CI / CD')
+      it_behaves_like 'page has active sub tab', _('CI/CD')
     end
   end
 end
diff --git a/spec/features/projects/environments/environments_spec.rb b/spec/features/projects/environments/environments_spec.rb
index 27167f95104..de7ff1c473d 100644
--- a/spec/features/projects/environments/environments_spec.rb
+++ b/spec/features/projects/environments/environments_spec.rb
@@ -429,37 +429,67 @@ RSpec.describe 'Environments page', :js do
   end
 
   describe 'environments folders' do
-    before do
-      create(:environment, :will_auto_stop,
-                           project: project,
-                           name: 'staging/review-1',
-                           state: :available)
-      create(:environment, :will_auto_stop,
-                           project: project,
-                           name: 'staging/review-2',
-                           state: :available)
-    end
+    describe 'available environments' do
+      before do
+        create(:environment, :will_auto_stop,
+                            project: project,
+                            name: 'staging/review-1',
+                            state: :available)
+        create(:environment, :will_auto_stop,
+                            project: project,
+                            name: 'staging/review-2',
+                            state: :available)
+      end
 
-    it 'users unfurls an environment folder' do
-      visit_environments(project)
+      it 'users unfurls an environment folder' do
+        visit_environments(project)
 
-      expect(page).not_to have_content 'review-1'
-      expect(page).not_to have_content 'review-2'
-      expect(page).to have_content 'staging 2'
+        expect(page).not_to have_content 'review-1'
+        expect(page).not_to have_content 'review-2'
+        expect(page).to have_content 'staging 2'
 
-      within('.folder-row') do
-        find('.folder-name', text: 'staging').click
-      end
+        within('.folder-row') do
+          find('.folder-name', text: 'staging').click
+        end
 
-      expect(page).to have_content 'review-1'
-      expect(page).to have_content 'review-2'
-      within('.ci-table') do
-        within('[data-qa-selector="environment_item"]', text: 'review-1') do
-          expect(find('.js-auto-stop').text).not_to be_empty
+        expect(page).to have_content 'review-1'
+        expect(page).to have_content 'review-2'
+        within('.ci-table') do
+          within('[data-qa-selector="environment_item"]', text: 'review-1') do
+            expect(find('.js-auto-stop').text).not_to be_empty
+          end
+          within('[data-qa-selector="environment_item"]', text: 'review-2') do
+            expect(find('.js-auto-stop').text).not_to be_empty
+          end
         end
-        within('[data-qa-selector="environment_item"]', text: 'review-2') do
-          expect(find('.js-auto-stop').text).not_to be_empty
+      end
+    end
+
+    describe 'stopped environments' do
+      before do
+        create(:environment, :will_auto_stop,
+                            project: project,
+                            name: 'staging/review-1',
+                            state: :stopped)
+        create(:environment, :will_auto_stop,
+                            project: project,
+                            name: 'staging/review-2',
+                            state: :stopped)
+      end
+
+      it 'users unfurls an environment folder' do
+        visit_environments(project, scope: 'stopped')
+
+        expect(page).not_to have_content 'review-1'
+        expect(page).not_to have_content 'review-2'
+        expect(page).to have_content 'staging 2'
+
+        within('.folder-row') do
+          find('.folder-name', text: 'staging').click
         end
+
+        expect(page).to have_content 'review-1'
+        expect(page).to have_content 'review-2'
       end
     end
   end
diff --git a/spec/features/projects/user_sees_sidebar_spec.rb b/spec/features/projects/user_sees_sidebar_spec.rb
index 616c5065c07..e5ba6b503cc 100644
--- a/spec/features/projects/user_sees_sidebar_spec.rb
+++ b/spec/features/projects/user_sees_sidebar_spec.rb
@@ -201,7 +201,7 @@ RSpec.describe 'Projects > User sees sidebar' do
         expect(page).to have_content 'Operations'
 
         expect(page).not_to have_content 'Repository'
-        expect(page).not_to have_content 'CI / CD'
+        expect(page).not_to have_content 'CI/CD'
         expect(page).not_to have_content 'Merge Requests'
       end
     end
@@ -213,7 +213,7 @@ RSpec.describe 'Projects > User sees sidebar' do
       visit project_path(project)
 
       within('.nav-sidebar') do
-        expect(page).to have_content 'CI / CD'
+        expect(page).to have_content 'CI/CD'
       end
     end
 
diff --git a/spec/features/projects/user_uses_shortcuts_spec.rb b/spec/features/projects/user_uses_shortcuts_spec.rb
index 13ae035e8ef..f97c8d820e3 100644
--- a/spec/features/projects/user_uses_shortcuts_spec.rb
+++ b/spec/features/projects/user_uses_shortcuts_spec.rb
@@ -155,12 +155,12 @@ RSpec.describe 'User uses shortcuts', :js do
     end
   end
 
-  context 'when navigating to the CI / CD pages' do
+  context 'when navigating to the CI/CD pages' do
     it 'redirects to the Jobs page' do
       find('body').native.send_key('g')
       find('body').native.send_key('j')
 
-      expect(page).to have_active_navigation('CI / CD')
+      expect(page).to have_active_navigation('CI/CD')
       expect(page).to have_active_sub_navigation('Jobs')
     end
   end
diff --git a/spec/lib/bulk_imports/groups/graphql/get_milestones_query_spec.rb b/spec/lib/bulk_imports/groups/graphql/get_milestones_query_spec.rb
new file mode 100644
index 00000000000..a38505fbf85
--- /dev/null
+++ b/spec/lib/bulk_imports/groups/graphql/get_milestones_query_spec.rb
@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BulkImports::Groups::Graphql::GetMilestonesQuery do
+  it 'has a valid query' do
+    entity = create(:bulk_import_entity)
+    context = BulkImports::Pipeline::Context.new(entity)
+
+    query = GraphQL::Query.new(
+      GitlabSchema,
+      described_class.to_s,
+      variables: described_class.variables(context)
+    )
+    result = GitlabSchema.static_validator.validate(query)
+
+    expect(result[:errors]).to be_empty
+  end
+
+  describe '#data_path' do
+    it 'returns data path' do
+      expected = %w[data group milestones nodes]
+
+      expect(described_class.data_path).to eq(expected)
+    end
+  end
+
+  describe '#page_info_path' do
+    it 'returns pagination information path' do
+      expected = %w[data group milestones page_info]
+
+      expect(described_class.page_info_path).to eq(expected)
+    end
+  end
+end
diff --git a/spec/lib/bulk_imports/groups/pipelines/milestones_pipeline_spec.rb b/spec/lib/bulk_imports/groups/pipelines/milestones_pipeline_spec.rb
new file mode 100644
index 00000000000..f0c34c65257
--- /dev/null
+++ b/spec/lib/bulk_imports/groups/pipelines/milestones_pipeline_spec.rb
@@ -0,0 +1,151 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BulkImports::Groups::Pipelines::MilestonesPipeline do
+  let_it_be(:user) { create(:user) }
+  let_it_be(:group) { create(:group) }
+  let_it_be(:cursor) { 'cursor' }
+  let_it_be(:timestamp) { Time.new(2020, 01, 01).utc }
+  let_it_be(:bulk_import) { create(:bulk_import, user: user) }
+
+  let(:entity) do
+    create(
+      :bulk_import_entity,
+      bulk_import: bulk_import,
+      source_full_path: 'source/full/path',
+      destination_name: 'My Destination Group',
+      destination_namespace: group.full_path,
+      group: group
+    )
+  end
+
+  let(:context) { BulkImports::Pipeline::Context.new(entity) }
+
+  subject { described_class.new(context) }
+
+  def milestone_data(title)
+    {
+      'title' => title,
+      'description' => 'desc',
+      'state' => 'closed',
+      'start_date' => '2020-10-21',
+      'due_date' => '2020-10-22',
+      'created_at' => timestamp.to_s,
+      'updated_at' => timestamp.to_s
+    }
+  end
+
+  def extracted_data(title:, has_next_page:, cursor: nil)
+    page_info = {
+      'end_cursor' => cursor,
+      'has_next_page' => has_next_page
+    }
+
+    BulkImports::Pipeline::ExtractedData.new(data: [milestone_data(title)], page_info: page_info)
+  end
+
+  before do
+    group.add_owner(user)
+  end
+
+  describe '#run' do
+    it 'imports group milestones' do
+      first_page = extracted_data(title: 'milestone1', has_next_page: true, cursor: cursor)
+      last_page = extracted_data(title: 'milestone2', has_next_page: false)
+
+      allow_next_instance_of(BulkImports::Common::Extractors::GraphqlExtractor) do |extractor|
+        allow(extractor)
+          .to receive(:extract)
+          .and_return(first_page, last_page)
+      end
+
+      expect { subject.run }.to change(Milestone, :count).by(2)
+
+      expect(group.milestones.pluck(:title)).to contain_exactly('milestone1', 'milestone2')
+
+      milestone = group.milestones.last
+
+      expect(milestone.description).to eq('desc')
+      expect(milestone.state).to eq('closed')
+      expect(milestone.start_date.to_s).to eq('2020-10-21')
+      expect(milestone.due_date.to_s).to eq('2020-10-22')
+      expect(milestone.created_at).to eq(timestamp)
+      expect(milestone.updated_at).to eq(timestamp)
+    end
+  end
+
+  describe '#after_run' do
+    context 'when extracted data has next page' do
+      it 'updates tracker information and runs pipeline again' do
+        data = extracted_data(title: 'milestone', has_next_page: true, cursor: cursor)
+
+        expect(subject).to receive(:run)
+
+        subject.after_run(data)
+
+        tracker = entity.trackers.find_by(relation: :milestones)
+
+        expect(tracker.has_next_page).to eq(true)
+        expect(tracker.next_page).to eq(cursor)
+      end
+    end
+
+    context 'when extracted data has no next page' do
+      it 'updates tracker information and does not run pipeline' do
+        data = extracted_data(title: 'milestone', has_next_page: false)
+
+        expect(subject).not_to receive(:run)
+
+        subject.after_run(data)
+
+        tracker = entity.trackers.find_by(relation: :milestones)
+
+        expect(tracker.has_next_page).to eq(false)
+        expect(tracker.next_page).to be_nil
+      end
+    end
+  end
+
+  describe '#load' do
+    it 'creates the milestone' do
+      data = milestone_data('milestone')
+
+      expect { subject.load(context, data) }.to change(Milestone, :count).by(1)
+    end
+
+    context 'when user is not authorized to create the milestone' do
+      before do
+        allow(user).to receive(:can?).with(:admin_milestone, group).and_return(false)
+      end
+
+      it 'raises NotAllowedError' do
+        data = extracted_data(title: 'milestone', has_next_page: false)
+
+        expect { subject.load(context, data) }.to raise_error(::BulkImports::Pipeline::NotAllowedError)
+      end
+    end
+  end
+
+  describe 'pipeline parts' do
+    it { expect(described_class).to include_module(BulkImports::Pipeline) }
+    it { expect(described_class).to include_module(BulkImports::Pipeline::Runner) }
+
+    it 'has extractors' do
+      expect(described_class.get_extractor)
+        .to eq(
+          klass: BulkImports::Common::Extractors::GraphqlExtractor,
+          options: {
+            query: BulkImports::Groups::Graphql::GetMilestonesQuery
+          }
+        )
+    end
+
+    it 'has transformers' do
+      expect(described_class.transformers)
+        .to contain_exactly(
+          { klass: BulkImports::Common::Transformers::ProhibitedAttributesTransformer, options: nil }
+        )
+    end
+  end
+end
diff --git a/spec/lib/bulk_imports/importers/group_importer_spec.rb b/spec/lib/bulk_imports/importers/group_importer_spec.rb
index b4fdb7b5e5b..820a0e03c3d 100644
--- a/spec/lib/bulk_imports/importers/group_importer_spec.rb
+++ b/spec/lib/bulk_imports/importers/group_importer_spec.rb
@@ -22,6 +22,7 @@ RSpec.describe BulkImports::Importers::GroupImporter do
       expect_to_run_pipeline BulkImports::Groups::Pipelines::SubgroupEntitiesPipeline, context: context
       expect_to_run_pipeline BulkImports::Groups::Pipelines::MembersPipeline, context: context
       expect_to_run_pipeline BulkImports::Groups::Pipelines::LabelsPipeline, context: context
+      expect_to_run_pipeline BulkImports::Groups::Pipelines::MilestonesPipeline, context: context
 
       if Gitlab.ee?
         expect_to_run_pipeline('EE::BulkImports::Groups::Pipelines::EpicsPipeline'.constantize, context: context)
diff --git a/spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb b/spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb
new file mode 100644
index 00000000000..8febe850e04
--- /dev/null
+++ b/spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb
@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Gitlab::BackgroundMigration::BatchingStrategies::PrimaryKeyBatchingStrategy, '#next_batch' do
+  let(:batching_strategy) { described_class.new }
+  let(:namespaces) { table(:namespaces) }
+
+  let!(:namespace1) { namespaces.create!(name: 'batchtest1', path: 'batch-test1') }
+  let!(:namespace2) { namespaces.create!(name: 'batchtest2', path: 'batch-test2') }
+  let!(:namespace3) { namespaces.create!(name: 'batchtest3', path: 'batch-test3') }
+  let!(:namespace4) { namespaces.create!(name: 'batchtest4', path: 'batch-test4') }
+
+  context 'when starting on the first batch' do
+    it 'returns the bounds of the next batch' do
+      batch_bounds = batching_strategy.next_batch(:namespaces, :id, batch_min_value: namespace1.id, batch_size: 3)
+
+      expect(batch_bounds).to eq([namespace1.id, namespace3.id])
+    end
+  end
+
+  context 'when additional batches remain' do
+    it 'returns the bounds of the next batch' do
+      batch_bounds = batching_strategy.next_batch(:namespaces, :id, batch_min_value: namespace2.id, batch_size: 3)
+
+      expect(batch_bounds).to eq([namespace2.id, namespace4.id])
+    end
+  end
+
+  context 'when on the final batch' do
+    it 'returns the bounds of the next batch' do
+      batch_bounds = batching_strategy.next_batch(:namespaces, :id, batch_min_value: namespace4.id, batch_size: 3)
+
+      expect(batch_bounds).to eq([namespace4.id, namespace4.id])
+    end
+  end
+
+  context 'when no additional batches remain' do
+    it 'returns nil' do
+      batch_bounds = batching_strategy.next_batch(:namespaces, :id, batch_min_value: namespace4.id + 1, batch_size: 1)
+
+      expect(batch_bounds).to be_nil
+    end
+  end
+end
diff --git a/spec/lib/gitlab/database/background_migration/batched_migration_spec.rb b/spec/lib/gitlab/database/background_migration/batched_migration_spec.rb
index df0abaae721..f4a939e7c1f 100644
--- a/spec/lib/gitlab/database/background_migration/batched_migration_spec.rb
+++ b/spec/lib/gitlab/database/background_migration/batched_migration_spec.rb
@@ -122,7 +122,7 @@ RSpec.describe Gitlab::Database::BackgroundMigration::BatchedMigration, type: :m
   end
 
   describe '#batch_class' do
-    let(:batch_class) { Gitlab::Database::BackgroundMigration::PrimaryKeyBatchingStrategy}
+    let(:batch_class) { Gitlab::BackgroundMigration::BatchingStrategies::PrimaryKeyBatchingStrategy}
     let(:batched_migration) { build(:batched_background_migration) }
 
     it 'returns the class of the batch strategy for the migration' do
@@ -130,31 +130,31 @@ RSpec.describe Gitlab::Database::BackgroundMigration::BatchedMigration, type: :m
     end
   end
 
-  shared_examples_for 'an attr_writer that normalizes assigned class names' do |attribute_name|
+  shared_examples_for 'an attr_writer that demodulizes assigned class names' do |attribute_name|
     let(:batched_migration) { build(:batched_background_migration) }
 
-    context 'when the toplevel namespace prefix exists' do
-      it 'removes the leading prefix' do
+    context 'when a module name exists' do
+      it 'removes the module name' do
         batched_migration.public_send(:"#{attribute_name}=", '::Foo::Bar')
 
-        expect(batched_migration[attribute_name]).to eq('Foo::Bar')
+        expect(batched_migration[attribute_name]).to eq('Bar')
       end
     end
 
-    context 'when the toplevel namespace prefix does not exist' do
+    context 'when a module name does not exist' do
       it 'does not change the given class name' do
-        batched_migration.public_send(:"#{attribute_name}=", '::Foo::Bar')
+        batched_migration.public_send(:"#{attribute_name}=", 'Bar')
 
-        expect(batched_migration[attribute_name]).to eq('Foo::Bar')
+        expect(batched_migration[attribute_name]).to eq('Bar')
       end
     end
   end
 
   describe '#job_class_name=' do
-    it_behaves_like 'an attr_writer that normalizes assigned class names', :job_class_name
+    it_behaves_like 'an attr_writer that demodulizes assigned class names', :job_class_name
   end
 
   describe '#batch_class_name=' do
-    it_behaves_like 'an attr_writer that normalizes assigned class names', :batch_class_name
+    it_behaves_like 'an attr_writer that demodulizes assigned class names', :batch_class_name
   end
 end
diff --git a/spec/lib/gitlab/database/background_migration/primary_key_batching_strategy_spec.rb b/spec/lib/gitlab/database/background_migration/primary_key_batching_strategy_spec.rb
deleted file mode 100644
index 6baf6f319cf..00000000000
--- a/spec/lib/gitlab/database/background_migration/primary_key_batching_strategy_spec.rb
+++ /dev/null
@@ -1,44 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Gitlab::Database::BackgroundMigration::PrimaryKeyBatchingStrategy, '#next_batch' do
-  let(:batching_strategy) { described_class.new }
-
-  let_it_be(:event1) { create(:event) }
-  let_it_be(:event2) { create(:event) }
-  let_it_be(:event3) { create(:event) }
-  let_it_be(:event4) { create(:event) }
-
-  context 'when starting on the first batch' do
-    it 'returns the bounds of the next batch' do
-      batch_bounds = batching_strategy.next_batch(:events, :id, batch_min_value: event1.id, batch_size: 3)
-
-      expect(batch_bounds).to eq([event1.id, event3.id])
-    end
-  end
-
-  context 'when additional batches remain' do
-    it 'returns the bounds of the next batch' do
-      batch_bounds = batching_strategy.next_batch(:events, :id, batch_min_value: event2.id, batch_size: 3)
-
-      expect(batch_bounds).to eq([event2.id, event4.id])
-    end
-  end
-
-  context 'when on the final batch' do
-    it 'returns the bounds of the next batch' do
-      batch_bounds = batching_strategy.next_batch(:events, :id, batch_min_value: event4.id, batch_size: 3)
-
-      expect(batch_bounds).to eq([event4.id, event4.id])
-    end
-  end
-
-  context 'when no additional batches remain' do
-    it 'returns nil' do
-      batch_bounds = batching_strategy.next_batch(:events, :id, batch_min_value: event4.id + 1, batch_size: 1)
-
-      expect(batch_bounds).to be_nil
-    end
-  end
-end
diff --git a/spec/requests/api/lint_spec.rb b/spec/requests/api/lint_spec.rb
index b5bf697e9e3..cf8cac773f5 100644
--- a/spec/requests/api/lint_spec.rb
+++ b/spec/requests/api/lint_spec.rb
@@ -406,6 +406,24 @@ RSpec.describe API::Lint do
       end
     end
 
+    context 'with an empty repository' do
+      let_it_be(:empty_project) { create(:project_empty_repo) }
+      let_it_be(:yaml_content) do
+        File.read(Rails.root.join('spec/support/gitlab_stubs/gitlab_ci.yml'))
+      end
+
+      before do
+        empty_project.add_developer(api_user)
+      end
+
+      it 'passes validation without errors' do
+        post api("/projects/#{empty_project.id}/ci/lint", api_user), params: { content: yaml_content }
+        expect(response).to have_gitlab_http_status(:ok)
+        expect(json_response['valid']).to eq(true)
+        expect(json_response['errors']).to eq([])
+      end
+    end
+
     context 'when unauthenticated' do
       let_it_be(:api_user) { nil }
 
diff --git a/spec/support/shared_contexts/navbar_structure_context.rb b/spec/support/shared_contexts/navbar_structure_context.rb
index 566cc3d3827..671c0cdf79c 100644
--- a/spec/support/shared_contexts/navbar_structure_context.rb
+++ b/spec/support/shared_contexts/navbar_structure_context.rb
@@ -5,7 +5,7 @@ RSpec.shared_context 'project navbar structure' do
     {
       nav_item: _('Analytics'),
       nav_sub_items: [
-        _('CI / CD'),
+        _('CI/CD'),
         (_('Code Review') if Gitlab.ee?),
         (_('Merge Request') if Gitlab.ee?),
         _('Repository'),
@@ -63,7 +63,7 @@ RSpec.shared_context 'project navbar structure' do
         nav_sub_items: []
       },
       {
-        nav_item: _('CI / CD'),
+        nav_item: _('CI/CD'),
         nav_sub_items: [
           _('Pipelines'),
           s_('Pipelines|Editor'),
@@ -111,7 +111,7 @@ RSpec.shared_context 'project navbar structure' do
           _('Webhooks'),
           _('Access Tokens'),
           _('Repository'),
-          _('CI / CD'),
+          _('CI/CD'),
           _('Operations')
         ].compact
       }
@@ -138,7 +138,7 @@ RSpec.shared_context 'group navbar structure' do
         _('Integrations'),
         _('Projects'),
         _('Repository'),
-        _('CI / CD'),
+        _('CI/CD'),
         _('Packages & Registries'),
         _('Webhooks')
       ]
diff --git a/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb b/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb
index e34d8b91b38..99d7dfc8acb 100644
--- a/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb
+++ b/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb
@@ -204,7 +204,7 @@ RSpec.describe 'layouts/nav/sidebar/_project' do
       it 'does not show the ci/cd settings tab' do
         render
 
-        expect(rendered).not_to have_link('CI / CD', href: project_settings_ci_cd_path(project))
+        expect(rendered).not_to have_link('CI/CD', href: project_settings_ci_cd_path(project))
       end
     end
 
@@ -214,7 +214,7 @@ RSpec.describe 'layouts/nav/sidebar/_project' do
       it 'shows the ci/cd settings tab' do
         render
 
-        expect(rendered).to have_link('CI / CD', href: project_settings_ci_cd_path(project))
+        expect(rendered).to have_link('CI/CD', href: project_settings_ci_cd_path(project))
       end
     end
   end