diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-09-02 00:09:24 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-09-02 00:09:24 +0300 |
commit | 58c1969d4a05cd3bf4b0b96da7cbd219d58d6328 (patch) | |
tree | ca81061558056547698cc5794554cc9c564a5c69 /workhorse/internal/upstream | |
parent | d551c55bb0e691f06655bcda5fe9566164fd3e46 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'workhorse/internal/upstream')
-rw-r--r-- | workhorse/internal/upstream/roundtripper/roundtripper.go | 10 | ||||
-rw-r--r-- | workhorse/internal/upstream/roundtripper/roundtripper_test.go | 56 |
2 files changed, 61 insertions, 5 deletions
diff --git a/workhorse/internal/upstream/roundtripper/roundtripper.go b/workhorse/internal/upstream/roundtripper/roundtripper.go index 947b80ddcf6..fdbca5c0120 100644 --- a/workhorse/internal/upstream/roundtripper/roundtripper.go +++ b/workhorse/internal/upstream/roundtripper/roundtripper.go @@ -2,6 +2,7 @@ package roundtripper import ( "context" + "crypto/tls" "fmt" "net" "net/http" @@ -15,10 +16,6 @@ import ( ) func mustParseAddress(address, scheme string) string { - if scheme == "https" { - panic("TLS is not supported for backend connections") - } - for _, suffix := range []string{"", ":" + scheme} { address += suffix if host, port, err := net.SplitHostPort(address); err == nil && host != "" && port != "" { @@ -31,9 +28,14 @@ func mustParseAddress(address, scheme string) string { // NewBackendRoundTripper returns a new RoundTripper instance using the provided values func NewBackendRoundTripper(backend *url.URL, socket string, proxyHeadersTimeout time.Duration, developmentMode bool) http.RoundTripper { + return newBackendRoundTripper(backend, socket, proxyHeadersTimeout, developmentMode, nil) +} + +func newBackendRoundTripper(backend *url.URL, socket string, proxyHeadersTimeout time.Duration, developmentMode bool, tlsConf *tls.Config) http.RoundTripper { // Copied from the definition of http.DefaultTransport. We can't literally copy http.DefaultTransport because of its hidden internal state. transport, dialer := newBackendTransport() transport.ResponseHeaderTimeout = proxyHeadersTimeout + transport.TLSClientConfig = tlsConf if backend != nil && socket == "" { address := mustParseAddress(backend.Host, backend.Scheme) diff --git a/workhorse/internal/upstream/roundtripper/roundtripper_test.go b/workhorse/internal/upstream/roundtripper/roundtripper_test.go index 79ffa244918..eed71cc5bae 100644 --- a/workhorse/internal/upstream/roundtripper/roundtripper_test.go +++ b/workhorse/internal/upstream/roundtripper/roundtripper_test.go @@ -1,6 +1,13 @@ package roundtripper import ( + "crypto/tls" + "crypto/x509" + "fmt" + "io/ioutil" + "net/http" + "net/http/httptest" + "net/url" "strconv" "testing" @@ -12,6 +19,7 @@ func TestMustParseAddress(t *testing.T) { {"1.2.3.4:56", "http", "1.2.3.4:56"}, {"[::1]:23", "http", "::1:23"}, {"4.5.6.7", "http", "4.5.6.7:http"}, + {"4.5.6.7", "https", "4.5.6.7:https"}, } for i, example := range successExamples { t.Run(strconv.Itoa(i), func(t *testing.T) { @@ -23,7 +31,6 @@ func TestMustParseAddress(t *testing.T) { func TestMustParseAddressPanic(t *testing.T) { panicExamples := []struct{ address, scheme string }{ {"1.2.3.4", ""}, - {"1.2.3.4", "https"}, } for i, panicExample := range panicExamples { @@ -37,3 +44,50 @@ func TestMustParseAddressPanic(t *testing.T) { }) } } + +func TestSupportsHTTPBackend(t *testing.T) { + ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + w.WriteHeader(200) + fmt.Fprint(w, "successful response") + })) + defer ts.Close() + + testNewBackendRoundTripper(t, ts, nil, "successful response") +} + +func TestSupportsHTTPSBackend(t *testing.T) { + ts := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + w.WriteHeader(200) + fmt.Fprint(w, "successful response") + })) + defer ts.Close() + + certpool := x509.NewCertPool() + certpool.AddCert(ts.Certificate()) + tlsClientConfig := &tls.Config{ + RootCAs: certpool, + } + + testNewBackendRoundTripper(t, ts, tlsClientConfig, "successful response") +} + +func testNewBackendRoundTripper(t *testing.T, ts *httptest.Server, tlsClientConfig *tls.Config, expectedResponseBody string) { + t.Helper() + + backend, err := url.Parse(ts.URL) + require.NoError(t, err, "parse url") + + rt := newBackendRoundTripper(backend, "", 0, true, tlsClientConfig) + + req, err := http.NewRequest("GET", ts.URL+"/", nil) + require.NoError(t, err, "build request") + + response, err := rt.RoundTrip(req) + require.NoError(t, err, "perform roundtrip") + defer response.Body.Close() + + body, err := ioutil.ReadAll(response.Body) + require.NoError(t, err) + + require.Equal(t, expectedResponseBody, string(body)) +} |