diff options
Diffstat (limited to '.rubocop_todo/lint/redundant_cop_disable_directive.yml')
| -rw-r--r-- | .rubocop_todo/lint/redundant_cop_disable_directive.yml | 36 |
1 files changed, 24 insertions, 12 deletions
diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index b0b5697536e..a2dd002b54f 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -1,12 +1,12 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Lint/RedundantCopDisableDirective: - # Used to be enabled in "grace period" and is now disabled due to too many - # silenced offenses. - # See https://gitlab.com/gitlab-org/gitlab/-/issues/376133 + # Offense count: 357 + # Temporarily disabled due to too many offenses Enabled: false Exclude: - 'app/controllers/concerns/enforces_two_factor_authentication.rb' + - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/web_hooks/hook_log_actions.rb' - 'app/controllers/groups/autocomplete_sources_controller.rb' - 'app/controllers/groups/labels_controller.rb' @@ -14,7 +14,6 @@ Lint/RedundantCopDisableDirective: - 'app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb' - 'app/finders/autocomplete/move_to_project_finder.rb' - 'app/finders/autocomplete/routes_finder.rb' - - 'app/finders/autocomplete/users_finder.rb' - 'app/finders/ci/daily_build_group_report_results_finder.rb' - 'app/finders/ci/runner_jobs_finder.rb' - 'app/finders/groups_finder.rb' @@ -24,6 +23,7 @@ Lint/RedundantCopDisableDirective: - 'app/graphql/resolvers/project_milestones_resolver.rb' - 'app/graphql/types/base_enum.rb' - 'app/graphql/types/ci/runner_web_url_edge.rb' + - 'app/graphql/types/commit_signatures/verification_status_enum.rb' - 'app/graphql/types/packages/helm/dependency_type.rb' - 'app/graphql/types/projects/service_type_enum.rb' - 'app/helpers/diff_helper.rb' @@ -34,6 +34,7 @@ Lint/RedundantCopDisableDirective: - 'app/models/concerns/from_except.rb' - 'app/models/concerns/from_intersect.rb' - 'app/models/concerns/from_union.rb' + - 'app/models/concerns/redis_cacheable.rb' - 'app/models/project_statistics.rb' - 'app/models/user.rb' - 'app/presenters/dev_ops_report/metric_presenter.rb' @@ -43,7 +44,9 @@ Lint/RedundantCopDisableDirective: - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - 'app/services/ci/register_job_service.rb' - 'app/services/ci/retry_job_service.rb' + - 'app/services/ci/runners/bulk_delete_runners_service.rb' - 'app/services/database/consistency_check_service.rb' + - 'app/services/groups/import_export/import_service.rb' - 'app/services/issues/export_csv_service.rb' - 'app/services/labels/transfer_service.rb' - 'app/services/members/create_service.rb' @@ -52,8 +55,9 @@ Lint/RedundantCopDisableDirective: - 'app/services/members/standard_member_builder.rb' - 'app/services/projects/auto_devops/disable_service.rb' - 'app/services/projects/open_issues_count_service.rb' + - 'app/services/releases/create_service.rb' + - 'app/services/releases/update_service.rb' - 'app/services/spam/spam_action_service.rb' - - 'app/services/users/migrate_to_ghost_user_service.rb' - 'app/services/web_hook_service.rb' - 'app/uploaders/object_storage/cdn/google_ip_cache.rb' - 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb' @@ -85,6 +89,7 @@ Lint/RedundantCopDisableDirective: - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb' + - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' @@ -103,13 +108,12 @@ Lint/RedundantCopDisableDirective: - 'ee/app/models/dast/branch.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/geo/event_log.rb' + - 'ee/app/models/protected_environments/approval_rules/summarizable.rb' - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb' - 'ee/app/services/ee/boards/issues/list_service.rb' - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/services/ee/search_service.rb' - - 'ee/app/services/ee/users/migrate_to_ghost_user_service.rb' - - 'ee/app/services/geo/repository_base_sync_service.rb' - 'ee/app/workers/ee/issuable_export_csv_worker.rb' - 'ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb' - 'ee/app/workers/geo/design_repository_shard_sync_worker.rb' @@ -120,6 +124,7 @@ Lint/RedundantCopDisableDirective: - 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb' - 'ee/lib/analytics/merge_request_metrics_calculator.rb' - 'ee/lib/api/audit_events.rb' + - 'ee/lib/api/dora/metrics.rb' - 'ee/lib/api/scim.rb' - 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' @@ -131,12 +136,15 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/gitlab/elastic/bool_expr.rb' - 'ee/lib/gitlab/spdx/license.rb' - 'ee/lib/gitlab/status_page/storage/object.rb' + - 'ee/spec/contracts/provider/pact_helpers/project/merge_request/show/suggested_reviewers_helper.rb' + - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/groups/settings/domain_verification_spec.rb' - 'ee/spec/helpers/ee/releases_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb' - 'ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' @@ -181,13 +189,14 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/database/migrations/observation.rb' - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb' - 'lib/gitlab/diff/file.rb' - - 'lib/gitlab/diff/file_collection/merge_request_diff_batch.rb' + - 'lib/gitlab/diff/file_collection/paginated_diffs.rb' - 'lib/gitlab/diff/pair_selector.rb' - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/encrypted_ldap_command.rb' - 'lib/gitlab/encrypted_smtp_command.rb' - 'lib/gitlab/git/commit.rb' - 'lib/gitlab/git/patches/collection.rb' + - 'lib/gitlab/github_import/markdown_text.rb' - 'lib/gitlab/github_import/user_finder.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' @@ -211,8 +220,9 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/utils/usage_data.rb' - 'lib/gitlab/x509/signature.rb' - 'lib/tasks/gitlab/cleanup.rake' - - 'qa/tasks/ci.rake' - - 'scripts/lib/glfm/render_static_html.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb' - 'scripts/security-harness' - 'sidekiq_cluster/cli.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' @@ -225,7 +235,6 @@ Lint/RedundantCopDisableDirective: - 'spec/graphql/mutations/commits/create_spec.rb' - 'spec/graphql/resolvers/base_resolver_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - - 'spec/initializers/memory_watchdog_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb' @@ -241,6 +250,7 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/git/tree_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb' + - 'spec/lib/gitlab/memory/watchdog/configurator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' - 'spec/lib/gitlab/rack_attack/request_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' @@ -252,6 +262,7 @@ Lint/RedundantCopDisableDirective: - 'spec/migrations/reschedule_backfill_imported_issue_search_data_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/concerns/encrypted_user_password_spec.rb' - 'spec/models/namespace/package_setting_spec.rb' - 'spec/models/namespace_spec.rb' - 'spec/models/project_feature_spec.rb' @@ -263,6 +274,7 @@ Lint/RedundantCopDisableDirective: - 'spec/requests/api/graphql/ci/config_spec.rb' - 'spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb' - 'spec/services/alert_management/metric_images/upload_service_spec.rb' + - 'spec/services/boards/lists/list_service_spec.rb' - 'spec/services/projects/update_statistics_service_spec.rb' - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/services/topics/merge_service_spec.rb' |