diff options
Diffstat (limited to '.rubocop_todo/rspec')
| -rw-r--r-- | .rubocop_todo/rspec/before_all_role_assignment.yml | 5 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/context_wording.yml | 20 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/expect_change.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/expect_in_hook.yml | 5 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/factory_bot/avoid_create.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/factory_bot/excessive_create_list.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/feature_category.yml (renamed from .rubocop_todo/rspec/missing_feature_category.yml) | 27 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/file_path.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/instance_variable.yml | 4 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/return_from_stub.yml | 4 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/scattered_let.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/useless_dynamic_definition.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/rspec/verified_doubles.yml | 1 |
13 files changed, 5 insertions, 68 deletions
diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index cc0781a337e..0905a79beca 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -26,7 +26,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/controllers/groups/issues_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/merge_requests_controller_spec.rb' - 'ee/spec/controllers/groups/push_rules_controller_spec.rb' - - 'ee/spec/controllers/groups/runners_controller_spec.rb' - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' - 'ee/spec/controllers/groups/todos_controller_spec.rb' @@ -775,7 +774,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/controllers/groups/group_members_controller_spec.rb' - 'spec/controllers/groups/imports_controller_spec.rb' - 'spec/controllers/groups/labels_controller_spec.rb' - - 'spec/controllers/groups/runners_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/groups/settings/integrations_controller_spec.rb' @@ -817,7 +815,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - 'spec/controllers/projects/repositories_controller_spec.rb' - 'spec/controllers/projects/runner_projects_controller_spec.rb' - - 'spec/controllers/projects/runners_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/integrations_controller_spec.rb' - 'spec/controllers/projects/settings/slacks_controller_spec.rb' @@ -1160,7 +1157,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/lib/gitlab/search_results_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/issue_move_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/models/ci/bridge_spec.rb' - 'spec/models/ci/catalog/listing_spec.rb' - 'spec/models/ci/pipeline_spec.rb' @@ -1539,7 +1535,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/services/snippets/create_service_spec.rb' - 'spec/services/snippets/destroy_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - 'spec/services/uploads/destroy_service_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 9f6b07c397e..f95f6424593 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -14,7 +14,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - - 'ee/spec/controllers/ee/registrations_controller_spec.rb' - 'ee/spec/controllers/ee/root_controller_spec.rb' - 'ee/spec/controllers/ee/search_controller_spec.rb' - 'ee/spec/controllers/ee/sent_notifications_controller_spec.rb' @@ -161,7 +160,6 @@ RSpec/ContextWording: - 'ee/spec/features/projects/settings/push_rules_settings_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/features/users/signup_spec.rb' - 'ee/spec/finders/approval_rules/group_finder_spec.rb' @@ -996,7 +994,6 @@ RSpec/ContextWording: - 'spec/controllers/metrics_controller_spec.rb' - 'spec/controllers/oauth/applications_controller_spec.rb' - 'spec/controllers/oauth/authorizations_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/emails_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' @@ -1053,7 +1050,6 @@ RSpec/ContextWording: - 'spec/controllers/projects/tree_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/registrations_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - 'spec/controllers/search_controller_spec.rb' @@ -1782,13 +1778,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' - 'spec/lib/gitlab/email/handler_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - 'spec/lib/gitlab/email/reply_parser_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' @@ -1858,7 +1847,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/hook_data/subgroup_builder_spec.rb' - 'spec/lib/gitlab/hook_data/user_builder_spec.rb' - 'spec/lib/gitlab/hotlinking_detector_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' @@ -1898,6 +1886,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' + - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/lfs_token_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' @@ -2181,7 +2170,6 @@ RSpec/ContextWording: - 'spec/models/import_export_upload_spec.rb' - 'spec/models/import_failure_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' - 'spec/models/integrations/chat_message/merge_message_spec.rb' @@ -2271,7 +2259,6 @@ RSpec/ContextWording: - 'spec/models/uploads/local_spec.rb' - 'spec/models/user_preference_spec.rb' - 'spec/models/user_spec.rb' - - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/models/wiki_page/meta_spec.rb' - 'spec/models/wiki_page/slug_spec.rb' - 'spec/models/wiki_page_spec.rb' @@ -2768,7 +2755,6 @@ RSpec/ContextWording: - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/personal_access_tokens/revoke_service_spec.rb' @@ -2791,8 +2777,6 @@ RSpec/ContextWording: - 'spec/services/projects/group_links/update_service_spec.rb' - 'spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_service_spec.rb' - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' @@ -2833,7 +2817,6 @@ RSpec/ContextWording: - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/issuables_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' - - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/terraform/remote_state_handler_spec.rb' - 'spec/services/terraform/states/destroy_service_spec.rb' - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' @@ -3072,7 +3055,6 @@ RSpec/ContextWording: - 'spec/tasks/gitlab/gitaly_rake_spec.rb' - 'spec/tasks/gitlab/lfs/migrate_rake_spec.rb' - 'spec/tasks/gitlab/packages/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/storage_rake_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 02d1427c384..f625c948e79 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -408,7 +408,6 @@ RSpec/ExpectChange: - 'spec/services/snippets/update_statistics_service_spec.rb' - 'spec/services/spam/spam_action_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/services/todos/destroy/destroyed_issuable_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 86f2a5abd41..58ddd11c934 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -12,7 +12,6 @@ RSpec/ExpectInHook: - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/signup_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' @@ -100,7 +99,6 @@ RSpec/ExpectInHook: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' @@ -232,7 +230,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/health_checks/probes/collection_spec.rb' - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' - 'spec/lib/gitlab/health_checks/server_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' @@ -250,6 +247,7 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' + - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' @@ -409,7 +407,6 @@ RSpec/ExpectInHook: - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/update_package_file_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/projects/after_rename_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 2725b035d65..79e7b6027e1 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -151,7 +151,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/serializers/epic_note_entity_spec.rb' - 'ee/spec/serializers/epics/related_epic_entity_spec.rb' - 'ee/spec/serializers/fork_namespace_entity_spec.rb' - - 'ee/spec/serializers/geo_project_registry_entity_spec.rb' - 'ee/spec/serializers/incident_management/escalation_policy_entity_spec.rb' - 'ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb' - 'ee/spec/serializers/integrations/field_entity_spec.rb' @@ -360,7 +359,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/mailers/devise_mailer_spec.rb' - 'spec/mailers/emails/auto_devops_spec.rb' - 'spec/mailers/emails/groups_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/mailers/emails/issues_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/mailers/emails/pages_domains_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml index 009e60b5129..386c7317f3c 100644 --- a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml +++ b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml @@ -36,7 +36,6 @@ RSpec/FactoryBot/ExcessiveCreateList: - 'spec/services/database/consistency_check_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/notification_service_spec.rb' - - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/support/shared_examples/services/notification_service_shared_examples.rb' - 'spec/workers/ssh_keys/expired_notification_worker_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index 4cc8ee1210c..a8db7b1fa09 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -1,5 +1,5 @@ --- -RSpec/MissingFeatureCategory: +RSpec/FeatureCategory: Exclude: - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' @@ -971,7 +971,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/mailers/ee/emails/projects_spec.rb' - 'ee/spec/mailers/emails/epics_spec.rb' - 'ee/spec/mailers/emails/group_memberships_spec.rb' - - 'ee/spec/mailers/emails/in_product_marketing_spec.rb' - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/mailers/emails/user_cap_spec.rb' @@ -1732,7 +1731,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' - 'spec/controllers/projects/protected_branches_controller_spec.rb' - 'spec/controllers/projects/protected_tags_controller_spec.rb' - - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - 'spec/controllers/projects/registry/tags_controller_spec.rb' - 'spec/controllers/projects/releases/evidences_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' @@ -1991,7 +1989,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/mutations/concerns/mutations/resolves_group_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb' - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb' - - 'spec/graphql/mutations/container_repositories/destroy_spec.rb' - 'spec/graphql/mutations/container_repositories/destroy_tags_spec.rb' - 'spec/graphql/mutations/custom_emoji/create_spec.rb' - 'spec/graphql/mutations/custom_emoji/destroy_spec.rb' @@ -2472,8 +2469,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/breadcrumbs_helper_spec.rb' - 'spec/helpers/button_helper_spec.rb' - 'spec/helpers/calendar_helper_spec.rb' - - 'spec/helpers/ci/builds_helper_spec.rb' - - 'spec/helpers/ci/jobs_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - 'spec/helpers/ci/pipelines_helper_spec.rb' - 'spec/helpers/ci/secure_files_helper_spec.rb' @@ -2765,7 +2760,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/projects/pipelines/external_pull_requests_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/merge_requests_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/pipeline_schedules_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_attributes_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' @@ -3150,7 +3144,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/null_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/or_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/pattern_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/string_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/variable_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexer_spec.rb' @@ -3498,17 +3491,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/email/hook/delivery_metrics_observer_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/create_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - 'spec/lib/gitlab/email/receiver_spec.rb' - 'spec/lib/gitlab/email/service_desk_receiver_spec.rb' @@ -3539,7 +3521,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' - 'spec/lib/gitlab/exclusive_lease_spec.rb' - - 'spec/lib/gitlab/experiment/rollout/feature_spec.rb' - 'spec/lib/gitlab/external_authorization/access_spec.rb' - 'spec/lib/gitlab/external_authorization/cache_spec.rb' - 'spec/lib/gitlab/external_authorization/client_spec.rb' @@ -3762,7 +3743,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/hotlinking_detector_spec.rb' - 'spec/lib/gitlab/http_connection_adapter_spec.rb' - 'spec/lib/gitlab/http_io_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/i18n/metadata_entry_spec.rb' - 'spec/lib/gitlab/i18n/po_linter_spec.rb' - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' @@ -4116,7 +4096,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/route_map_spec.rb' - 'spec/lib/gitlab/routing_spec.rb' - 'spec/lib/gitlab/rugged_instrumentation_spec.rb' - - 'spec/lib/gitlab/saas_spec.rb' - 'spec/lib/gitlab/safe_request_loader_spec.rb' - 'spec/lib/gitlab/safe_request_purger_spec.rb' - 'spec/lib/gitlab/sample_data_template_spec.rb' @@ -4471,7 +4450,6 @@ RSpec/MissingFeatureCategory: - 'spec/mailers/emails/auto_devops_spec.rb' - 'spec/mailers/emails/groups_spec.rb' - 'spec/mailers/emails/identity_verification_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/mailers/emails/pages_domains_spec.rb' - 'spec/mailers/emails/pipelines_spec.rb' @@ -4753,7 +4731,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/instance_metadata_spec.rb' - 'spec/models/integrations/asana_spec.rb' - 'spec/models/integrations/assembla_spec.rb' - - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/base_issue_tracker_spec.rb' - 'spec/models/integrations/base_slack_notification_spec.rb' - 'spec/models/integrations/base_third_party_wiki_spec.rb' @@ -4830,7 +4807,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/loose_foreign_keys/modification_tracker_spec.rb' - 'spec/models/members/group_member_spec.rb' - 'spec/models/members/last_group_owner_assigner_spec.rb' - - 'spec/models/members/member_task_spec.rb' - 'spec/models/members/project_member_spec.rb' - 'spec/models/merge_request/approval_removal_settings_spec.rb' - 'spec/models/merge_request/diff_commit_user_spec.rb' @@ -4932,7 +4908,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/project_import_data_spec.rb' - 'spec/models/project_label_spec.rb' - 'spec/models/project_metrics_setting_spec.rb' - - 'spec/models/project_pages_metadatum_spec.rb' - 'spec/models/project_repository_spec.rb' - 'spec/models/project_snippet_spec.rb' - 'spec/models/project_statistics_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml index ea193948909..06832184c04 100644 --- a/.rubocop_todo/rspec/file_path.yml +++ b/.rubocop_todo/rspec/file_path.yml @@ -24,6 +24,7 @@ RSpec/FilePath: - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' + - 'spec/initializers/gitlab_http_spec.rb' - 'spec/lib/error_tracking/sentry_client/event_spec.rb' - 'spec/lib/gitlab/import_export/import_export_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index a5a0cec68d4..603d025fa2f 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -107,9 +107,9 @@ RSpec/InstanceVariable: - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' + - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/project_transfer_spec.rb' @@ -129,7 +129,6 @@ RSpec/InstanceVariable: - 'spec/models/postgresql/replication_slot_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/user_spec.rb' - - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/rack_servers/puma_spec.rb' - 'spec/requests/api/admin/plan_limits_spec.rb' - 'spec/requests/api/users_spec.rb' @@ -147,7 +146,6 @@ RSpec/InstanceVariable: - 'spec/services/notes/post_process_service_spec.rb' - 'spec/services/notes/update_service_spec.rb' - 'spec/services/notification_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/projects/create_from_template_service_spec.rb' - 'spec/services/projects/download_service_spec.rb' - 'spec/services/projects/fork_service_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 0f0a6f5a95a..1d07be7d6dc 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -137,8 +137,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/database_importers/instance_administrators/create_group_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' - 'spec/lib/gitlab/external_authorization_spec.rb' @@ -232,8 +230,6 @@ RSpec/ReturnFromStub: - 'spec/services/projects/create_service_spec.rb' - 'spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' - 'spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_attachments_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 479ff4fd8f9..4d93c6816cc 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -176,7 +176,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' - 'spec/lib/peek/views/external_http_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/mailers/previews_spec.rb' - 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb' diff --git a/.rubocop_todo/rspec/useless_dynamic_definition.yml b/.rubocop_todo/rspec/useless_dynamic_definition.yml index 94a53324dee..75bea5601ae 100644 --- a/.rubocop_todo/rspec/useless_dynamic_definition.yml +++ b/.rubocop_todo/rspec/useless_dynamic_definition.yml @@ -5,7 +5,6 @@ RSpec/UselessDynamicDefinition: - 'ee/spec/factories/ci/job_artifacts.rb' - 'ee/spec/factories/ci/pipelines.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb' - - 'ee/spec/support/shared_examples/lib/gitlab/elastic/search_results_shared_examples.rb' - 'spec/models/ci/resource_group_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/support/helpers/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 42d1363358b..6e3e3abf87e 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -897,7 +897,6 @@ RSpec/VerifiedDoubles: - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' |