diff options
Diffstat (limited to 'spec/features/issues/gfm_autocomplete_spec.rb')
| -rw-r--r-- | spec/features/issues/gfm_autocomplete_spec.rb | 778 |
1 files changed, 242 insertions, 536 deletions
diff --git a/spec/features/issues/gfm_autocomplete_spec.rb b/spec/features/issues/gfm_autocomplete_spec.rb index b0e4729db8b..b4d1b0aeab9 100644 --- a/spec/features/issues/gfm_autocomplete_spec.rb +++ b/spec/features/issues/gfm_autocomplete_spec.rb @@ -6,10 +6,8 @@ RSpec.describe 'GFM autocomplete', :js do let_it_be(:user) { create(:user, name: '💃speciąl someone💃', username: 'someone.special') } let_it_be(:user2) { create(:user, name: 'Marge Simpson', username: 'msimpson') } - let_it_be(:group) { create(:group, name: 'Ancestor') } - let_it_be(:child_group) { create(:group, parent: group, name: 'My group') } - let_it_be(:project) { create(:project, group: child_group) } - + let_it_be(:group) { create(:group, :crm_enabled) } + let_it_be(:project) { create(:project, group: group) } let_it_be(:issue) { create(:issue, project: project, assignees: [user]) } let_it_be(:label) { create(:label, project: project, title: 'special+') } let_it_be(:label_scoped) { create(:label, project: project, title: 'scoped::label') } @@ -22,675 +20,390 @@ RSpec.describe 'GFM autocomplete', :js do let_it_be(:label_xss) { create(:label, project: project, title: label_xss_title) } before_all do - project.add_maintainer(user) - project.add_maintainer(user_xss) - project.add_maintainer(user2) + group.add_maintainer(user) + group.add_maintainer(user_xss) + group.add_maintainer(user2) end - describe 'when tribute_autocomplete feature flag is off' do - describe 'new issue page' do - before do - stub_feature_flags(tribute_autocomplete: false) - - sign_in(user) - visit new_project_issue_path(project) + describe 'new issue page' do + before do + sign_in(user) + visit new_project_issue_path(project) - wait_for_requests - end + wait_for_requests + end - it 'allows quick actions' do - fill_in 'Description', with: '/' + it 'allows quick actions' do + fill_in 'Description', with: '/' - expect(find_autocomplete_menu).to be_visible - end + expect(find_autocomplete_menu).to be_visible end + end - describe 'issue description' do - let(:issue_to_edit) { create(:issue, project: project) } - - before do - stub_feature_flags(tribute_autocomplete: false) + describe 'issue description' do + let(:issue_to_edit) { create(:issue, project: project) } - sign_in(user) - visit project_issue_path(project, issue_to_edit) + before do + sign_in(user) + visit project_issue_path(project, issue_to_edit) - wait_for_requests - end + wait_for_requests + end - it 'updates with GFM reference' do - click_button 'Edit title and description' + it 'updates with GFM reference' do + click_button 'Edit title and description' - wait_for_requests + wait_for_requests - fill_in 'Description', with: "@#{user.name[0...3]}" + fill_in 'Description', with: "@#{user.name[0...3]}" - wait_for_requests + wait_for_requests - find_highlighted_autocomplete_item.click + find_highlighted_autocomplete_item.click - click_button 'Save changes' + click_button 'Save changes' - wait_for_requests + wait_for_requests - expect(find('.description')).to have_text(user.to_reference) - end + expect(find('.description')).to have_text(user.to_reference) + end - it 'allows quick actions' do - click_button 'Edit title and description' + it 'allows quick actions' do + click_button 'Edit title and description' - fill_in 'Description', with: '/' + fill_in 'Description', with: '/' - expect(find_autocomplete_menu).to be_visible - end + expect(find_autocomplete_menu).to be_visible end + end - describe 'issue comment' do - before do - stub_feature_flags(tribute_autocomplete: false) - - sign_in(user) - visit project_issue_path(project, issue) + describe 'issue comment' do + before do + sign_in(user) + visit project_issue_path(project, issue) - wait_for_requests - end + wait_for_requests + end - describe 'triggering autocomplete' do - it 'only opens autocomplete menu when trigger character is after whitespace', :aggregate_failures do - fill_in 'Comment', with: 'testing@' - expect(page).not_to have_css('.atwho-view') + describe 'triggering autocomplete' do + it 'only opens autocomplete menu when trigger character is after whitespace', :aggregate_failures do + fill_in 'Comment', with: 'testing@' + expect(page).not_to have_css('.atwho-view') - fill_in 'Comment', with: '@@' - expect(page).not_to have_css('.atwho-view') + fill_in 'Comment', with: '@@' + expect(page).not_to have_css('.atwho-view') - fill_in 'Comment', with: "@#{user.username[0..2]}!" - expect(page).not_to have_css('.atwho-view') + fill_in 'Comment', with: "@#{user.username[0..2]}!" + expect(page).not_to have_css('.atwho-view') - fill_in 'Comment', with: "hello:#{user.username[0..2]}" - expect(page).not_to have_css('.atwho-view') + fill_in 'Comment', with: "hello:#{user.username[0..2]}" + expect(page).not_to have_css('.atwho-view') - fill_in 'Comment', with: '7:' - expect(page).not_to have_css('.atwho-view') + fill_in 'Comment', with: '7:' + expect(page).not_to have_css('.atwho-view') - fill_in 'Comment', with: 'w:' - expect(page).not_to have_css('.atwho-view') + fill_in 'Comment', with: 'w:' + expect(page).not_to have_css('.atwho-view') - fill_in 'Comment', with: 'Ё:' - expect(page).not_to have_css('.atwho-view') + fill_in 'Comment', with: 'Ё:' + expect(page).not_to have_css('.atwho-view') - fill_in 'Comment', with: "test\n\n@" - expect(find_autocomplete_menu).to be_visible - end + fill_in 'Comment', with: "test\n\n@" + expect(find_autocomplete_menu).to be_visible end + end - context 'xss checks' do - it 'opens autocomplete menu for Issues when field starts with text with item escaping HTML characters' do - issue_xss_title = 'This will execute alert<img src=x onerror=alert(2)<img src=x onerror=alert(1)>' - create(:issue, project: project, title: issue_xss_title) - - fill_in 'Comment', with: '#' - - wait_for_requests - - expect(find_autocomplete_menu).to have_text(issue_xss_title) - end - - it 'opens autocomplete menu for Username when field starts with text with item escaping HTML characters' do - fill_in 'Comment', with: '@ev' - - wait_for_requests - - expect(find_highlighted_autocomplete_item).to have_text(user_xss.username) - end - - it 'opens autocomplete menu for Milestone when field starts with text with item escaping HTML characters' do - milestone_xss_title = 'alert milestone <img src=x onerror="alert(\'Hello xss\');" a' - create(:milestone, project: project, title: milestone_xss_title) - - fill_in 'Comment', with: '%' - - wait_for_requests - - expect(find_autocomplete_menu).to have_text('alert milestone') - end + context 'xss checks' do + it 'opens autocomplete menu for Issues when field starts with text with item escaping HTML characters' do + issue_xss_title = 'This will execute alert<img src=x onerror=alert(2)<img src=x onerror=alert(1)>' + create(:issue, project: project, title: issue_xss_title) - it 'opens autocomplete menu for Labels when field starts with text with item escaping HTML characters' do - fill_in 'Comment', with: '~' + fill_in 'Comment', with: '#' - wait_for_requests + wait_for_requests - expect(find_autocomplete_menu).to have_text('alert label') - end + expect(find_autocomplete_menu).to have_text(issue_xss_title) end - describe 'autocomplete highlighting' do - it 'auto-selects the first item when there is a query, and only for assignees with no query', :aggregate_failures do - fill_in 'Comment', with: ':' - wait_for_requests - expect(find_autocomplete_menu).not_to have_css('.cur') + it 'opens autocomplete menu for Username when field starts with text with item escaping HTML characters' do + fill_in 'Comment', with: '@ev' - fill_in 'Comment', with: ':1' - wait_for_requests - expect(find_autocomplete_menu).to have_css('.cur:first-of-type') + wait_for_requests - fill_in 'Comment', with: '@' - wait_for_requests - expect(find_autocomplete_menu).to have_css('.cur:first-of-type') - end + expect(find_highlighted_autocomplete_item).to have_text(user_xss.username) end - describe 'assignees' do - it 'does not wrap with quotes for assignee values' do - fill_in 'Comment', with: "@#{user.username}" - - find_highlighted_autocomplete_item.click - - expect(find_field('Comment').value).to have_text("@#{user.username}") - end - - it 'includes items for assignee dropdowns with non-ASCII characters in name' do - fill_in 'Comment', with: "@#{user.name[0...8]}" - - wait_for_requests - - expect(find_autocomplete_menu).to have_text(user.name) - end - - it 'searches across full name for assignees' do - fill_in 'Comment', with: '@speciąlsome' - - wait_for_requests - - expect(find_highlighted_autocomplete_item).to have_text(user.name) - end - - it 'shows names that start with the query as the top result' do - fill_in 'Comment', with: '@mar' - - wait_for_requests - - expect(find_highlighted_autocomplete_item).to have_text(user2.name) - end - - it 'shows usernames that start with the query as the top result' do - fill_in 'Comment', with: '@msi' - - wait_for_requests - - expect(find_highlighted_autocomplete_item).to have_text(user2.name) - end - - # Regression test for https://gitlab.com/gitlab-org/gitlab/-/issues/321925 - it 'shows username when pasting then pressing Enter' do - fill_in 'Comment', with: "@#{user.username}\n" - - expect(find_field('Comment').value).to have_text "@#{user.username}" - end - - it 'does not show `@undefined` when pressing `@` then Enter' do - fill_in 'Comment', with: "@\n" - - expect(find_field('Comment').value).to have_text '@' - expect(find_field('Comment').value).not_to have_text '@undefined' - end + it 'opens autocomplete menu for Milestone when field starts with text with item escaping HTML characters' do + milestone_xss_title = 'alert milestone <img src=x onerror="alert(\'Hello xss\');" a' + create(:milestone, project: project, title: milestone_xss_title) - context 'when /assign quick action is selected' do - it 'triggers user autocomplete and lists users who are currently not assigned to the issue' do - fill_in 'Comment', with: '/as' + fill_in 'Comment', with: '%' - find_highlighted_autocomplete_item.click + wait_for_requests - expect(find_autocomplete_menu).not_to have_text(user.username) - expect(find_autocomplete_menu).to have_text(user2.username) - end - end + expect(find_autocomplete_menu).to have_text('alert milestone') end - context 'if a selected value has special characters' do - it 'wraps the result in double quotes' do - fill_in 'Comment', with: "~#{label.title[0..2]}" - - find_highlighted_autocomplete_item.click - - expect(find_field('Comment').value).to have_text("~\"#{label.title}\"") - end - - it 'doesn\'t wrap for emoji values' do - fill_in 'Comment', with: ':cartwheel_' - - find_highlighted_autocomplete_item.click - - expect(find_field('Comment').value).to have_text('cartwheel_tone1') - end - end + it 'opens autocomplete menu for Labels when field starts with text with item escaping HTML characters' do + fill_in 'Comment', with: '~' - context 'quick actions' do - it 'does not limit quick actions autocomplete list to 5' do - fill_in 'Comment', with: '/' + wait_for_requests - expect(find_autocomplete_menu).to have_css('li', minimum: 6) - end + expect(find_autocomplete_menu).to have_text('alert label') end + end - context 'labels' do - it 'allows colons when autocompleting scoped labels' do - fill_in 'Comment', with: '~scoped:' - - wait_for_requests - - expect(find_autocomplete_menu).to have_text('scoped::label') - end - - it 'allows spaces when autocompleting multi-word labels' do - fill_in 'Comment', with: '~Accepting merge' - - wait_for_requests - - expect(find_autocomplete_menu).to have_text('Accepting merge requests') - end - - it 'only autocompletes the last label' do - fill_in 'Comment', with: '~scoped:: foo bar ~Accepting merge' + describe 'autocomplete highlighting' do + it 'auto-selects the first item when there is a query, and only for assignees with no query', :aggregate_failures do + fill_in 'Comment', with: ':' + wait_for_requests + expect(find_autocomplete_menu).not_to have_css('.cur') - wait_for_requests + fill_in 'Comment', with: ':1' + wait_for_requests + expect(find_autocomplete_menu).to have_css('.cur:first-of-type') - expect(find_autocomplete_menu).to have_text('Accepting merge requests') - end + fill_in 'Comment', with: '@' + wait_for_requests + expect(find_autocomplete_menu).to have_css('.cur:first-of-type') + end + end - it 'does not autocomplete labels if no tilde is typed' do - fill_in 'Comment', with: 'Accepting merge' + describe 'assignees' do + it 'does not wrap with quotes for assignee values' do + fill_in 'Comment', with: "@#{user.username}" - wait_for_requests + find_highlighted_autocomplete_item.click - expect(page).not_to have_css('.atwho-view') - end + expect(find_field('Comment').value).to have_text("@#{user.username}") end - context 'when other notes are destroyed' do - let!(:discussion) { create(:discussion_note_on_issue, noteable: issue, project: issue.project) } + it 'includes items for assignee dropdowns with non-ASCII characters in name' do + fill_in 'Comment', with: "@#{user.name[0...8]}" - # This is meant to protect against this issue https://gitlab.com/gitlab-org/gitlab/-/issues/228729 - it 'keeps autocomplete key listeners' do - note = find_field('Comment') + wait_for_requests - start_comment_with_emoji(note, '.atwho-view li') + expect(find_autocomplete_menu).to have_text(user.name) + end - start_and_cancel_discussion + it 'searches across full name for assignees' do + fill_in 'Comment', with: '@speciąlsome' - note.fill_in(with: '') - start_comment_with_emoji(note, '.atwho-view li') - note.native.send_keys(:enter) + wait_for_requests - expect(note.value).to eql('Hello :100: ') - end + expect(find_highlighted_autocomplete_item).to have_text(user.name) end - shared_examples 'autocomplete suggestions' do - it 'suggests objects correctly' do - fill_in 'Comment', with: object.class.reference_prefix + it 'shows names that start with the query as the top result' do + fill_in 'Comment', with: '@mar' - find_autocomplete_menu.find('li').click + wait_for_requests - expect(find_field('Comment').value).to have_text(expected_body) - end + expect(find_highlighted_autocomplete_item).to have_text(user2.name) end - context 'issues' do - let(:object) { issue } - let(:expected_body) { object.to_reference } + it 'shows usernames that start with the query as the top result' do + fill_in 'Comment', with: '@msi' - it_behaves_like 'autocomplete suggestions' - end - - context 'merge requests' do - let(:object) { create(:merge_request, source_project: project) } - let(:expected_body) { object.to_reference } + wait_for_requests - it_behaves_like 'autocomplete suggestions' + expect(find_highlighted_autocomplete_item).to have_text(user2.name) end - context 'project snippets' do - let!(:object) { snippet } - let(:expected_body) { object.to_reference } + # Regression test for https://gitlab.com/gitlab-org/gitlab/-/issues/321925 + it 'shows username when pasting then pressing Enter' do + fill_in 'Comment', with: "@#{user.username}\n" - it_behaves_like 'autocomplete suggestions' + expect(find_field('Comment').value).to have_text "@#{user.username}" end - context 'milestone' do - let_it_be(:milestone_expired) { create(:milestone, project: project, due_date: 5.days.ago) } - let_it_be(:milestone_no_duedate) { create(:milestone, project: project, title: 'Foo - No due date') } - let_it_be(:milestone1) { create(:milestone, project: project, title: 'Milestone-1', due_date: 20.days.from_now) } - let_it_be(:milestone2) { create(:milestone, project: project, title: 'Milestone-2', due_date: 15.days.from_now) } - let_it_be(:milestone3) { create(:milestone, project: project, title: 'Milestone-3', due_date: 10.days.from_now) } - - before do - fill_in 'Comment', with: '/milestone %' + it 'does not show `@undefined` when pressing `@` then Enter' do + fill_in 'Comment', with: "@\n" - wait_for_requests - end + expect(find_field('Comment').value).to have_text '@' + expect(find_field('Comment').value).not_to have_text '@undefined' + end - it 'shows milestons list in the autocomplete menu' do - page.within(find_autocomplete_menu) do - expect(page).to have_selector('li', count: 5) - end - end + context 'when /assign quick action is selected' do + it 'triggers user autocomplete and lists users who are currently not assigned to the issue' do + fill_in 'Comment', with: '/as' - it 'shows expired milestone at the bottom of the list' do - page.within(find_autocomplete_menu) do - expect(page.find('li:last-child')).to have_content milestone_expired.title - end - end + find_highlighted_autocomplete_item.click - it 'shows milestone due earliest at the top of the list' do - page.within(find_autocomplete_menu) do - aggregate_failures do - expect(page.all('li')[0]).to have_content milestone3.title - expect(page.all('li')[1]).to have_content milestone2.title - expect(page.all('li')[2]).to have_content milestone1.title - expect(page.all('li')[3]).to have_content milestone_no_duedate.title - end - end + expect(find_autocomplete_menu).not_to have_text(user.username) + expect(find_autocomplete_menu).to have_text(user2.username) end end end - end - describe 'when tribute_autocomplete feature flag is on' do - describe 'issue description' do - let(:issue_to_edit) { create(:issue, project: project) } + context 'if a selected value has special characters' do + it 'wraps the result in double quotes' do + fill_in 'Comment', with: "~#{label.title[0..2]}" - before do - stub_feature_flags(tribute_autocomplete: true) - - sign_in(user) - visit project_issue_path(project, issue_to_edit) + find_highlighted_autocomplete_item.click - wait_for_requests + expect(find_field('Comment').value).to have_text("~\"#{label.title}\"") end - it 'updates with GFM reference' do - click_button 'Edit title and description' - - wait_for_requests - - fill_in 'Description', with: "@#{user.name[0...3]}" + it 'doesn\'t wrap for emoji values' do + fill_in 'Comment', with: ':cartwheel_' - wait_for_requests - - find_highlighted_tribute_autocomplete_menu.click - - click_button 'Save changes' - - wait_for_requests + find_highlighted_autocomplete_item.click - expect(find('.description')).to have_text(user.to_reference) + expect(find_field('Comment').value).to have_text('cartwheel_tone1') end end - describe 'issue comment' do - before do - stub_feature_flags(tribute_autocomplete: true) - - sign_in(user) - visit project_issue_path(project, issue) + context 'quick actions' do + it 'does not limit quick actions autocomplete list to 5' do + fill_in 'Comment', with: '/' - wait_for_requests + expect(find_autocomplete_menu).to have_css('li', minimum: 6) end + end - describe 'triggering autocomplete' do - it 'only opens autocomplete menu when trigger character is after whitespace', :aggregate_failures do - fill_in 'Comment', with: 'testing@' - expect(page).not_to have_css('.tribute-container') - - fill_in 'Comment', with: "hello:#{user.username[0..2]}" - expect(page).not_to have_css('.tribute-container') - - fill_in 'Comment', with: '7:' - expect(page).not_to have_css('.tribute-container') - - fill_in 'Comment', with: 'w:' - expect(page).not_to have_css('.tribute-container') + context 'labels' do + it 'allows colons when autocompleting scoped labels' do + fill_in 'Comment', with: '~scoped:' - fill_in 'Comment', with: 'Ё:' - expect(page).not_to have_css('.tribute-container') + wait_for_requests - fill_in 'Comment', with: "test\n\n@" - expect(find_tribute_autocomplete_menu).to be_visible - end + expect(find_autocomplete_menu).to have_text('scoped::label') end - context 'xss checks' do - it 'opens autocomplete menu for Issues when field starts with text with item escaping HTML characters' do - issue_xss_title = 'This will execute alert<img src=x onerror=alert(2)<img src=x onerror=alert(1)>' - create(:issue, project: project, title: issue_xss_title) - - fill_in 'Comment', with: '#' - - wait_for_requests - - expect(find_tribute_autocomplete_menu).to have_text(issue_xss_title) - end - - it 'opens autocomplete menu for Username when field starts with text with item escaping HTML characters' do - fill_in 'Comment', with: '@ev' - - wait_for_requests + it 'allows spaces when autocompleting multi-word labels' do + fill_in 'Comment', with: '~Accepting merge' - expect(find_tribute_autocomplete_menu).to have_text(user_xss.username) - end - - it 'opens autocomplete menu for Milestone when field starts with text with item escaping HTML characters' do - milestone_xss_title = 'alert milestone <img src=x onerror="alert(\'Hello xss\');" a' - create(:milestone, project: project, title: milestone_xss_title) - - fill_in 'Comment', with: '%' - - wait_for_requests - - expect(find_tribute_autocomplete_menu).to have_text('alert milestone') - end - - it 'opens autocomplete menu for Labels when field starts with text with item escaping HTML characters' do - fill_in 'Comment', with: '~' - - wait_for_requests - - expect(find_tribute_autocomplete_menu).to have_text('alert label') - end - end - - describe 'autocomplete highlighting' do - it 'auto-selects the first item with query', :aggregate_failures do - fill_in 'Comment', with: ':1' - wait_for_requests - expect(find_tribute_autocomplete_menu).to have_css('.highlight:first-of-type') + wait_for_requests - fill_in 'Comment', with: '@' - wait_for_requests - expect(find_tribute_autocomplete_menu).to have_css('.highlight:first-of-type') - end + expect(find_autocomplete_menu).to have_text('Accepting merge requests') end - describe 'assignees' do - it 'does not wrap with quotes for assignee values' do - fill_in 'Comment', with: "@#{user.username[0..2]}" + it 'only autocompletes the last label' do + fill_in 'Comment', with: '~scoped:: foo bar ~Accepting merge' - find_highlighted_tribute_autocomplete_menu.click - - expect(find_field('Comment').value).to have_text("@#{user.username}") - end - - it 'includes items for assignee dropdowns with non-ASCII characters in name' do - fill_in 'Comment', with: "@#{user.name[0...8]}" - - wait_for_requests - - expect(find_tribute_autocomplete_menu).to have_text(user.name) - end - - context 'when autocompleting for groups' do - it 'shows the group when searching for the name of the group' do - fill_in 'Comment', with: '@mygroup' + wait_for_requests - expect(find_tribute_autocomplete_menu).to have_text('My group') - end + expect(find_autocomplete_menu).to have_text('Accepting merge requests') + end - it 'does not show the group when searching for the name of the parent of the group' do - fill_in 'Comment', with: '@ancestor' + it 'does not autocomplete labels if no tilde is typed' do + fill_in 'Comment', with: 'Accepting merge' - expect(find_tribute_autocomplete_menu).not_to have_text('My group') - end - end - - context 'when /assign quick action is selected' do - it 'lists users who are currently not assigned to the issue' do - note = find_field('Comment') - note.native.send_keys('/assign ') - # The `/assign` ajax response might replace the one by `@` below causing a failed test - # so we need to wait for the `/assign` ajax request to finish first - wait_for_requests - note.native.send_keys('@') - wait_for_requests - - expect(find_tribute_autocomplete_menu).not_to have_text(user.username) - expect(find_tribute_autocomplete_menu).to have_text(user2.username) - end + wait_for_requests - it 'lists users who are currently not assigned to the issue when using /assign on the second line' do - note = find_field('Comment') - note.native.send_keys('/assign @user2') - note.native.send_keys(:enter) - note.native.send_keys('/assign ') - # The `/assign` ajax response might replace the one by `@` below causing a failed test - # so we need to wait for the `/assign` ajax request to finish first - wait_for_requests - note.native.send_keys('@') - wait_for_requests - - expect(find_tribute_autocomplete_menu).not_to have_text(user.username) - expect(find_tribute_autocomplete_menu).to have_text(user2.username) - end - end + expect(page).not_to have_css('.atwho-view') end + end - context 'if a selected value has special characters' do - it 'wraps the result in double quotes' do - fill_in 'Comment', with: "~#{label.title[0..2]}" + context 'when other notes are destroyed' do + let!(:discussion) { create(:discussion_note_on_issue, noteable: issue, project: issue.project) } - find_highlighted_tribute_autocomplete_menu.click + # This is meant to protect against this issue https://gitlab.com/gitlab-org/gitlab/-/issues/228729 + it 'keeps autocomplete key listeners' do + note = find_field('Comment') - expect(find_field('Comment').value).to have_text("~\"#{label.title}\"") - end + start_comment_with_emoji(note, '.atwho-view li') - it 'does not wrap for emoji values' do - fill_in 'Comment', with: ':cartwheel_' + start_and_cancel_discussion - find_highlighted_tribute_autocomplete_menu.click + note.fill_in(with: '') + start_comment_with_emoji(note, '.atwho-view li') + note.native.send_keys(:enter) - expect(find_field('Comment').value).to have_text('cartwheel_tone1') - end + expect(note.value).to eql('Hello :100: ') end + end - context 'quick actions' do - it 'autocompletes for quick actions' do - fill_in 'Comment', with: '/as' + shared_examples 'autocomplete suggestions' do + it 'suggests objects correctly' do + fill_in 'Comment', with: object.class.reference_prefix - find_highlighted_tribute_autocomplete_menu.click + find_autocomplete_menu.find('li').click - expect(find_field('Comment').value).to have_text('/assign') - end + expect(find_field('Comment').value).to have_text(expected_body) end + end - context 'labels' do - it 'allows colons when autocompleting scoped labels' do - fill_in 'Comment', with: '~scoped:' - - wait_for_requests - - expect(find_tribute_autocomplete_menu).to have_text('scoped::label') - end + context 'issues' do + let(:object) { issue } + let(:expected_body) { object.to_reference } - it 'autocompletes multi-word labels' do - fill_in 'Comment', with: '~Acceptingmerge' + it_behaves_like 'autocomplete suggestions' + end - wait_for_requests + context 'merge requests' do + let(:object) { create(:merge_request, source_project: project) } + let(:expected_body) { object.to_reference } - expect(find_tribute_autocomplete_menu).to have_text('Accepting merge requests') - end + it_behaves_like 'autocomplete suggestions' + end - it 'only autocompletes the last label' do - fill_in 'Comment', with: '~scoped:: foo bar ~Acceptingmerge' - # Invoke autocompletion - find_field('Comment').native.send_keys(:right) + context 'project snippets' do + let!(:object) { snippet } + let(:expected_body) { object.to_reference } - wait_for_requests + it_behaves_like 'autocomplete suggestions' + end - expect(find_tribute_autocomplete_menu).to have_text('Accepting merge requests') - end + context 'milestone' do + let_it_be(:milestone_expired) { create(:milestone, project: project, due_date: 5.days.ago) } + let_it_be(:milestone_no_duedate) { create(:milestone, project: project, title: 'Foo - No due date') } + let_it_be(:milestone1) { create(:milestone, project: project, title: 'Milestone-1', due_date: 20.days.from_now) } + let_it_be(:milestone2) { create(:milestone, project: project, title: 'Milestone-2', due_date: 15.days.from_now) } + let_it_be(:milestone3) { create(:milestone, project: project, title: 'Milestone-3', due_date: 10.days.from_now) } - it 'does not autocomplete labels if no tilde is typed' do - fill_in 'Comment', with: 'Accepting' + before do + fill_in 'Comment', with: '/milestone %' - wait_for_requests + wait_for_requests + end - expect(page).not_to have_css('.tribute-container') + it 'shows milestons list in the autocomplete menu' do + page.within(find_autocomplete_menu) do + expect(page).to have_selector('li', count: 5) end end - context 'when other notes are destroyed' do - let!(:discussion) { create(:discussion_note_on_issue, noteable: issue, project: issue.project) } - - # This is meant to protect against this issue https://gitlab.com/gitlab-org/gitlab/-/issues/228729 - it 'keeps autocomplete key listeners' do - note = find_field('Comment') - - start_comment_with_emoji(note, '.tribute-container li') - - start_and_cancel_discussion - - note.fill_in(with: '') - start_comment_with_emoji(note, '.tribute-container li') - note.native.send_keys(:enter) - - expect(note.value).to eql('Hello :100: ') + it 'shows expired milestone at the bottom of the list' do + page.within(find_autocomplete_menu) do + expect(page.find('li:last-child')).to have_content milestone_expired.title end end - shared_examples 'autocomplete suggestions' do - it 'suggests objects correctly' do - fill_in 'Comment', with: object.class.reference_prefix - - find_tribute_autocomplete_menu.find('li').click - - expect(find_field('Comment').value).to have_text(expected_body) + it 'shows milestone due earliest at the top of the list' do + page.within(find_autocomplete_menu) do + aggregate_failures do + expect(page.all('li')[0]).to have_content milestone3.title + expect(page.all('li')[1]).to have_content milestone2.title + expect(page.all('li')[2]).to have_content milestone1.title + expect(page.all('li')[3]).to have_content milestone_no_duedate.title + end end end + end - context 'issues' do - let(:object) { issue } - let(:expected_body) { object.to_reference } - - it_behaves_like 'autocomplete suggestions' - end + context 'contact' do + let_it_be(:contacts) { create_list(:contact, 2, group: group) } - context 'merge requests' do - let(:object) { create(:merge_request, source_project: project) } - let(:expected_body) { object.to_reference } + before do + fill_in 'Comment', with: '/add_contacts [contact:' - it_behaves_like 'autocomplete suggestions' + wait_for_requests end - context 'project snippets' do - let!(:object) { snippet } - let(:expected_body) { object.to_reference } - - it_behaves_like 'autocomplete suggestions' + it 'shows contacts list in the autocomplete menu' do + page.within(find_autocomplete_menu) do + expect(page).to have_selector('li', count: 2) + end end - context 'milestone' do - let!(:object) { create(:milestone, project: project) } - let(:expected_body) { object.to_reference } + it 'shows all contacts' do + page.within(find_autocomplete_menu) do + expected_data = contacts.map { |c| "#{c.first_name} #{c.last_name} #{c.email}"} - it_behaves_like 'autocomplete suggestions' + expect(page.all('li').map(&:text)).to match_array(expected_data) + end end end end @@ -707,9 +420,10 @@ RSpec.describe 'GFM autocomplete', :js do def start_and_cancel_discussion fill_in('Reply to comment', with: 'Whoops!') + click_button('Cancel') - page.accept_alert 'Are you sure you want to cancel creating this comment?' do - click_button('Cancel') + page.within('.modal') do + click_button('OK', match: :first) end wait_for_requests @@ -722,12 +436,4 @@ RSpec.describe 'GFM autocomplete', :js do def find_highlighted_autocomplete_item find('.atwho-view li.cur', visible: true) end - - def find_tribute_autocomplete_menu - find('.tribute-container ul', visible: true) - end - - def find_highlighted_tribute_autocomplete_menu - find('.tribute-container li.highlight', visible: true) - end end |