1 files changed, 35 insertions, 3 deletions
diff --git a/spec/lib/gitlab/database/async_indexes/index_creator_spec.rb b/spec/lib/gitlab/database/async_indexes/index_creator_spec.rb
index 207aedd1a38..f980e458f14 100644
--- a/spec/lib/gitlab/database/async_indexes/index_creator_spec.rb
+++ b/spec/lib/gitlab/database/async_indexes/index_creator_spec.rb
@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe Gitlab::Database::AsyncIndexes::IndexCreator do
+RSpec.describe Gitlab::Database::AsyncIndexes::IndexCreator, feature_category: :database do
   include ExclusiveLeaseHelpers
 
   describe '#perform' do
@@ -35,6 +35,24 @@ RSpec.describe Gitlab::Database::AsyncIndexes::IndexCreator do
 
         subject.perform
       end
+
+      it 'removes the index preparation record from postgres_async_indexes' do
+        expect(async_index).to receive(:destroy!).and_call_original
+
+        expect { subject.perform }.to change { index_model.count }.by(-1)
+      end
+
+      it 'logs an appropriate message' do
+        expected_message = 'Skipping index creation since preconditions are not met. The queuing entry will be deleted'
+
+        allow(Gitlab::AppLogger).to receive(:info).and_call_original
+
+        subject.perform
+
+        expect(Gitlab::AppLogger)
+          .to have_received(:info)
+          .with(a_hash_including(message: expected_message))
+      end
     end
 
     it 'creates the index while controlling statement timeout' do
@@ -47,7 +65,7 @@ RSpec.describe Gitlab::Database::AsyncIndexes::IndexCreator do
     end
 
     it 'removes the index preparation record from postgres_async_indexes' do
-      expect(async_index).to receive(:destroy).and_call_original
+      expect(async_index).to receive(:destroy!).and_call_original
 
       expect { subject.perform }.to change { index_model.count }.by(-1)
     end
@@ -55,9 +73,23 @@ RSpec.describe Gitlab::Database::AsyncIndexes::IndexCreator do
     it 'skips logic if not able to acquire exclusive lease' do
       expect(lease).to receive(:try_obtain).ordered.and_return(false)
       expect(connection).not_to receive(:execute).with(/CREATE INDEX/)
-      expect(async_index).not_to receive(:destroy)
+      expect(async_index).not_to receive(:destroy!)
 
       expect { subject.perform }.not_to change { index_model.count }
     end
+
+    it 'logs messages around execution' do
+      allow(Gitlab::AppLogger).to receive(:info).and_call_original
+
+      subject.perform
+
+      expect(Gitlab::AppLogger)
+        .to have_received(:info)
+        .with(a_hash_including(message: 'Starting async index creation'))
+
+      expect(Gitlab::AppLogger)
+        .to have_received(:info)
+        .with(a_hash_including(message: 'Finished async index creation'))
+    end
   end
 end