diff options
Diffstat (limited to 'spec/requests/api/rpm_project_packages_spec.rb')
| -rw-r--r-- | spec/requests/api/rpm_project_packages_spec.rb | 70 |
1 files changed, 39 insertions, 31 deletions
diff --git a/spec/requests/api/rpm_project_packages_spec.rb b/spec/requests/api/rpm_project_packages_spec.rb index 6a646c26fd2..68511795c94 100644 --- a/spec/requests/api/rpm_project_packages_spec.rb +++ b/spec/requests/api/rpm_project_packages_spec.rb @@ -9,7 +9,8 @@ RSpec.describe API::RpmProjectPackages do using RSpec::Parameterized::TableSyntax - let_it_be_with_reload(:project) { create(:project, :public) } + let_it_be(:group) { create(:group, :public) } + let_it_be_with_reload(:project) { create(:project, :public, group: group) } let_it_be(:user) { create(:user) } let_it_be(:personal_access_token) { create(:personal_access_token, user: user) } let_it_be(:deploy_token) { create(:deploy_token, read_package_registry: true, write_package_registry: true) } @@ -36,7 +37,7 @@ RSpec.describe API::RpmProjectPackages do it_behaves_like 'returning response status', status end - shared_examples 'a deploy token for RPM requests' do + shared_examples 'a deploy token for RPM requests' do |success_status = :not_found| context 'with deploy token headers' do before do project.update_column(:visibility_level, Gitlab::VisibilityLevel::PRIVATE) @@ -45,7 +46,7 @@ RSpec.describe API::RpmProjectPackages do let(:headers) { basic_auth_header(deploy_token.username, deploy_token.token) } context 'when token is valid' do - it_behaves_like 'returning response status', :not_found + it_behaves_like 'returning response status', success_status end context 'when token is invalid' do @@ -56,7 +57,7 @@ RSpec.describe API::RpmProjectPackages do end end - shared_examples 'a job token for RPM requests' do + shared_examples 'a job token for RPM requests' do |success_status = :not_found| context 'with job token headers' do let(:headers) { basic_auth_header(::Gitlab::Auth::CI_JOB_USER, job.token) } @@ -66,7 +67,7 @@ RSpec.describe API::RpmProjectPackages do end context 'with valid token' do - it_behaves_like 'returning response status', :not_found + it_behaves_like 'returning response status', success_status end context 'with invalid token' do @@ -83,10 +84,10 @@ RSpec.describe API::RpmProjectPackages do end end - shared_examples 'a user token for RPM requests' do + shared_examples 'a user token for RPM requests' do |success_status = :not_found| context 'with valid project' do where(:visibility_level, :user_role, :member, :user_token, :shared_examples_name, :expected_status) do - 'PUBLIC' | :developer | true | true | 'process rpm packages upload/download' | :not_found + 'PUBLIC' | :developer | true | true | 'process rpm packages upload/download' | success_status 'PUBLIC' | :guest | true | true | 'process rpm packages upload/download' | :forbidden 'PUBLIC' | :developer | true | false | 'rejects rpm packages access' | :unauthorized 'PUBLIC' | :guest | true | false | 'rejects rpm packages access' | :unauthorized @@ -95,7 +96,7 @@ RSpec.describe API::RpmProjectPackages do 'PUBLIC' | :developer | false | false | 'rejects rpm packages access' | :unauthorized 'PUBLIC' | :guest | false | false | 'rejects rpm packages access' | :unauthorized 'PUBLIC' | :anonymous | false | true | 'process rpm packages upload/download' | :unauthorized - 'PRIVATE' | :developer | true | true | 'process rpm packages upload/download' | :not_found + 'PRIVATE' | :developer | true | true | 'process rpm packages upload/download' | success_status 'PRIVATE' | :guest | true | true | 'rejects rpm packages access' | :forbidden 'PRIVATE' | :developer | true | false | 'rejects rpm packages access' | :unauthorized 'PRIVATE' | :guest | true | false | 'rejects rpm packages access' | :unauthorized @@ -123,26 +124,31 @@ RSpec.describe API::RpmProjectPackages do end describe 'GET /api/v4/projects/:project_id/packages/rpm/repodata/:filename' do - let(:url) { "/projects/#{project.id}/packages/rpm/repodata/#{package_name}" } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } + let(:repository_file) { create(:rpm_repository_file, project: project) } + let(:url) { "/projects/#{project.id}/packages/rpm/repodata/#{repository_file.file_name}" } subject { get api(url), headers: headers } - it_behaves_like 'a job token for RPM requests' - it_behaves_like 'a deploy token for RPM requests' - it_behaves_like 'a user token for RPM requests' + it_behaves_like 'a job token for RPM requests', :success + it_behaves_like 'a deploy token for RPM requests', :success + it_behaves_like 'a user token for RPM requests', :success end describe 'GET /api/v4/projects/:id/packages/rpm/:package_file_id/:filename' do + let(:snowplow_gitlab_standard_context) { { project: project, namespace: group } } let(:url) { "/projects/#{project.id}/packages/rpm/#{package_file_id}/#{package_name}" } subject { get api(url), headers: headers } + it_behaves_like 'a package tracking event', described_class.name, 'pull_package' it_behaves_like 'a job token for RPM requests' it_behaves_like 'a deploy token for RPM requests' it_behaves_like 'a user token for RPM requests' end describe 'POST /api/v4/projects/:project_id/packages/rpm' do + let(:snowplow_gitlab_standard_context) { { project: project, namespace: group, user: user } } let(:url) { "/projects/#{project.id}/packages/rpm" } let(:file_upload) { fixture_file_upload('spec/fixtures/packages/rpm/hello-0.0.1-1.fc29.x86_64.rpm') } @@ -150,25 +156,25 @@ RSpec.describe API::RpmProjectPackages do context 'with user token' do context 'with valid project' do - where(:visibility_level, :user_role, :member, :user_token, :shared_examples_name, :expected_status) do - 'PUBLIC' | :developer | true | true | 'process rpm packages upload/download' | :not_found - 'PUBLIC' | :guest | true | true | 'rejects rpm packages access' | :forbidden - 'PUBLIC' | :developer | true | false | 'rejects rpm packages access' | :unauthorized - 'PUBLIC' | :guest | true | false | 'rejects rpm packages access' | :unauthorized - 'PUBLIC' | :developer | false | true | 'rejects rpm packages access' | :not_found - 'PUBLIC' | :guest | false | true | 'rejects rpm packages access' | :not_found - 'PUBLIC' | :developer | false | false | 'rejects rpm packages access' | :unauthorized - 'PUBLIC' | :guest | false | false | 'rejects rpm packages access' | :unauthorized - 'PUBLIC' | :anonymous | false | true | 'rejects rpm packages access' | :unauthorized - 'PRIVATE' | :developer | true | true | 'process rpm packages upload/download' | :not_found - 'PRIVATE' | :guest | true | true | 'rejects rpm packages access' | :forbidden - 'PRIVATE' | :developer | true | false | 'rejects rpm packages access' | :unauthorized - 'PRIVATE' | :guest | true | false | 'rejects rpm packages access' | :unauthorized - 'PRIVATE' | :developer | false | true | 'rejects rpm packages access' | :not_found - 'PRIVATE' | :guest | false | true | 'rejects rpm packages access' | :not_found - 'PRIVATE' | :developer | false | false | 'rejects rpm packages access' | :unauthorized - 'PRIVATE' | :guest | false | false | 'rejects rpm packages access' | :unauthorized - 'PRIVATE' | :anonymous | false | true | 'rejects rpm packages access' | :unauthorized + where(:visibility_level, :user_role, :member, :user_token, :shared_examples_name, :expected_status, :tracked) do + 'PUBLIC' | :developer | true | true | 'process rpm packages upload/download' | :not_found | true + 'PUBLIC' | :guest | true | true | 'rejects rpm packages access' | :forbidden | false + 'PUBLIC' | :developer | true | false | 'rejects rpm packages access' | :unauthorized | false + 'PUBLIC' | :guest | true | false | 'rejects rpm packages access' | :unauthorized | false + 'PUBLIC' | :developer | false | true | 'rejects rpm packages access' | :not_found | false + 'PUBLIC' | :guest | false | true | 'rejects rpm packages access' | :not_found | false + 'PUBLIC' | :developer | false | false | 'rejects rpm packages access' | :unauthorized | false + 'PUBLIC' | :guest | false | false | 'rejects rpm packages access' | :unauthorized | false + 'PUBLIC' | :anonymous | false | true | 'rejects rpm packages access' | :unauthorized | false + 'PRIVATE' | :developer | true | true | 'process rpm packages upload/download' | :not_found | true + 'PRIVATE' | :guest | true | true | 'rejects rpm packages access' | :forbidden | false + 'PRIVATE' | :developer | true | false | 'rejects rpm packages access' | :unauthorized | false + 'PRIVATE' | :guest | true | false | 'rejects rpm packages access' | :unauthorized | false + 'PRIVATE' | :developer | false | true | 'rejects rpm packages access' | :not_found | false + 'PRIVATE' | :guest | false | true | 'rejects rpm packages access' | :not_found | false + 'PRIVATE' | :developer | false | false | 'rejects rpm packages access' | :unauthorized | false + 'PRIVATE' | :guest | false | false | 'rejects rpm packages access' | :unauthorized | false + 'PRIVATE' | :anonymous | false | true | 'rejects rpm packages access' | :unauthorized | false end with_them do @@ -180,6 +186,8 @@ RSpec.describe API::RpmProjectPackages do project.send("add_#{user_role}", user) if member && user_role != :anonymous end + tracking_example = params[:tracked] ? 'a package tracking event' : 'not a package tracking event' + it_behaves_like tracking_example, described_class.name, 'push_package' it_behaves_like params[:shared_examples_name], params[:expected_status] end end |