diff options
Diffstat (limited to 'spec/requests/search_controller_spec.rb')
| -rw-r--r-- | spec/requests/search_controller_spec.rb | 94 |
1 files changed, 83 insertions, 11 deletions
diff --git a/spec/requests/search_controller_spec.rb b/spec/requests/search_controller_spec.rb index 613732c19ea..98dda75a2b0 100644 --- a/spec/requests/search_controller_spec.rb +++ b/spec/requests/search_controller_spec.rb @@ -2,10 +2,11 @@ require 'spec_helper' -RSpec.describe SearchController, type: :request do +RSpec.describe SearchController, type: :request, feature_category: :global_search do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } let_it_be(:project) { create(:project, :public, :repository, :wiki_repo, name: 'awesome project', group: group) } + let_it_be(:projects) { create_list(:project, 5, :public, :repository, :wiki_repo) } before do login_as(user) @@ -20,9 +21,16 @@ RSpec.describe SearchController, type: :request do create(object, *creation_traits, creation_args) control = ActiveRecord::QueryRecorder.new(skip_cached: false) { send_search_request(params) } - create_list(object, 3, *creation_traits, creation_args) + expect(response.body).to include('search-results') # Confirm there are search results to prevent false positives + + projects.each do |project| + creation_args[:source_project] = project if creation_args.key?(:source_project) + creation_args[:project] = project if creation_args.key?(:project) + create(object, *creation_traits, creation_args) + end expect { send_search_request(params) }.not_to exceed_all_query_limit(control).with_threshold(threshold) + expect(response.body).to include('search-results') # Confirm there are search results to prevent false positives end end @@ -33,26 +41,26 @@ RSpec.describe SearchController, type: :request do let(:object) { :issue } let(:creation_args) { { project: project, title: 'foo' } } let(:params) { { search: 'foo', scope: 'issues' } } - # there are 4 additional queries run for the logged in user: - # (1) geo_nodes, (1) users, (2) broadcast_messages - let(:threshold) { 4 } + # some N+1 queries still exist + # each issue runs an extra query for group namespaces + let(:threshold) { 1 } it_behaves_like 'an efficient database result' end - context 'for merge_request scope' do + context 'for merge_requests scope' do let(:creation_traits) { [:unique_branches] } let(:object) { :merge_request } let(:creation_args) { { source_project: project, title: 'bar' } } let(:params) { { search: 'bar', scope: 'merge_requests' } } - # there are 4 additional queries run for the logged in user: - # - (1) geo_nodes, (1) users, (2) broadcast_messages + # some N+1 queries still exist + # each merge request runs an extra query for project routes let(:threshold) { 4 } it_behaves_like 'an efficient database result' end - context 'for project scope' do + context 'for projects scope' do let(:creation_traits) { [:public] } let(:object) { :project } let(:creation_args) { { name: 'project' } } @@ -63,12 +71,76 @@ RSpec.describe SearchController, type: :request do # - one count for open MRs # - one count for open Issues # there are 4 additional queries run for the logged in user: - # (1) geo_nodes, (1) users, (2) broadcast_messages - let(:threshold) { 13 } + # (1) user preferences, (1) user statuses, (1) user details, (1) users + let(:threshold) { 17 } it_behaves_like 'an efficient database result' end + context 'for milestones scope' do + let(:object) { :milestone } + let(:creation_args) { { project: project } } + let(:params) { { search: 'title', scope: 'milestones' } } + let(:threshold) { 0 } + + it_behaves_like 'an efficient database result' + end + + context 'for users scope' do + let(:object) { :user } + let(:creation_args) { { name: 'georgia' } } + let(:params) { { search: 'georgia', scope: 'users' } } + let(:threshold) { 0 } + + it_behaves_like 'an efficient database result' + end + + context 'for notes scope' do + let(:creation_traits) { [:on_commit] } + let(:object) { :note } + let(:creation_args) { { project: project, note: 'hello world' } } + let(:params) { { search: 'hello world', scope: 'notes', project_id: project.id } } + let(:threshold) { 0 } + + it_behaves_like 'an efficient database result' + end + + context 'for blobs scope' do + # blobs are enabled for project search only in basic search + let(:params_for_one) { { search: 'test', project_id: project.id, scope: 'blobs', per_page: 1 } } + let(:params_for_many) { { search: 'test', project_id: project.id, scope: 'blobs', per_page: 5 } } + + it 'avoids N+1 database queries' do + control = ActiveRecord::QueryRecorder.new { send_search_request(params_for_one) } + expect(response.body).to include('search-results') # Confirm search results to prevent false positives + + expect { send_search_request(params_for_many) }.not_to exceed_query_limit(control.count) + expect(response.body).to include('search-results') # Confirm search results to prevent false positives + end + end + + context 'for commits scope' do + let(:params_for_one) { { search: 'test', project_id: project.id, scope: 'commits', per_page: 1 } } + let(:params_for_many) { { search: 'test', project_id: project.id, scope: 'commits', per_page: 5 } } + + it 'avoids N+1 database queries' do + control = ActiveRecord::QueryRecorder.new { send_search_request(params_for_one) } + expect(response.body).to include('search-results') # Confirm search results to prevent false positives + + expect { send_search_request(params_for_many) }.not_to exceed_query_limit(control.count) + expect(response.body).to include('search-results') # Confirm search results to prevent false positives + end + end + + context 'for code search' do + let(:params_for_code_search) { { search: 'blob: hello' } } + + it 'sets scope to blobs if code search literals are used' do + send_search_request(params_for_code_search) + expect(response).to redirect_to(search_path(params_for_code_search.merge({ scope: 'blobs' }))) + end + end + context 'when searching by SHA' do let(:sha) { '6d394385cf567f80a8fd85055db1ab4c5295806f' } |