diff options
Diffstat (limited to 'spec/services/issuable/common_system_notes_service_spec.rb')
-rw-r--r-- | spec/services/issuable/common_system_notes_service_spec.rb | 44 |
1 files changed, 37 insertions, 7 deletions
diff --git a/spec/services/issuable/common_system_notes_service_spec.rb b/spec/services/issuable/common_system_notes_service_spec.rb index 7e40ac9ff4d..771e7ca42c9 100644 --- a/spec/services/issuable/common_system_notes_service_spec.rb +++ b/spec/services/issuable/common_system_notes_service_spec.rb @@ -3,8 +3,9 @@ require 'spec_helper' describe Issuable::CommonSystemNotesService do - let(:user) { create(:user) } - let(:project) { create(:project) } + let_it_be(:project) { create(:project) } + let_it_be(:user) { create(:user) } + let(:issuable) { create(:issue, project: project) } context 'on issuable update' do @@ -35,6 +36,8 @@ describe Issuable::CommonSystemNotesService do before do milestone = create(:milestone, project: project) issuable.milestone_id = milestone.id + + stub_feature_flags(track_resource_milestone_change_events: false) end it_behaves_like 'system note creation', {}, 'changed milestone' @@ -97,12 +100,39 @@ describe Issuable::CommonSystemNotesService do expect(event.user_id).to eq user.id end - it 'creates a system note for milestone set' do - issuable.milestone = create(:milestone, project: project) - issuable.save + context 'when milestone change event tracking is disabled' do + before do + stub_feature_flags(track_resource_milestone_change_events: false) - expect { subject }.to change { issuable.notes.count }.from(0).to(1) - expect(issuable.notes.last.note).to match('changed milestone') + issuable.milestone = create(:milestone, project: project) + issuable.save + end + + it 'creates a system note for milestone set' do + expect { subject }.to change { issuable.notes.count }.from(0).to(1) + expect(issuable.notes.last.note).to match('changed milestone') + end + + it 'does not create a milestone change event' do + expect { subject }.not_to change { ResourceMilestoneEvent.count } + end + end + + context 'when milestone change event tracking is enabled' do + let_it_be(:milestone) { create(:milestone, project: project) } + let_it_be(:issuable) { create(:issue, project: project, milestone: milestone) } + + before do + stub_feature_flags(track_resource_milestone_change_events: true) + end + + it 'does not create a system note for milestone set' do + expect { subject }.not_to change { issuable.notes.count } + end + + it 'creates a milestone change event' do + expect { subject }.to change { ResourceMilestoneEvent.count }.from(0).to(1) + end end it 'creates a system note for due_date set' do |