diff options
Diffstat (limited to 'spec/workers/expire_job_cache_worker_spec.rb')
| -rw-r--r-- | spec/workers/expire_job_cache_worker_spec.rb | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/spec/workers/expire_job_cache_worker_spec.rb b/spec/workers/expire_job_cache_worker_spec.rb index 95c54a762a4..8efead31a42 100644 --- a/spec/workers/expire_job_cache_worker_spec.rb +++ b/spec/workers/expire_job_cache_worker_spec.rb @@ -8,7 +8,8 @@ RSpec.describe ExpireJobCacheWorker do describe '#perform' do context 'with a job in the pipeline' do - let(:job) { create(:ci_build, pipeline: pipeline) } + let_it_be(:job) { create(:ci_build, pipeline: pipeline) } + let(:job_args) { job.id } include_examples 'an idempotent worker' do @@ -31,6 +32,24 @@ RSpec.describe ExpireJobCacheWorker do subject end end + + it 'does not perform extra queries', :aggregate_failures do + worker = described_class.new + recorder = ActiveRecord::QueryRecorder.new { worker.perform(job.id) } + + occurences = recorder.data.values.flat_map {|v| v[:occurrences]} + project_queries = occurences.select {|s| s.include?('FROM "projects"')} + namespace_queries = occurences.select {|s| s.include?('FROM "namespaces"')} + route_queries = occurences.select {|s| s.include?('FROM "routes"')} + + # This worker is run 1 million times an hour, so we need to save as much + # queries as possible. + expect(recorder.count).to be <= 1 + + expect(project_queries.size).to eq(0) + expect(namespace_queries.size).to eq(0) + expect(route_queries.size).to eq(0) + end end context 'when there is no job in the pipeline' do |