1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
# frozen_string_literal: true
module QA
RSpec.describe 'Data Stores' do
describe 'User', :requires_admin, product_group: :tenant_scale do
let(:admin_api_client) { Runtime::API::Client.as_admin }
let!(:parent_group) { create(:group, path: "parent-group-to-test-user-access-#{SecureRandom.hex(8)}") }
let!(:sub_group) do
create(:group, path: "sub-group-to-test-user-access-#{SecureRandom.hex(8)}", sandbox: parent_group)
end
context 'when added to parent group' do
include QA::Support::Helpers::Project
let!(:parent_group_user) { create(:user, api_client: admin_api_client) }
let!(:parent_group_user_api_client) do
Runtime::API::Client.new(:gitlab, user: parent_group_user)
end
let!(:sub_group_project) do
create(:project, :with_readme, name: 'sub-groupd-project-to-test-user-access', group: sub_group)
end
before do
wait_until_project_is_ready(sub_group_project)
parent_group.add_member(parent_group_user)
end
after do
parent_group_user.remove_via_api!
end
it(
'is allowed to push code to sub-group project via the CLI',
:reliable,
testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/363345'
) do
expect do
Resource::Repository::Push.fabricate! do |push|
push.repository_http_uri = sub_group_project.repository_http_location.uri
push.file_name = 'test.txt'
push.file_content = "# This is a test project named #{sub_group_project.name}"
push.commit_message = 'Add test.txt'
push.branch_name = "new_branch_#{SecureRandom.hex(8)}"
push.user = parent_group_user
end
end.not_to raise_error
end
it(
'is allowed to create a file in sub-group project via the API',
:reliable,
testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/363348'
) do
# Retry is needed due to delays with project authorization updates
# Long term solution to accessing the status of a project authorization update
# has been proposed in https://gitlab.com/gitlab-org/gitlab/-/issues/393369
QA::Support::Retrier.retry_on_exception(max_attempts: 30, sleep_interval: 2) do
expect do
create(:file,
api_client: parent_group_user_api_client,
project: sub_group_project,
branch: "new_branch_#{SecureRandom.hex(8)}")
end.not_to raise_error
end
end
it(
'is allowed to commit to sub-group project via the API', :reliable,
testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/363349'
) do
# Retry is needed due to delays with project authorization updates
# Long term solution to accessing the status of a project authorization update
# has been proposed in https://gitlab.com/gitlab-org/gitlab/-/issues/393369
QA::Support::Retrier.retry_on_exception(max_attempts: 30, sleep_interval: 2) do
expect do
create(:commit,
api_client: parent_group_user_api_client,
project: sub_group_project,
branch: "new_branch_#{SecureRandom.hex(8)}",
start_branch: sub_group_project.default_branch,
commit_message: 'Add new file', actions: [
{ action: 'create', file_path: 'test.txt', content: 'new file' }
])
rescue StandardError => e
QA::Runtime::Logger.error("Full failure message: #{e.message}")
raise
end.not_to raise_error
end
end
end
context 'when added to sub-group' do
let!(:parent_group_project) do
create(:project, :with_readme, name: 'parent-group-project-to-test-user-access', group: parent_group)
end
let!(:sub_group_user) { create(:user, api_client: admin_api_client) }
let!(:sub_group_user_api_client) do
Runtime::API::Client.new(:gitlab, user: sub_group_user)
end
before do
sub_group.add_member(sub_group_user)
end
after do
sub_group_user.remove_via_api!
end
it(
'is not allowed to push code to parent group project via the CLI',
:reliable,
testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/363344'
) do
expect do
Resource::Repository::Push.fabricate! do |push|
push.repository_http_uri = parent_group_project.repository_http_location.uri
push.file_name = 'test.txt'
push.file_content = "# This is a test project named #{parent_group_project.name}"
push.commit_message = 'Add test.txt'
push.branch_name = "new_branch_#{SecureRandom.hex(8)}"
push.user = sub_group_user
end
end.to raise_error(QA::Support::Run::CommandError, /You are not allowed to push code to this project/)
end
it(
'is not allowed to create a file in parent group project via the API',
:reliable,
testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/363343'
) do
expect do
create(:file,
api_client: sub_group_user_api_client,
project: parent_group_project,
branch: "new_branch_#{SecureRandom.hex(8)}")
end.to raise_error(Resource::ApiFabricator::ResourceFabricationFailedError, /403 Forbidden/)
end
it(
'is not allowed to commit to parent group project via the API',
:reliable,
testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/363342'
) do
expect do
create(:commit,
api_client: sub_group_user_api_client,
project: parent_group_project,
branch: "new_branch_#{SecureRandom.hex(8)}",
start_branch: parent_group_project.default_branch,
commit_message: 'Add new file', actions: [
{ action: 'create', file_path: 'test.txt', content: 'new file' }
])
end.to raise_error(Resource::ApiFabricator::ResourceFabricationFailedError,
/403 Forbidden - You are not allowed to push into this branch/)
end
end
end
end
end
|
