1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ProjectsFinder, feature_category: :groups_and_projects do
include AdminModeHelper
describe '#execute' do
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group, :public) }
let_it_be(:private_project) do
create(:project, :private, name: 'A', path: 'A')
end
let_it_be(:internal_project) do
create(:project, :internal, :merge_requests_disabled, group: group, name: 'B', path: 'B', updated_at: 4.days.ago)
end
let_it_be(:public_project) do
create(:project, :public, :merge_requests_enabled, :issues_disabled, group: group, name: 'C', path: 'C')
end
let_it_be(:shared_project) do
create(:project, :private, name: 'D', path: 'D')
end
let_it_be(:banned_user_project) do
create(:project, :public, name: 'Project created by a banned user', creator: create(:user, :banned)).tap do |p|
create(:project_authorization, :owner, user: p.creator, project: p)
end
end
let(:params) { {} }
let(:current_user) { user }
let(:project_ids_relation) { nil }
let(:use_cte) { true }
let(:finder) { described_class.new(params: params.merge(use_cte: use_cte), current_user: current_user, project_ids_relation: project_ids_relation) }
subject { finder.execute }
shared_examples 'ProjectFinder#execute examples' do
describe 'without a user' do
let(:current_user) { nil }
it { is_expected.to eq([public_project]) }
end
describe 'with a user' do
describe 'without private projects' do
it { is_expected.to match_array([public_project, internal_project]) }
end
describe 'with private projects' do
before do
private_project.add_maintainer(user)
end
it { is_expected.to match_array([public_project, internal_project, private_project]) }
end
end
describe 'with project_ids_relation' do
let(:project_ids_relation) { Project.where(id: internal_project.id) }
it { is_expected.to eq([internal_project]) }
end
describe 'with full_paths' do
let_it_be(:second_public_project) do
create(:project, :public, :merge_requests_enabled, :issues_disabled, group: group, name: 'second-public', path: 'second-public')
end
context 'only returns projects matching the provided full paths' do
let(:params) { { full_paths: [public_project.full_path, second_public_project.full_path] } }
it { is_expected.to match_array([public_project, second_public_project]) }
end
end
describe 'with id_after' do
context 'only returns projects with a project id greater than given' do
let(:params) { { id_after: internal_project.id } }
it { is_expected.to eq([public_project]) }
end
end
describe 'with id_before' do
context 'only returns projects with a project id less than given' do
let(:params) { { id_before: public_project.id } }
it { is_expected.to eq([internal_project]) }
end
end
describe 'with both id_before and id_after' do
context 'only returns projects with a project id less than given' do
let!(:projects) { create_list(:project, 5, :public) }
let(:params) { { id_after: projects.first.id, id_before: projects.last.id } }
it { is_expected.to contain_exactly(*projects[1..-2]) }
end
end
describe 'regression: Combination of id_before/id_after and joins requires fully qualified column names' do
context 'only returns projects with a project id less than given and matching search' do
subject { finder.execute.joins(:route) }
let(:params) { { id_before: public_project.id } }
it { is_expected.to eq([internal_project]) }
end
context 'only returns projects with a project id greater than given and matching search' do
subject { finder.execute.joins(:route) }
let(:params) { { id_after: internal_project.id } }
it { is_expected.to eq([public_project]) }
end
end
describe 'filter by visibility_level' do
before do
private_project.add_maintainer(user)
end
context 'private' do
let(:params) { { visibility_level: Gitlab::VisibilityLevel::PRIVATE } }
it { is_expected.to eq([private_project]) }
end
context 'internal' do
let(:params) { { visibility_level: Gitlab::VisibilityLevel::INTERNAL } }
it { is_expected.to eq([internal_project]) }
end
context 'public' do
let(:params) { { visibility_level: Gitlab::VisibilityLevel::PUBLIC } }
it { is_expected.to eq([public_project]) }
end
context 'as string' do
let(:params) { { visibility_level: Gitlab::VisibilityLevel::INTERNAL.to_s } }
it { is_expected.to eq([internal_project]) }
end
end
describe 'filter by updated_at' do
context 'when updated_before is present' do
let(:params) { { updated_before: 2.days.ago } }
it { is_expected.to contain_exactly(internal_project) }
end
context 'when updated_after is present' do
let(:params) { { updated_after: 2.days.ago } }
it { is_expected.not_to include(internal_project) }
end
context 'when both updated_before and updated_after are present' do
let(:params) { { updated_before: 2.days.ago, updated_after: 6.days.ago } }
it { is_expected.to contain_exactly(internal_project) }
context 'when updated_after > updated_before' do
let(:params) { { updated_after: 2.days.ago, updated_before: 6.days.ago } }
it { is_expected.to be_empty }
it 'does not query the DB' do
expect { subject.to_a }.to make_queries(0)
end
end
context 'when updated_after equals updated_before', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/408387' do
let(:params) { { updated_after: internal_project.updated_at, updated_before: internal_project.updated_at } }
it 'allows an exact match' do
expect(subject).to contain_exactly(internal_project)
end
end
context 'when arguments are invalid datetimes' do
let(:params) { { updated_after: 'invalid', updated_before: 'inavlid' } }
it 'does not filter by updated_at' do
expect(subject).to contain_exactly(internal_project, public_project)
end
end
end
end
describe 'filter by tags (deprecated)' do
before do
public_project.reload
public_project.topic_list = 'foo'
public_project.save!
end
let(:params) { { tag: 'foo' } }
it { is_expected.to eq([public_project]) }
end
describe 'filter by topics' do
before do
public_project.reload
public_project.topic_list = 'foo, bar'
public_project.save!
end
context 'single topic' do
let(:params) { { topic: 'foo' } }
it { is_expected.to eq([public_project]) }
end
context 'multiple topics' do
let(:params) { { topic: 'bar, foo' } }
it { is_expected.to eq([public_project]) }
end
context 'one topic matches, other one does not' do
let(:params) { { topic: 'foo, xyz' } }
it { is_expected.to eq([]) }
end
context 'no matching topic' do
let(:params) { { topic: 'xyz' } }
it { is_expected.to eq([]) }
end
end
describe 'filter by topic_id' do
let_it_be(:topic1) { create(:topic) }
let_it_be(:topic2) { create(:topic) }
before do
public_project.reload
public_project.topics << topic1
public_project.save!
end
context 'topic with assigned projects' do
let(:params) { { topic_id: topic1.id } }
it { is_expected.to eq([public_project]) }
end
context 'topic without assigned projects' do
let(:params) { { topic_id: topic2.id } }
it { is_expected.to eq([]) }
end
context 'non-existing topic' do
let(:params) { { topic_id: non_existing_record_id } }
it { is_expected.to eq([]) }
end
end
describe 'filter by personal' do
let!(:personal_project) { create(:project, namespace: user.namespace) }
let(:params) { { personal: true } }
it { is_expected.to eq([personal_project]) }
end
describe 'filter by search' do
let(:params) { { search: 'C' } }
it { is_expected.to eq([public_project]) }
end
context 'with anonymous user' do
let(:public_project_2) { create(:project, :public, group: group, name: 'E', path: 'E') }
let(:current_user) { nil }
let(:params) { { search: 'C' } }
context 'with disable_anonymous_project_search feature flag enabled' do
before do
stub_feature_flags(disable_anonymous_project_search: true)
end
it 'does not perform search' do
is_expected.to eq([public_project_2, public_project])
end
end
context 'with disable_anonymous_project_search feature flag disabled' do
before do
stub_feature_flags(disable_anonymous_project_search: false)
end
it 'finds one public project' do
is_expected.to eq([public_project])
end
end
end
describe 'filter by name for backward compatibility' do
let(:params) { { name: 'C' } }
it { is_expected.to eq([public_project]) }
end
describe 'filter by search with minimum search length' do
context 'when search term is shorter than minimum length' do
let(:params) { { search: 'C', minimum_search_length: 3 } }
it { is_expected.to be_empty }
end
context 'when search term is longer than minimum length' do
let(:project) { create(:project, :public, group: group, name: 'test_project') }
let(:params) { { search: 'test', minimum_search_length: 3 } }
it { is_expected.to eq([project]) }
end
context 'when minimum length is invalid' do
let(:params) { { search: 'C', minimum_search_length: 'x' } }
it 'ignores the minimum length param' do
is_expected.to eq([public_project])
end
end
end
describe 'filter by group name' do
let(:params) { { name: group.name, search_namespaces: true } }
it { is_expected.to eq([public_project, internal_project]) }
end
describe 'filter by archived' do
let!(:archived_project) { create(:project, :public, :archived, name: 'E', path: 'E') }
context 'non_archived=true' do
let(:params) { { non_archived: true } }
it { is_expected.to match_array([public_project, internal_project]) }
end
context 'non_archived=false' do
let(:params) { { non_archived: false } }
it { is_expected.to match_array([public_project, internal_project, archived_project]) }
end
describe 'filter by archived only' do
let(:params) { { archived: 'only' } }
it { is_expected.to eq([archived_project]) }
end
describe 'filter by archived for backward compatibility' do
let(:params) { { archived: false } }
it { is_expected.to match_array([public_project, internal_project]) }
end
end
describe 'filter by trending' do
let!(:trending_project) { create(:trending_project, project: public_project) }
let(:params) { { trending: true } }
it { is_expected.to eq([public_project]) }
end
describe 'filter by owned' do
let(:params) { { owned: true } }
let!(:owned_project) { create(:project, :private, namespace: current_user.namespace) }
it { is_expected.to eq([owned_project]) }
end
describe 'filter by non_public' do
let(:params) { { non_public: true } }
before do
private_project.add_developer(current_user)
end
it { is_expected.to eq([private_project]) }
end
describe 'filter by starred' do
let(:params) { { starred: true } }
before do
current_user.toggle_star(public_project)
end
it { is_expected.to eq([public_project]) }
it 'returns only projects the user has access to' do
current_user.toggle_star(private_project)
is_expected.to eq([public_project])
expect(subject.count).to eq(1)
expect(subject.limit(1000).count).to eq(1)
end
end
describe 'filter by last_activity_after' do
let(:params) { { last_activity_after: 60.minutes.ago } }
before do
internal_project.update!(last_activity_at: Time.now)
public_project.update!(last_activity_at: 61.minutes.ago)
end
it { is_expected.to match_array([internal_project]) }
end
describe 'filters by without_deleted by default' do
let_it_be(:pending_delete_project) { create(:project, :public, pending_delete: true) }
it 'returns projects that are not pending_delete' do
expect(subject).not_to include(pending_delete_project)
expect(subject).to include(public_project, internal_project)
end
context 'when include_pending_delete param is provided' do
let(:params) { { include_pending_delete: true } }
it 'returns projects that are not pending_delete' do
expect(subject).not_to include(pending_delete_project)
expect(subject).to include(public_project, internal_project)
end
context 'when user is an admin', :enable_admin_mode do
let(:current_user) { create(:admin) }
it 'also return pending_delete projects' do
expect(subject).to include(public_project, internal_project, pending_delete_project)
end
end
end
end
describe 'filter by last_activity_before' do
let(:params) { { last_activity_before: 60.minutes.ago } }
before do
internal_project.update!(last_activity_at: Time.now)
public_project.update!(last_activity_at: 61.minutes.ago)
end
it { is_expected.to match_array([public_project]) }
end
describe 'filter by repository_storage' do
let(:params) { { repository_storage: 'nfs-05' } }
let!(:project) { create(:project, :public) }
before do
project.update_columns(repository_storage: 'nfs-05')
end
it { is_expected.to match_array([project]) }
end
describe 'filter by language' do
let_it_be(:ruby) { create(:programming_language, name: 'Ruby') }
let_it_be(:repository_language) { create(:repository_language, project: internal_project, programming_language: ruby) }
let(:params) { { language: ruby.id } }
it { is_expected.to match_array([internal_project]) }
end
describe 'filter by organization' do
let_it_be(:organization) { create(:organization) }
let_it_be(:organization_project) { create(:project, organization: organization) }
let(:params) { { organization: organization } }
before do
organization_project.add_maintainer(current_user)
end
it { is_expected.to match_array([organization_project]) }
end
describe 'when with_issues_enabled is true' do
let(:params) { { with_issues_enabled: true } }
it { is_expected.to match_array([internal_project]) }
end
describe 'when with_merge_requests_enabled is true' do
let(:params) { { with_merge_requests_enabled: true } }
it { is_expected.to match_array([public_project]) }
end
describe 'sorting' do
let_it_be(:more_projects) do
[
create(:project, :internal, group: group, name: 'projA', path: 'projA'),
create(:project, :internal, group: group, name: 'projABC', path: 'projABC'),
create(:project, :internal, group: group, name: 'projAB', path: 'projAB')
]
end
context 'when sorting by a field' do
let(:params) { { sort: 'name_asc' } }
it { is_expected.to eq(([internal_project, public_project] + more_projects).sort_by { |p| p[:name] }) }
end
context 'when sorting by similarity' do
let(:params) { { sort: 'similarity', search: 'pro' } }
it { is_expected.to eq([more_projects[0], more_projects[2], more_projects[1]]) }
end
context 'when no sort is provided' do
it { is_expected.to eq(([internal_project, public_project] + more_projects).sort_by { |p| p[:id] }.reverse) }
end
end
describe 'with admin user' do
let(:user) { create(:admin) }
context 'with admin mode enabled' do
before do
enable_admin_mode!(current_user)
end
it do
is_expected.to match_array([
public_project,
internal_project,
private_project,
shared_project,
banned_user_project
])
end
end
context 'with admin mode disabled' do
it { is_expected.to match_array([public_project, internal_project]) }
context 'when hide_projects_of_banned_users FF is disabled' do
before do
stub_feature_flags(hide_projects_of_banned_users: false)
end
it { is_expected.to match_array([public_project, internal_project, banned_user_project]) }
end
end
end
end
describe 'without CTE flag enabled', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/408387' do
let(:use_cte) { false }
it_behaves_like 'ProjectFinder#execute examples'
end
describe 'with CTE flag enabled', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/408387' do
let(:use_cte) { true }
it_behaves_like 'ProjectFinder#execute examples'
end
end
end
|