1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe IntegrationsHelper, feature_category: :integrations do
let_it_be_with_refind(:project) { create(:project) }
shared_examples 'is defined for each integration event' do
Integration.available_integration_names.each do |integration|
events = Integration.integration_name_to_model(integration).new.configurable_events
events.each do |event|
context "when integration is #{integration}, event is #{event}" do
let(:integration) { integration }
let(:event) { event }
it { is_expected.not_to be_nil }
end
end
end
end
describe '#integration_event_title' do
subject { helper.integration_event_title(event) }
it_behaves_like 'is defined for each integration event'
end
describe '#integration_event_description' do
subject { helper.integration_event_description(integration, event) }
it_behaves_like 'is defined for each integration event'
context 'when integration is Jira' do
let(:integration) { Integrations::Jira.new }
let(:event) { 'merge_request_events' }
it { is_expected.to include('Jira') }
end
context 'when integration is Team City' do
let(:integration) { Integrations::Teamcity.new }
let(:event) { 'merge_request_events' }
it { is_expected.to include('TeamCity') }
end
end
describe '#integration_form_data' do
before do
allow(helper).to receive_messages(
request: double(referer: '/services')
)
end
let(:fields) do
[
:id,
:show_active,
:activated,
:activate_disabled,
:type,
:merge_request_events,
:commit_events,
:enable_comments,
:comment_detail,
:learn_more_path,
:about_pricing_url,
:trigger_events,
:fields,
:inherit_from_id,
:integration_level,
:editable,
:cancel_path,
:can_test,
:test_path,
:reset_path,
:form_path,
:redirect_to
]
end
let(:jira_fields) do
[
:jira_issue_transition_automatic,
:jira_issue_transition_id
]
end
let(:slack_app_fields) do
[
:upgrade_slack_url,
:should_upgrade_slack
]
end
subject { helper.integration_form_data(integration) }
context 'with a GitLab for Slack App integration' do
let(:integration) { build(:gitlab_slack_application_integration, project: project) }
let(:redirect_url) do
"http://test.host/#{project.full_path}/-/settings/slack/slack_auth"
end
before do
allow(helper).to receive(:slack_auth_project_settings_slack_url).and_return(redirect_url)
end
it { is_expected.to include(*fields, *slack_app_fields) }
it { is_expected.not_to include(*jira_fields) }
it 'includes app upgrade URL' do
stub_application_setting(slack_app_id: 'MOCK_APP_ID')
expect(subject[:upgrade_slack_url]).to start_with(
[
Projects::SlackApplicationInstallService::SLACK_AUTHORIZE_URL,
'?client_id=MOCK_APP_ID',
"&redirect_uri=#{CGI.escape(redirect_url)}"
].join
)
end
it 'includes the flag to upgrade Slack app, set to true' do
expect(subject[:should_upgrade_slack]).to eq 'true'
end
context 'when the integration includes all necessary scopes' do
let(:integration) { create(:gitlab_slack_application_integration, :all_features_supported, project: project) }
it 'includes the flag to upgrade Slack app, set to false' do
expect(subject[:should_upgrade_slack]).to eq 'false'
end
end
end
context 'with Jenkins integration' do
let(:integration) { build(:jenkins_integration) }
it { is_expected.to include(*fields) }
it { is_expected.not_to include(*jira_fields) }
it { is_expected.not_to include(*slack_app_fields) }
specify do
expect(subject[:reset_path]).to eq(helper.scoped_reset_integration_path(integration))
end
specify do
expect(subject[:redirect_to]).to eq('/services')
end
end
context 'with Jira integration' do
let(:integration) { build(:jira_integration) }
it { is_expected.to include(*fields, *jira_fields) }
it { is_expected.not_to include(*slack_app_fields) }
end
end
describe '#integration_overrides_data' do
let(:integration) { build_stubbed(:jira_integration) }
let(:fields) do
[
edit_path: edit_admin_application_settings_integration_path(integration),
overrides_path: overrides_admin_application_settings_integration_path(integration, format: :json)
]
end
subject { helper.integration_overrides_data(integration) }
it { is_expected.to include(*fields) }
end
describe '#scoped_reset_integration_path' do
let(:integration) { build_stubbed(:jira_integration) }
let(:group) { nil }
subject { helper.scoped_reset_integration_path(integration, group: group) }
context 'when no group is present' do
it 'returns instance-level path' do
is_expected.to eq(reset_admin_application_settings_integration_path(integration))
end
end
context 'when group is present' do
let(:group) { build_stubbed(:group) }
it 'returns group-level path' do
is_expected.to eq(reset_group_settings_integration_path(group, integration))
end
end
context 'when a new integration is not persisted' do
let_it_be(:integration) { build(:jira_integration) }
it 'returns an empty string' do
is_expected.to eq('')
end
end
end
describe '#add_to_slack_link' do
let(:slack_link) { helper.add_to_slack_link(project, 'A12345') }
let(:query) { Rack::Utils.parse_query(URI.parse(slack_link).query) }
before do
allow(helper).to receive(:form_authenticity_token).and_return('a token')
allow(helper).to receive(:slack_auth_project_settings_slack_url).and_return('http://redirect')
end
it 'returns the endpoint URL with all needed params' do
expect(slack_link).to start_with(Projects::SlackApplicationInstallService::SLACK_AUTHORIZE_URL)
expect(slack_link).to include('&state=a+token')
expect(query).to include(
'scope' => 'commands,chat:write,chat:write.public',
'client_id' => 'A12345',
'redirect_uri' => 'http://redirect',
'state' => 'a token'
)
end
end
describe '#gitlab_slack_application_data' do
let_it_be(:projects) { create_list(:project, 3) }
def relation
Project.id_in(projects.pluck(:id)).inc_routes
end
before do
allow(helper).to receive(:current_user).and_return(build(:user))
allow(helper).to receive(:new_session_path).and_return('http://session-path')
end
it 'includes the required keys' do
additions = helper.gitlab_slack_application_data(relation)
expect(additions.keys).to include(
:projects,
:sign_in_path,
:is_signed_in,
:slack_link_path,
:gitlab_logo_path,
:slack_logo_path
)
end
it 'does not suffer from N+1 performance issues' do
baseline = ActiveRecord::QueryRecorder.new { helper.gitlab_slack_application_data(relation.limit(1)) }
expect do
helper.gitlab_slack_application_data(relation)
end.not_to exceed_query_limit(baseline)
end
it 'serializes nil projects without error' do
expect(helper.gitlab_slack_application_data(nil)).to include(projects: '[]')
end
end
describe '#integration_issue_type' do
using RSpec::Parameterized::TableSyntax
let_it_be(:issue) { create(:issue) }
where(:issue_type, :expected_i18n_issue_type) do
"issue" | _('Issue')
"incident" | _('Incident')
"test_case" | _('Test case')
"requirement" | _('Requirement')
"task" | _('Task')
end
with_them do
before do
issue.assign_attributes(work_item_type: WorkItems::Type.default_by_type(issue_type))
issue.save!(validate: false)
end
it "return the correct i18n issue type" do
expect(described_class.integration_issue_type(issue.work_item_type.base_type)).to eq(expected_i18n_issue_type)
end
end
it "only consider these enumeration values are valid" do
expected_valid_types = %w[issue incident test_case requirement task objective key_result]
expect(WorkItems::Type.base_types.keys).to contain_exactly(*expected_valid_types)
end
end
describe '#integration_todo_target_type' do
using RSpec::Parameterized::TableSyntax
let!(:todo) { create(:todo, commit_id: '123') }
where(:target_type, :expected_i18n_target_type) do
"Commit" | _("Commit")
"Issue" | _("Issue")
"MergeRequest" | _("Merge Request")
'Epic' | _('Epic')
DesignManagement::Design.name | _('design')
AlertManagement::Alert.name | _('alert')
end
with_them do
before do
todo.update!(target_type: target_type)
end
it { expect(described_class.integration_todo_target_type(todo.target_type)).to eq(expected_i18n_target_type) }
end
end
end
|