1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Auth::Otp::Strategies::DuoAuth::ManualOtp, feature_category: :system_access do
let_it_be(:user) { create(:user) }
let_it_be(:otp_code) { 42 }
let_it_be(:hostname) { 'duo_auth.example.com' }
let_it_be(:integration_key) { 'int3gr4t1on' }
let_it_be(:secret_key) { 's3cr3t' }
let_it_be(:duo_response_builder) { Struct.new(:body) }
let_it_be(:response_status) { 200 }
let_it_be(:duo_auth_url) { "https://#{hostname}/auth/v2/auth/" }
let_it_be(:params) do
{ username: user.username,
factor: "passcode",
passcode: otp_code }
end
let_it_be(:manual_otp) { described_class.new(user) }
subject(:response) { manual_otp.validate(otp_code) }
before do
stub_duo_auth_config(
enabled: true,
hostname: hostname,
secret_key: secret_key,
integration_key: integration_key
)
end
context 'when successful validation' do
before do
allow(duo_client).to receive(:request)
.with("POST", "/auth/v2/auth", params)
.and_return(duo_response_builder.new('{ "response": { "result": "allow" }}'))
allow(manual_otp).to receive(:duo_client).and_return(duo_client)
end
it 'returns success' do
response
expect(response[:status]).to eq(:success)
end
end
context 'when unsuccessful validation' do
before do
allow(duo_client).to receive(:request)
.with("POST", "/auth/v2/auth", params)
.and_return(duo_response_builder.new('{ "response": { "result": "deny" }}'))
allow(manual_otp).to receive(:duo_client).and_return(duo_client)
end
it 'returns error' do
response
expect(response[:status]).to eq(:error)
end
end
context 'when unexpected error' do
before do
allow(duo_client).to receive(:request)
.with("POST", "/auth/v2/auth", params)
.and_return(duo_response_builder.new('aaa'))
allow(manual_otp).to receive(:duo_client).and_return(duo_client)
end
it 'returns error' do
response
expect(response[:status]).to eq(:error)
expect(response[:message]).to match(/unexpected character/)
end
end
def stub_duo_auth_config(duo_auth_settings)
allow(::Gitlab.config.duo_auth).to(receive_messages(duo_auth_settings))
end
def duo_client
manual_otp.send(:duo_client)
end
end
|