spec/lib/gitlab/ci/tags/bulk_insert_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88

# frozen_string_literal: true

require 'spec_helper'

RSpec.describe Gitlab::Ci::Tags::BulkInsert do
  let_it_be(:project) { create(:project, :repository) }
  let_it_be(:pipeline) { create(:ci_pipeline, project: project) }
  let_it_be_with_refind(:job) { create(:ci_build, :unique_name, pipeline: pipeline) }
  let_it_be_with_refind(:other_job) { create(:ci_build, :unique_name, pipeline: pipeline) }

  let(:statuses) { [job, other_job] }

  subject(:service) { described_class.new(statuses) }

  describe 'gem version' do
    let(:acceptable_version) { '9.0.0' }

    let(:error_message) do
      <<~MESSAGE
      A mechanism depending on internals of 'act-as-taggable-on` has been designed
      to bulk insert tags for Ci::Build records.
      Please review the code carefully before updating the gem version
      https://gitlab.com/gitlab-org/gitlab/-/issues/350053
      MESSAGE
    end

    it { expect(ActsAsTaggableOn::VERSION).to eq(acceptable_version), error_message }
  end

  describe '#insert!' do
    context 'without tags' do
      it { expect(service.insert!).to be_falsey }
    end

    context 'with tags' do
      before do
        job.tag_list = %w[tag1 tag2]
        other_job.tag_list = %w[tag2 tag3 tag4]
      end

      it 'persists tags' do
        expect(service.insert!).to be_truthy

        expect(job.reload.tag_list).to match_array(%w[tag1 tag2])
        expect(other_job.reload.tag_list).to match_array(%w[tag2 tag3 tag4])
      end

      context 'when batching inserts for tags' do
        before do
          stub_const("#{described_class}::TAGS_BATCH_SIZE", 2)
        end

        it 'inserts tags in batches' do
          recorder = ActiveRecord::QueryRecorder.new { service.insert! }
          count = recorder.log.count { |query| query.include?('INSERT INTO "tags"') }

          expect(count).to eq(2)
        end
      end

      context 'when batching inserts for taggings' do
        before do
          stub_const("#{described_class}::TAGGINGS_BATCH_SIZE", 2)
        end

        it 'inserts taggings in batches' do
          recorder = ActiveRecord::QueryRecorder.new { service.insert! }
          count = recorder.log.count { |query| query.include?('INSERT INTO "taggings"') }

          expect(count).to eq(3)
        end
      end
    end

    context 'with tags for only one job' do
      before do
        job.tag_list = %w[tag1 tag2]
      end

      it 'persists tags' do
        expect(service.insert!).to be_truthy

        expect(job.reload.tag_list).to match_array(%w[tag1 tag2])
        expect(other_job.reload.tag_list).to be_empty
      end
    end
  end
end