1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Database::Migrations::LockRetryMixin do
describe Gitlab::Database::Migrations::LockRetryMixin::ActiveRecordMigrationProxyLockRetries do
let(:migration) { double }
let(:return_value) { double }
let(:class_def) do
Class.new do
include Gitlab::Database::Migrations::LockRetryMixin::ActiveRecordMigrationProxyLockRetries
attr_reader :migration
def initialize(migration)
@migration = migration
end
end
end
describe '#enable_lock_retries?' do
subject { class_def.new(migration).enable_lock_retries? }
it 'delegates to #migration' do
expect(migration).to receive(:enable_lock_retries?).and_return(return_value)
result = subject
expect(result).to eq(return_value)
end
end
describe '#migration_class' do
subject { class_def.new(migration).migration_class }
it 'retrieves actual migration class from #migration' do
expect(migration).to receive(:class).and_return(return_value)
result = subject
expect(result).to eq(return_value)
end
end
end
describe Gitlab::Database::Migrations::LockRetryMixin::ActiveRecordMigratorLockRetries do
let(:class_def) do
Class.new do
attr_reader :receiver
def initialize(receiver)
@receiver = receiver
end
def ddl_transaction(migration, &block)
receiver.ddl_transaction(migration, &block)
end
def use_transaction?(migration)
receiver.use_transaction?(migration)
end
end.prepend(Gitlab::Database::Migrations::LockRetryMixin::ActiveRecordMigratorLockRetries)
end
subject { class_def.new(receiver) }
before do
allow(migration).to receive(:migration_class).and_return('TestClass')
allow(receiver).to receive(:ddl_transaction)
end
context 'with transactions disabled' do
let(:migration) { double('migration', enable_lock_retries?: false) }
let(:receiver) { double('receiver', use_transaction?: false)}
it 'calls super method' do
p = proc { }
expect(receiver).to receive(:ddl_transaction).with(migration, &p)
subject.ddl_transaction(migration, &p)
end
end
context 'with transactions enabled, but lock retries disabled' do
let(:receiver) { double('receiver', use_transaction?: true)}
let(:migration) { double('migration', enable_lock_retries?: false) }
it 'calls super method' do
p = proc { }
expect(receiver).to receive(:ddl_transaction).with(migration, &p)
subject.ddl_transaction(migration, &p)
end
end
context 'with transactions enabled and lock retries enabled' do
let(:receiver) { double('receiver', use_transaction?: true)}
let(:migration) { double('migration', enable_lock_retries?: true) }
it 'calls super method' do
p = proc { }
expect(receiver).not_to receive(:ddl_transaction)
expect_next_instance_of(Gitlab::Database::WithLockRetries) do |retries|
expect(retries).to receive(:run).with(raise_on_exhaustion: false, &p)
end
subject.ddl_transaction(migration, &p)
end
end
end
describe '.patch!' do
subject { described_class.patch! }
it 'patches MigrationProxy' do
expect(ActiveRecord::MigrationProxy).to receive(:prepend).with(Gitlab::Database::Migrations::LockRetryMixin::ActiveRecordMigrationProxyLockRetries)
subject
end
it 'patches Migrator' do
expect(ActiveRecord::Migrator).to receive(:prepend).with(Gitlab::Database::Migrations::LockRetryMixin::ActiveRecordMigratorLockRetries)
subject
end
end
end
|
