1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::GithubImport::BulkImporting, feature_category: :importers do
let(:project) { instance_double(Project, id: 1) }
let(:importer) { MyImporter.new(project, double) }
let(:importer_class) do
Class.new do
include Gitlab::GithubImport::BulkImporting
def object_type
:object_type
end
private
def model
Label
end
end
end
let(:label) { instance_double('Label', invalid?: false) }
before do
stub_const 'MyImporter', importer_class
end
describe '#build_database_rows' do
context 'without validation errors' do
let(:object) { double(:object, title: 'Foo') }
it 'returns an array containing the rows to insert' do
expect(importer)
.to receive(:build_attributes)
.with(object)
.and_return({ title: 'Foo' })
expect(Label)
.to receive(:new)
.with({ title: 'Foo' })
.and_return(label)
expect(importer)
.to receive(:already_imported?)
.with(object)
.and_return(false)
expect(Gitlab::Import::Logger)
.to receive(:info)
.with(
import_type: :github,
project_id: 1,
importer: 'MyImporter',
message: '1 object_types fetched'
)
expect(Gitlab::GithubImport::ObjectCounter)
.to receive(:increment)
.with(
project,
:object_type,
:fetched,
value: 1
)
enum = [[object, 1]].to_enum
rows, errors = importer.build_database_rows(enum)
expect(rows).to match_array([{ title: 'Foo' }])
expect(errors).to be_empty
end
it 'does not import objects that have already been imported' do
expect(importer)
.not_to receive(:build_attributes)
expect(importer)
.to receive(:already_imported?)
.with(object)
.and_return(true)
expect(Gitlab::Import::Logger)
.to receive(:info)
.with(
import_type: :github,
project_id: 1,
importer: 'MyImporter',
message: '0 object_types fetched'
)
expect(Gitlab::GithubImport::ObjectCounter)
.to receive(:increment)
.with(
project,
:object_type,
:fetched,
value: 0
)
enum = [[object, 1]].to_enum
rows, errors = importer.build_database_rows(enum)
expect(rows).to be_empty
expect(errors).to be_empty
end
end
context 'with validation errors' do
let(:object) { double(:object, id: 12345, title: 'bug,bug') }
before do
allow(importer)
.to receive(:already_imported?)
.with(object)
.and_return(false)
allow(importer)
.to receive(:build_attributes)
.with(object)
.and_return({ title: 'bug,bug' })
end
context 'without implemented github_identifiers method' do
it 'raises NotImplementedError' do
enum = [[object, 1]].to_enum
expect { importer.build_database_rows(enum) }.to raise_error(NotImplementedError)
end
end
context 'with implemented github_identifiers method' do
it 'returns an array containing the validation errors and logs them' do
expect(importer)
.to receive(:github_identifiers)
.with(object)
.and_return(
{
id: object.id,
title: object.title,
object_type: importer.object_type
}
)
expect(Gitlab::Import::Logger)
.to receive(:error)
.with(
import_type: :github,
project_id: 1,
importer: 'MyImporter',
message: ['Title is invalid'],
github_identifiers: { id: 12345, title: 'bug,bug', object_type: :object_type }
)
expect(Gitlab::GithubImport::ObjectCounter)
.to receive(:increment)
.with(
project,
:object_type,
:fetched,
value: 0
)
enum = [[object, 1]].to_enum
rows, errors = importer.build_database_rows(enum)
expect(rows).to be_empty
expect(errors).not_to be_empty
expect(errors[0][:validation_errors].full_messages).to match_array(['Title is invalid'])
expect(errors[0][:github_identifiers]).to eq({ id: 12345, title: 'bug,bug', object_type: :object_type })
end
end
end
end
describe '#bulk_insert' do
it 'bulk inserts rows into the database' do
rows = [{ title: 'Foo' }] * 10
expect(Gitlab::Import::Logger)
.to receive(:info)
.twice
.with(
import_type: :github,
project_id: 1,
importer: 'MyImporter',
message: '5 object_types imported'
)
expect(Gitlab::GithubImport::ObjectCounter)
.to receive(:increment)
.twice
.with(
project,
:object_type,
:imported,
value: 5
)
expect(ApplicationRecord)
.to receive(:legacy_bulk_insert)
.ordered
.with('labels', rows.first(5))
expect(ApplicationRecord)
.to receive(:legacy_bulk_insert)
.ordered
.with('labels', rows.last(5))
importer.bulk_insert(rows, batch_size: 5)
end
end
describe '#bulk_insert_failures', :timecop do
let(:import_failures) { instance_double('ImportFailure::ActiveRecord_Associations_CollectionProxy') }
let(:label) { Label.new(title: 'invalid,title') }
let(:validation_errors) { ActiveModel::Errors.new(label) }
let(:formatted_errors) do
[{
source: 'MyImporter',
exception_class: 'ActiveRecord::RecordInvalid',
exception_message: 'Title invalid',
correlation_id_value: 'cid',
retry_count: nil,
created_at: Time.zone.now,
external_identifiers: { id: 123456 }
}]
end
it 'bulk inserts validation errors into import_failures' do
error = ActiveModel::Errors.new(label)
error.add(:base, 'Title invalid')
freeze_time do
expect(project).to receive(:import_failures).and_return(import_failures)
expect(import_failures).to receive(:insert_all).with(formatted_errors)
expect(Labkit::Correlation::CorrelationId).to receive(:current_or_new_id).and_return('cid')
importer.bulk_insert_failures([{
validation_errors: error,
github_identifiers: { id: 123456 }
}])
end
end
end
describe '#object_type' do
let(:importer_class) do
Class.new do
include Gitlab::GithubImport::BulkImporting
end
end
it 'raises NotImplementedError' do
expect { importer.object_type }.to raise_error(NotImplementedError)
end
end
end
|
