1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
# frozen_string_literal: true
require 'spec_helper'
require_migration!
RSpec.describe FinalizeBackfillUserDetailsFields, :migration, feature_category: :user_management do
let(:batched_migrations) { table(:batched_background_migrations) }
let(:batch_failed_status) { 2 }
let(:batch_finalized_status) { 3 }
let!(:migration) { described_class::BACKFILL_MIGRATION }
describe '#up' do
shared_examples 'finalizes the migration' do
it 'finalizes the migration' do
expect do
migrate!
migration_record.reload
failed_job.reload
end.to change { migration_record.status }.from(migration_record.status).to(3).and(
change { failed_job.status }.from(batch_failed_status).to(batch_finalized_status)
)
end
end
context 'when migration is missing' do
before do
batched_migrations.where(job_class_name: migration).delete_all
end
it 'warns migration not found' do
expect(Gitlab::AppLogger)
.to receive(:warn).with(/Could not find batched background migration for the given configuration:/)
migrate!
end
end
context 'with migration present' do
let!(:migration_record) do
batched_migrations.create!(
job_class_name: migration,
table_name: :users,
column_name: :id,
job_arguments: [],
interval: 2.minutes,
min_value: 1,
max_value: 2,
batch_size: 1000,
sub_batch_size: 500,
max_batch_size: 5000,
gitlab_schema: :gitlab_main,
status: 3 # finished
)
end
context 'when migration finished successfully' do
it 'does not raise exception' do
expect { migrate! }.not_to raise_error
end
end
context 'when users.linkedin column has already been dropped' do
before do
table(:users).create!(id: 1, email: 'author@example.com', username: 'author', projects_limit: 10)
ActiveRecord::Base.connection.execute("ALTER TABLE users DROP COLUMN linkedin")
migration_record.update_column(:status, 1)
end
after do
ActiveRecord::Base.connection.execute("ALTER TABLE users ADD COLUMN linkedin text DEFAULT '' NOT NULL")
end
it 'does not raise exception' do
expect { migrate! }.not_to raise_error
end
end
context 'with different migration statuses', :redis do
using RSpec::Parameterized::TableSyntax
where(:status, :description) do
0 | 'paused'
1 | 'active'
4 | 'failed'
5 | 'finalizing'
end
with_them do
let!(:failed_job) do
table(:batched_background_migration_jobs).create!(
batched_background_migration_id: migration_record.id,
status: batch_failed_status,
min_value: 1,
max_value: 10,
attempts: 2,
batch_size: 100,
sub_batch_size: 10
)
end
before do
migration_record.update!(status: status)
end
it_behaves_like 'finalizes the migration'
end
end
end
end
end
|
