1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Create a work item', feature_category: :team_planning do
include GraphqlHelpers
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, group: group) }
let_it_be(:developer) { create(:user).tap { |user| group.add_developer(user) } }
let(:input) do
{
'title' => 'new title',
'description' => 'new description',
'confidential' => true,
'workItemTypeId' => WorkItems::Type.default_by_type(:task).to_gid.to_s
}
end
let(:fields) { nil }
let(:mutation_response) { graphql_mutation_response(:work_item_create) }
let(:current_user) { developer }
RSpec.shared_examples 'creates work item' do
it 'creates the work item' do
expect do
post_graphql_mutation(mutation, current_user: current_user)
end.to change(WorkItem, :count).by(1)
created_work_item = WorkItem.last
expect(response).to have_gitlab_http_status(:success)
expect(created_work_item).to be_confidential
expect(created_work_item.work_item_type.base_type).to eq('task')
expect(mutation_response['workItem']).to include(
input.except('workItemTypeId').merge(
'id' => created_work_item.to_gid.to_s,
'workItemType' => hash_including('name' => 'Task')
)
)
end
context 'when input is invalid' do
let(:input) { { 'title' => '', 'workItemTypeId' => WorkItems::Type.default_by_type(:task).to_gid.to_s } }
it 'does not create and returns validation errors' do
expect do
post_graphql_mutation(mutation, current_user: current_user)
end.to not_change(WorkItem, :count)
expect(graphql_mutation_response(:work_item_create)['errors']).to contain_exactly("Title can't be blank")
end
end
it_behaves_like 'has spam protection' do
let(:mutation_class) { ::Mutations::WorkItems::Create }
end
context 'with hierarchy widget input' do
let(:widgets_response) { mutation_response['workItem']['widgets'] }
let(:fields) do
<<~FIELDS
workItem {
widgets {
type
... on WorkItemWidgetHierarchy {
parent {
id
}
children {
edges {
node {
id
}
}
}
}
}
}
errors
FIELDS
end
context 'when setting parent' do
let_it_be(:parent) { create(:work_item, **container_params) }
let(:input) do
{
title: 'item1',
workItemTypeId: WorkItems::Type.default_by_type(:task).to_gid.to_s,
hierarchyWidget: { 'parentId' => parent.to_gid.to_s }
}
end
it 'updates the work item parent' do
post_graphql_mutation(mutation, current_user: current_user)
expect(response).to have_gitlab_http_status(:success)
expect(widgets_response).to include(
{
'children' => { 'edges' => [] },
'parent' => { 'id' => parent.to_gid.to_s },
'type' => 'HIERARCHY'
}
)
end
context 'when parent work item type is invalid' do
let_it_be(:parent) { create(:work_item, :task, **container_params) }
it 'returns error' do
post_graphql_mutation(mutation, current_user: current_user)
expect(mutation_response['errors'])
.to contain_exactly(/cannot be added: is not allowed to add this type of parent/)
expect(mutation_response['workItem']).to be_nil
end
end
context 'when parent work item is not found' do
let_it_be(:parent) { build_stubbed(:work_item, id: non_existing_record_id) }
it 'returns a top level error' do
post_graphql_mutation(mutation, current_user: current_user)
expect(graphql_errors.first['message']).to include('No object found for `parentId')
end
end
context 'when adjacent is already in place' do
let_it_be(:adjacent) { create(:work_item, :task, **container_params) }
let(:work_item) { WorkItem.last }
let(:input) do
{
title: 'item1',
workItemTypeId: WorkItems::Type.default_by_type(:task).to_gid.to_s,
hierarchyWidget: { 'parentId' => parent.to_gid.to_s }
}
end
before_all do
create(:parent_link, work_item_parent: parent, work_item: adjacent, relative_position: 0)
end
it 'creates work item and sets the relative position to be AFTER adjacent' do
expect do
post_graphql_mutation(mutation, current_user: current_user)
end.to change(WorkItem, :count).by(1)
expect(response).to have_gitlab_http_status(:success)
expect(widgets_response).to include(
{
'children' => { 'edges' => [] },
'parent' => { 'id' => parent.to_gid.to_s },
'type' => 'HIERARCHY'
}
)
expect(work_item.parent_link.relative_position).to be > adjacent.parent_link.relative_position
end
end
end
context 'when unsupported widget input is sent' do
let(:input) do
{
'title' => 'new title',
'description' => 'new description',
'workItemTypeId' => WorkItems::Type.default_by_type(:test_case).to_gid.to_s,
'hierarchyWidget' => {}
}
end
it_behaves_like 'a mutation that returns top-level errors',
errors: ['Following widget keys are not supported by Test Case type: [:hierarchy_widget]']
end
end
context 'with milestone widget input' do
let(:widgets_response) { mutation_response['workItem']['widgets'] }
let(:fields) do
<<~FIELDS
workItem {
widgets {
type
... on WorkItemWidgetMilestone {
milestone {
id
}
}
}
}
errors
FIELDS
end
context 'when setting milestone on work item creation' do
let_it_be(:project_milestone) { create(:milestone, project: project) }
let_it_be(:group_milestone) { create(:milestone, group: group) }
let(:input) do
{
title: 'some WI',
workItemTypeId: WorkItems::Type.default_by_type(:task).to_gid.to_s,
milestoneWidget: { 'milestoneId' => milestone.to_gid.to_s }
}
end
shared_examples "work item's milestone is set" do
it "sets the work item's milestone" do
expect do
post_graphql_mutation(mutation, current_user: current_user)
end.to change(WorkItem, :count).by(1)
expect(response).to have_gitlab_http_status(:success)
expect(widgets_response).to include(
{
'type' => 'MILESTONE',
'milestone' => { 'id' => milestone.to_gid.to_s }
}
)
end
end
context 'when assigning a project milestone' do
before do
group_work_item = container_params[:namespace].present?
skip('cannot set a project level milestone to a group level work item') if group_work_item
end
it_behaves_like "work item's milestone is set" do
let(:milestone) { project_milestone }
end
end
context 'when assigning a group milestone' do
it_behaves_like "work item's milestone is set" do
let(:milestone) { group_milestone }
end
end
end
end
end
context 'the user is not allowed to create a work item' do
let(:current_user) { create(:user) }
let(:mutation) { graphql_mutation(:workItemCreate, input.merge('projectPath' => project.full_path), fields) }
it_behaves_like 'a mutation that returns a top-level access error'
end
context 'when user has permissions to create a work item' do
context 'when creating work items in a project' do
context 'with projectPath' do
let_it_be(:container_params) { { project: project } }
let(:mutation) { graphql_mutation(:workItemCreate, input.merge('projectPath' => project.full_path), fields) }
it_behaves_like 'creates work item'
end
context 'with namespacePath' do
let_it_be(:container_params) { { project: project } }
let(:mutation) { graphql_mutation(:workItemCreate, input.merge('namespacePath' => project.full_path), fields) }
it_behaves_like 'creates work item'
context 'when the namespace_level_work_items feature flag is disabled' do
before do
stub_feature_flags(namespace_level_work_items: false)
end
it_behaves_like 'creates work item'
end
end
end
context 'when creating work items in a group' do
let_it_be(:container_params) { { namespace: group } }
let(:mutation) { graphql_mutation(:workItemCreate, input.merge(namespacePath: group.full_path), fields) }
it_behaves_like 'creates work item'
# This is a temporary measure just to ensure the internal id migration doesn't get conflicts
# More info in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/139367
context 'when making the request in a production environment' do
before do
stub_rails_env('production')
end
it_behaves_like 'a mutation that returns top-level errors', errors: [
'Group level work items are disabled. Only project paths allowed in `namespacePath`.'
]
end
context 'when the namespace_level_work_items feature flag is disabled' do
before do
stub_feature_flags(namespace_level_work_items: false)
end
it_behaves_like 'a mutation that returns top-level errors', errors: [
Mutations::WorkItems::Create::DISABLED_FF_ERROR
]
end
end
context 'when both projectPath and namespacePath are passed' do
let_it_be(:container_params) { { project: project } }
let(:mutation) do
graphql_mutation(
:workItemCreate,
input.merge('projectPath' => project.full_path, 'namespacePath' => project.full_path),
fields
)
end
it_behaves_like 'a mutation that returns top-level errors', errors: [
Mutations::WorkItems::Create::MUTUALLY_EXCLUSIVE_ARGUMENTS_ERROR
]
end
context 'when neither of projectPath nor namespacePath are passed' do
let_it_be(:container_params) { { project: project } }
let(:mutation) do
graphql_mutation(
:workItemCreate,
input,
fields
)
end
it_behaves_like 'a mutation that returns top-level errors', errors: [
Mutations::WorkItems::Create::MUTUALLY_EXCLUSIVE_ARGUMENTS_ERROR
]
end
end
end
|