1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe IdeController, feature_category: :web_ide do
include ContentSecurityPolicyHelpers
using RSpec::Parameterized::TableSyntax
let_it_be(:reporter) { create(:user) }
let_it_be(:project) do
create(:project, :private).tap do |p|
p.add_reporter(reporter)
end
end
let_it_be(:creator) { project.creator }
let_it_be(:other_user) { create(:user) }
let(:user) { creator }
before do
stub_feature_flags(vscode_web_ide: true)
sign_in(user)
end
describe '#index', :aggregate_failures do
subject { get route }
shared_examples 'user access rights check' do
context 'when user can read project' do
it 'increases the views counter' do
expect(Gitlab::UsageDataCounters::WebIdeCounter).to receive(:increment_views_count)
subject
end
context 'when user can read project but cannot push code' do
include ProjectForksHelper
let(:user) { reporter }
context 'when user does not have fork' do
it 'instantiates fork_info instance var with fork_path and returns 200' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:project)).to eq project
expect(assigns(:fork_info)).to eq({
fork_path: controller.helpers.ide_fork_and_edit_path(
project,
'',
'',
with_notice: false
)
})
end
it 'has nil fork_info if user cannot fork' do
project.project_feature.update!(forking_access_level: ProjectFeature::DISABLED)
subject
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:fork_info)).to be_nil
end
end
context 'when user has fork' do
let!(:fork) { fork_project(project, user, repository: true, namespace: user.namespace) }
it 'instantiates fork_info instance var with ide_path and returns 200' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:project)).to eq project
expect(assigns(:fork_info)).to eq({ ide_path: controller.helpers.ide_edit_path(fork, '', '') })
end
end
end
end
context 'when user cannot read project' do
let(:user) { other_user }
it 'returns 404' do
subject
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'with /-/ide' do
let(:route) { '/-/ide' }
it 'returns 404' do
subject
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'with /-/ide/project' do
let(:route) { '/-/ide/project' }
it 'returns 404' do
subject
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'with /-/ide/project/:project' do
let(:route) { "/-/ide/project/#{project.full_path}" }
it 'instantiates project instance var and returns 200' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:project)).to eq project
expect(assigns(:fork_info)).to be_nil
end
it_behaves_like 'user access rights check'
%w[edit blob tree].each do |action|
context "with /-/ide/project/:project/#{action}" do
let(:route) { "/-/ide/project/#{project.full_path}/#{action}" }
it 'instantiates project instance var and returns 200' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:project)).to eq project
expect(assigns(:fork_info)).to be_nil
end
it_behaves_like 'user access rights check'
end
end
describe 'Snowplow view event', :snowplow do
it 'is tracked' do
subject
expect_snowplow_event(
category: described_class.to_s,
action: 'web_ide_views',
namespace: project.namespace,
user: user
)
end
end
describe 'legacy Web IDE' do
before do
stub_feature_flags(vscode_web_ide: false)
end
it 'uses application layout' do
subject
expect(response).to render_template('layouts/application')
end
it 'does not create oauth application' do
expect(Doorkeeper::Application).not_to receive(:new)
subject
expect(web_ide_oauth_application).to be_nil
end
end
describe 'vscode IDE' do
before do
stub_feature_flags(vscode_web_ide: true)
end
it 'uses fullscreen layout' do
subject
expect(response).to render_template('layouts/fullscreen')
end
end
describe 'with web_ide_oauth flag off' do
before do
stub_feature_flags(web_ide_oauth: false)
end
it 'does not create oauth application' do
expect(Doorkeeper::Application).not_to receive(:new)
subject
expect(web_ide_oauth_application).to be_nil
end
end
it 'ensures web_ide_oauth_application' do
expect(Doorkeeper::Application).to receive(:new).and_call_original
subject
expect(web_ide_oauth_application).not_to be_nil
expect(web_ide_oauth_application[:name]).to eq('GitLab Web IDE')
end
it 'when web_ide_oauth_application already exists, does not create new one' do
existing_app = create(:oauth_application, owner_id: nil, owner_type: nil)
stub_application_setting({ web_ide_oauth_application: existing_app })
expect(Doorkeeper::Application).not_to receive(:new)
subject
expect(web_ide_oauth_application).to eq(existing_app)
end
end
describe 'content security policy' do
let(:route) { '/-/ide' }
it 'updates the content security policy with the correct frame sources' do
subject
expect(find_csp_directive('frame-src')).to include("http://www.example.com/assets/webpack/", "https://*.web-ide.gitlab-static.net/")
expect(find_csp_directive('worker-src')).to include("http://www.example.com/assets/webpack/")
end
it 'with relative_url_root, updates the content security policy with the correct frame sources' do
stub_config_setting(relative_url_root: '/gitlab')
subject
expect(find_csp_directive('frame-src')).to include("http://www.example.com/gitlab/assets/webpack/")
expect(find_csp_directive('worker-src')).to include("http://www.example.com/gitlab/assets/webpack/")
end
end
end
describe '#oauth_redirect', :aggregate_failures do
subject(:oauth_redirect) { get '/-/ide/oauth_redirect' }
it 'with no web_ide_oauth_application, returns not_found' do
oauth_redirect
expect(response).to have_gitlab_http_status(:not_found)
end
context 'with web_ide_oauth_application set' do
before do
stub_application_setting({
web_ide_oauth_application: create(:oauth_application, owner_id: nil, owner_type: nil)
})
end
it 'returns ok and renders view' do
oauth_redirect
expect(response).to have_gitlab_http_status(:ok)
end
it 'with vscode_web_ide flag off, returns not_found' do
stub_feature_flags(vscode_web_ide: false)
oauth_redirect
expect(response).to have_gitlab_http_status(:not_found)
end
it 'with web_ide_oauth flag off, returns not_found' do
stub_feature_flags(web_ide_oauth: false)
oauth_redirect
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
def web_ide_oauth_application
::Gitlab::CurrentSettings.current_application_settings.web_ide_oauth_application
end
end
|