spec/rubocop/cop/code_reuse/finder_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69

# frozen_string_literal: true

require 'rubocop_spec_helper'
require_relative '../../../../rubocop/cop/code_reuse/finder'

RSpec.describe RuboCop::Cop::CodeReuse::Finder do
  it 'flags the use of a Finder inside another Finder' do
    allow(cop)
      .to receive(:in_finder?)
      .and_return(true)

    expect_offense(<<~SOURCE)
      class FooFinder
        def execute
          BarFinder.new.execute
          ^^^^^^^^^^^^^ Finders can not be used inside a Finder.
        end
      end
    SOURCE
  end

  it 'flags the use of a Finder inside a model class method' do
    allow(cop)
      .to receive(:in_model?)
      .and_return(true)

    expect_offense(<<~SOURCE)
      class User
        class << self
          def second_method
            BarFinder.new
            ^^^^^^^^^^^^^ Finders can not be used inside model class methods.
          end
        end

        def self.second_method
          FooFinder.new
          ^^^^^^^^^^^^^ Finders can not be used inside model class methods.
        end
      end
    SOURCE
  end

  it 'does not flag the use of a Finder in a non Finder file' do
    expect_no_offenses(<<~SOURCE)
      class FooFinder
        def execute
          BarFinder.new.execute
        end
      end
    SOURCE
  end

  it 'does not flag the use of a Finder in a regular class method' do
    expect_no_offenses(<<~SOURCE)
      class User
        class << self
          def second_method
            BarFinder.new
          end
        end

        def self.second_method
          FooFinder.new
        end
      end
    SOURCE
  end
end