blob: b018e743230f906f773c7744a7a2bf06acf18272 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
|
# frozen_string_literal: true
require 'fast_spec_helper'
require 'rubocop'
require 'rubocop/rspec/support'
require_relative '../../../../rubocop/cop/code_reuse/service_class'
RSpec.describe RuboCop::Cop::CodeReuse::ServiceClass, type: :rubocop do
include CopHelper
subject(:cop) { described_class.new }
it 'flags the use of a Service class in a Finder' do
allow(cop)
.to receive(:in_finder?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooFinder
def execute
FooService.new.execute
^^^^^^^^^^^^^^ Service classes can not be used in a Finder.
end
end
SOURCE
end
it 'flags the use of a Service class in a Presenter' do
allow(cop)
.to receive(:in_presenter?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooPresenter
def execute
FooService.new.execute
^^^^^^^^^^^^^^ Service classes can not be used in a Presenter.
end
end
SOURCE
end
it 'flags the use of a Service class in a Serializer' do
allow(cop)
.to receive(:in_serializer?)
.and_return(true)
expect_offense(<<~SOURCE)
class FooSerializer
def execute
FooService.new.execute
^^^^^^^^^^^^^^ Service classes can not be used in a Serializer.
end
end
SOURCE
end
it 'flags the use of a Service class in a model' do
allow(cop)
.to receive(:in_model?)
.and_return(true)
expect_offense(<<~SOURCE)
class User < ActiveRecord::Model
class << self
def first
FooService.new.execute
^^^^^^^^^^^^^^ Service classes can not be used in a model.
end
end
def second
FooService.new.execute
^^^^^^^^^^^^^^ Service classes can not be used in a model.
end
end
SOURCE
end
it 'does not flag the use of a Service class in a regular class' do
expect_no_offenses(<<~SOURCE)
class Foo
def execute
FooService.new.execute
end
end
SOURCE
end
end
|
