blob: 7c692d5aad4cf8465734b796056fec3bc1f7da39 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
|
# frozen_string_literal: true
require 'rubocop_spec_helper'
require_relative '../../../../rubocop/cop/gitlab/event_store_subscriber'
RSpec.describe RuboCop::Cop::Gitlab::EventStoreSubscriber do
context 'when an event store subscriber overrides #perform' do
it 'registers an offense' do
expect_offense(<<~WORKER)
class SomeWorker
include Gitlab::EventStore::Subscriber
def perform(*args)
^^^^^^^^^^^^^^^^^^ Do not override `perform` in a `Gitlab::EventStore::Subscriber`.
end
def handle_event(event); end
end
WORKER
end
end
context 'when an event store subscriber does not override #perform' do
it 'does not register an offense' do
expect_no_offenses(<<~WORKER)
class SomeWorker
include Gitlab::EventStore::Subscriber
def handle_event(event); end
end
WORKER
end
end
context 'when an event store subscriber does not implement #handle_event' do
it 'registers an offense' do
expect_offense(<<~WORKER)
class SomeWorker
include Gitlab::EventStore::Subscriber
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ A `Gitlab::EventStore::Subscriber` must implement `#handle_event(event)`.
end
WORKER
end
end
context 'when a Sidekiq worker overrides #perform' do
it 'does not register an offense' do
expect_no_offenses(<<~WORKER)
class SomeWorker
include ApplicationWorker
def perform(*args); end
end
WORKER
end
end
context 'when a Sidekiq worker implements #handle_event' do
it 'does not register an offense' do
expect_no_offenses(<<~WORKER)
class SomeWorker
include ApplicationWorker
def handle_event(event); end
end
WORKER
end
end
context 'a non worker class' do
it 'does not register an offense' do
expect_no_offenses(<<~MODEL)
class Model < ApplicationRecord
include ActiveSupport::Concern
end
MODEL
end
end
end
|
