spec/rubocop/cop/migration/remove_column_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56

# frozen_string_literal: true

require 'rubocop_spec_helper'
require_relative '../../../../rubocop/cop/migration/remove_column'

RSpec.describe RuboCop::Cop::Migration::RemoveColumn do
  def source(meth = 'change')
    "def #{meth}; remove_column :table, :column; end"
  end

  context 'when in a regular migration' do
    before do
      allow(cop).to receive(:in_migration?).and_return(true)
      allow(cop).to receive(:in_post_deployment_migration?).and_return(false)
    end

    it 'registers an offense when remove_column is used in the change method' do
      expect_offense(<<~RUBY)
        def change
          remove_column :table, :column
          ^^^^^^^^^^^^^ `remove_column` must only be used in post-deployment migrations
        end
      RUBY
    end

    it 'registers an offense when remove_column is used in the up method' do
      expect_offense(<<~RUBY)
        def up
          remove_column :table, :column
          ^^^^^^^^^^^^^ `remove_column` must only be used in post-deployment migrations
        end
      RUBY
    end

    it 'registers no offense when remove_column is used in the down method' do
      expect_no_offenses(source('down'))
    end
  end

  context 'when in a post-deployment migration' do
    before do
      allow(cop).to receive(:in_migration?).and_return(true)
      allow(cop).to receive(:in_post_deployment_migration?).and_return(true)
    end

    it 'registers no offense' do
      expect_no_offenses(source)
    end
  end

  context 'when outside of a migration' do
    it 'registers no offense' do
      expect_no_offenses(source)
    end
  end
end