blob: 5762f78820c1d4e6b286757e5e5ae1287faf73d3 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
|
# frozen_string_literal: true
require 'rubocop_spec_helper'
require_relative '../../../../rubocop/cop/migration/with_lock_retries_disallowed_method'
RSpec.describe RuboCop::Cop::Migration::WithLockRetriesDisallowedMethod do
context 'when in migration' do
before do
allow(cop).to receive(:in_migration?).and_return(true)
end
it 'registers an offense when `with_lock_retries` block has disallowed method' do
expect_offense(<<~RUBY)
def change
with_lock_retries { disallowed_method }
^^^^^^^^^^^^^^^^^ The method is not allowed [...]
end
RUBY
end
it 'registers an offense when `with_lock_retries` block has disallowed methods' do
expect_offense(<<~RUBY)
def change
with_lock_retries do
disallowed_method
^^^^^^^^^^^^^^^^^ The method is not allowed [...]
create_table do |t|
t.text :text
end
other_disallowed_method
^^^^^^^^^^^^^^^^^^^^^^^ The method is not allowed [...]
add_column :users, :name
end
end
RUBY
end
it 'registers no offense when `with_lock_retries` has only allowed method' do
expect_no_offenses(<<~RUBY)
def up
with_lock_retries { add_foreign_key :foo, :bar }
end
RUBY
end
describe 'for `add_foreign_key`' do
it 'registers an offense when more than two FKs are added' do
message = described_class::MSG_ONLY_ONE_FK_ALLOWED
expect_offense(<<~RUBY)
with_lock_retries do
add_foreign_key :imports, :projects, column: :project_id, on_delete: :cascade
^^^^^^^^^^^^^^^ #{message}
add_column :projects, :name, :text
add_foreign_key :imports, :users, column: :user_id, on_delete: :cascade
^^^^^^^^^^^^^^^ #{message}
end
RUBY
end
end
end
context 'when outside of migration' do
it 'registers no offense' do
expect_no_offenses(<<~RUBY)
def change
with_lock_retries { disallowed_method }
end
RUBY
end
end
end
|
