1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe MergeRequests::RequestReviewService, feature_category: :code_review_workflow do
let(:current_user) { create(:user) }
let(:user) { create(:user) }
let(:merge_request) { create(:merge_request, reviewers: [user]) }
let(:reviewer) { merge_request.find_reviewer(user) }
let(:project) { merge_request.project }
let(:service) { described_class.new(project: project, current_user: current_user) }
let(:result) { service.execute(merge_request, user) }
let(:todo_service) { spy('todo service') }
let(:notification_service) { spy('notification service') }
before do
allow(NotificationService).to receive(:new) { notification_service }
allow(service).to receive(:todo_service).and_return(todo_service)
allow(service).to receive(:notification_service).and_return(notification_service)
reviewer.update!(state: MergeRequestReviewer.states[:reviewed])
project.add_developer(current_user)
project.add_developer(user)
end
describe '#execute' do
shared_examples_for 'failed service execution' do
it 'returns an error' do
expect(result[:status]).to eq :error
end
it_behaves_like 'does not trigger GraphQL subscription mergeRequestReviewersUpdated' do
let(:action) { result }
end
end
describe 'invalid permissions' do
let(:service) { described_class.new(project: project, current_user: create(:user)) }
it_behaves_like 'failed service execution'
end
describe 'reviewer does not exist' do
let(:result) { service.execute(merge_request, create(:user)) }
it_behaves_like 'failed service execution'
end
describe 'reviewer exists' do
it 'returns success' do
expect(result[:status]).to eq :success
end
it 'updates reviewers state' do
service.execute(merge_request, user)
reviewer.reload
expect(reviewer.state).to eq 'unreviewed'
end
it 'sends email to reviewer' do
expect(notification_service).to receive_message_chain(:async, :review_requested_of_merge_request).with(merge_request, current_user, user)
service.execute(merge_request, user)
end
it 'creates a new todo for the reviewer' do
expect(todo_service).to receive(:create_request_review_todo).with(merge_request, current_user, user)
service.execute(merge_request, user)
end
it 'creates a sytem note' do
expect(SystemNoteService)
.to receive(:request_review)
.with(merge_request, project, current_user, user)
service.execute(merge_request, user)
end
it_behaves_like 'triggers GraphQL subscription mergeRequestReviewersUpdated' do
let(:action) { result }
end
end
end
end
|
