1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ::Ml::CreateModelVersionService, feature_category: :mlops do
let(:model) { create(:ml_models) }
let(:params) { {} }
before do
allow(Gitlab::InternalEvents).to receive(:track_event)
end
subject(:service) { described_class.new(model, params).execute }
context 'when no versions exist' do
it 'creates a model version', :aggregate_failures do
expect { service }.to change { Ml::ModelVersion.count }.by(1).and change { Ml::Candidate.count }.by(1)
expect(model.reload.latest_version.version).to eq('1.0.0')
expect(Gitlab::InternalEvents).to have_received(:track_event).with(
'model_registry_ml_model_version_created',
{ project: model.project, user: nil }
)
end
end
context 'when a version exist' do
before do
create(:ml_model_versions, model: model, version: '3.0.0')
end
it 'creates another model version and increments the version number', :aggregate_failures do
expect { service }.to change { Ml::ModelVersion.count }.by(1).and change { Ml::Candidate.count }.by(1)
expect(model.reload.latest_version.version).to eq('4.0.0')
expect(Gitlab::InternalEvents).to have_received(:track_event).with(
'model_registry_ml_model_version_created',
{ project: model.project, user: nil }
)
end
end
context 'when a version is created' do
it 'creates a package' do
expect { service }.to change { Ml::ModelVersion.count }.by(1).and change {
Packages::MlModel::Package.count
}.by(1)
expect(model.reload.latest_version.package.name).to eq(model.name)
expect(model.latest_version.package.version).to eq(model.latest_version.version)
end
end
context 'when a version is created and the package already exists' do
it 'does not creates a package' do
next_version = Ml::IncrementVersionService.new(model.latest_version.try(:version)).execute
create(:ml_model_package, name: model.name, version: next_version, project: model.project)
expect { service }.to change { Ml::ModelVersion.count }.by(1).and not_change {
Packages::MlModel::Package.count
}
expect(model.reload.latest_version.package.name).to eq(model.name)
expect(model.latest_version.package.version).to eq(model.latest_version.version)
end
end
context 'when a version is created and an existing package supplied' do
it 'does not creates a package' do
next_version = Ml::IncrementVersionService.new(model.latest_version.try(:version)).execute
package = create(:ml_model_package, name: model.name, version: next_version, project: model.project)
service = described_class.new(model, { package: package })
expect { service.execute }.to change { Ml::ModelVersion.count }.by(1).and not_change {
Packages::MlModel::Package.count
}
expect(model.reload.latest_version.package.name).to eq(model.name)
expect(model.latest_version.package.version).to eq(model.latest_version.version)
end
context 'when metadata are supplied, add them as metadata' do
let(:metadata) { [{ key: 'key1', value: 'value1' }, { key: 'key2', value: 'value2' }] }
let(:params) { { metadata: metadata } }
it 'creates metadata records', :aggregate_failures do
expect { service }.to change { Ml::ModelVersion.count }.by(1)
expect(service.metadata.count).to be 2
end
end
# TODO: Ensure consisted error responses https://gitlab.com/gitlab-org/gitlab/-/issues/429731
context 'for metadata with duplicate keys, it does not create duplicate records' do
let(:metadata) { [{ key: 'key1', value: 'value1' }, { key: 'key1', value: 'value2' }] }
let(:params) { { metadata: metadata } }
it 'raises an error', :aggregate_failures do
expect { service }.to raise_error(ActiveRecord::RecordInvalid)
end
end
# # TODO: Ensure consisted error responses https://gitlab.com/gitlab-org/gitlab/-/issues/429731
context 'for metadata with invalid keys, it does not create invalid records' do
let(:metadata) { [{ key: 'key1', value: 'value1' }, { key: '', value: 'value2' }] }
let(:params) { { metadata: metadata } }
it 'raises an error', :aggregate_failures do
expect { service }.to raise_error(ActiveRecord::RecordInvalid)
end
end
end
end
|