Welcome to mirror list, hosted at ThFree Co, Russian Federation.

member_shared_examples.rb « models « shared_examples « support « spec - gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
blob: d5d137922eb365208622f7e032b8e5d372013cd2 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
# frozen_string_literal: true

RSpec.shared_examples 'inherited access level as a member of entity' do
  let(:parent_entity) { create(:group) }
  let(:user) { create(:user) }
  let(:member) { entity.is_a?(Group) ? entity.group_member(user) : entity.project_member(user) }

  context 'with root parent_entity developer member' do
    before do
      parent_entity.add_developer(user)
    end

    it 'is allowed to be a maintainer of the entity' do
      entity.add_maintainer(user)

      expect(member.access_level).to eq(Gitlab::Access::MAINTAINER)
    end

    it 'is not allowed to be a reporter of the entity' do
      entity.add_reporter(user)

      expect(member).to be_nil
    end

    it 'is allowed to change to be a developer of the entity' do
      entity.add_maintainer(user)

      expect { member.update!(access_level: Gitlab::Access::DEVELOPER) }
        .to change { member.access_level }.to(Gitlab::Access::DEVELOPER)
    end

    it 'is not allowed to change to be a guest of the entity' do
      entity.add_maintainer(user)

      expect { member.update(access_level: Gitlab::Access::GUEST) } # rubocop:disable Rails/SaveBang
        .not_to change { member.reload.access_level }
    end

    it "shows an error if the member can't be updated" do
      entity.add_maintainer(user)

      expect { member.update!(access_level: Gitlab::Access::REPORTER) }.to raise_error(ActiveRecord::RecordInvalid)

      expect(member.errors.full_messages).to eq(["Access level should be greater than or equal to Developer inherited membership from group #{parent_entity.name}"])
    end

    it 'allows changing the level from a non existing member' do
      non_member_user = create(:user)

      entity.add_maintainer(non_member_user)

      non_member = entity.is_a?(Group) ? entity.group_member(non_member_user) : entity.project_member(non_member_user)

      expect { non_member.update!(access_level: Gitlab::Access::GUEST) }
        .to change { non_member.reload.access_level }
    end
  end
end

RSpec.shared_examples '#valid_level_roles' do |entity_name|
  let(:member_user) { create(:user) }
  let(:group) { create(:group) }
  let(:entity) { create(entity_name) } # rubocop:disable Rails/SaveBang
  let(:entity_member) { create("#{entity_name}_member", :developer, source: entity, user: member_user) }
  let(:presenter) { described_class.new(entity_member, current_user: member_user) }
  let(:expected_roles) { { 'Developer' => 30, 'Maintainer' => 40, 'Reporter' => 20 } }

  it 'returns all roles when no parent member is present' do
    expect(presenter.valid_level_roles).to eq(entity_member.class.access_level_roles)
  end

  it 'returns higher roles when a parent member is present' do
    group.add_reporter(member_user)

    expect(presenter.valid_level_roles).to eq(expected_roles)
  end
end

RSpec.shared_examples_for "member creation" do
  let_it_be(:user) { create(:user) }
  let_it_be(:admin) { create(:admin) }

  describe '#execute' do
    it 'returns a Member object', :aggregate_failures do
      member = described_class.new(source, user, :maintainer).execute

      expect(member).to be_a member_type
      expect(member).to be_persisted
    end

    context 'when admin mode is enabled', :enable_admin_mode do
      it 'sets members.created_by to the given admin current_user' do
        member = described_class.new(source, user, :maintainer, current_user: admin).execute

        expect(member.created_by).to eq(admin)
      end
    end

    context 'when admin mode is disabled' do
      it 'rejects setting members.created_by to the given admin current_user' do
        member = described_class.new(source, user, :maintainer, current_user: admin).execute

        expect(member.created_by).to be_nil
      end
    end

    it 'sets members.expires_at to the given expires_at' do
      member = described_class.new(source, user, :maintainer, expires_at: Date.new(2016, 9, 22)).execute

      expect(member.expires_at).to eq(Date.new(2016, 9, 22))
    end

    described_class.access_levels.each do |sym_key, int_access_level|
      it "accepts the :#{sym_key} symbol as access level", :aggregate_failures do
        expect(source.users).not_to include(user)

        member = described_class.new(source, user.id, sym_key).execute

        expect(member.access_level).to eq(int_access_level)
        expect(source.users.reload).to include(user)
      end

      it "accepts the #{int_access_level} integer as access level", :aggregate_failures do
        expect(source.users).not_to include(user)

        member = described_class.new(source, user.id, int_access_level).execute

        expect(member.access_level).to eq(int_access_level)
        expect(source.users.reload).to include(user)
      end
    end

    context 'with no current_user' do
      context 'when called with a known user id' do
        it 'adds the user as a member' do
          expect(source.users).not_to include(user)

          described_class.new(source, user.id, :maintainer).execute

          expect(source.users.reload).to include(user)
        end
      end

      context 'when called with an unknown user id' do
        it 'adds the user as a member' do
          expect(source.users).not_to include(user)

          described_class.new(source, non_existing_record_id, :maintainer).execute

          expect(source.users.reload).not_to include(user)
        end
      end

      context 'when called with a user object' do
        it 'adds the user as a member' do
          expect(source.users).not_to include(user)

          described_class.new(source, user, :maintainer).execute

          expect(source.users.reload).to include(user)
        end
      end

      context 'when called with a requester user object' do
        before do
          source.request_access(user)
        end

        it 'adds the requester as a member', :aggregate_failures do
          expect(source.users).not_to include(user)
          expect(source.requesters.exists?(user_id: user)).to be_truthy

          expect do
            described_class.new(source, user, :maintainer).execute
          end.to raise_error(Gitlab::Access::AccessDeniedError)

          expect(source.users.reload).not_to include(user)
          expect(source.requesters.reload.exists?(user_id: user)).to be_truthy
        end
      end

      context 'when called with a known user email' do
        it 'adds the user as a member' do
          expect(source.users).not_to include(user)

          described_class.new(source, user.email, :maintainer).execute

          expect(source.users.reload).to include(user)
        end
      end

      context 'when called with an unknown user email' do
        it 'creates an invited member' do
          expect(source.users).not_to include(user)

          described_class.new(source, 'user@example.com', :maintainer).execute

          expect(source.members.invite.pluck(:invite_email)).to include('user@example.com')
        end
      end

      context 'when called with an unknown user email starting with a number' do
        it 'creates an invited member', :aggregate_failures do
          email_starting_with_number = "#{user.id}_email@example.com"

          described_class.new(source, email_starting_with_number, :maintainer).execute

          expect(source.members.invite.pluck(:invite_email)).to include(email_starting_with_number)
          expect(source.users.reload).not_to include(user)
        end
      end
    end

    context 'when current_user can update member', :enable_admin_mode do
      it 'creates the member' do
        expect(source.users).not_to include(user)

        described_class.new(source, user, :maintainer, current_user: admin).execute

        expect(source.users.reload).to include(user)
      end

      context 'when called with a requester user object' do
        before do
          source.request_access(user)
        end

        it 'adds the requester as a member', :aggregate_failures do
          expect(source.users).not_to include(user)
          expect(source.requesters.exists?(user_id: user)).to be_truthy

          described_class.new(source, user, :maintainer, current_user: admin).execute

          expect(source.users.reload).to include(user)
          expect(source.requesters.reload.exists?(user_id: user)).to be_falsy
        end
      end
    end

    context 'when current_user cannot update member' do
      it 'does not create the member', :aggregate_failures do
        expect(source.users).not_to include(user)

        member = described_class.new(source, user, :maintainer, current_user: user).execute

        expect(source.users.reload).not_to include(user)
        expect(member).not_to be_persisted
      end

      context 'when called with a requester user object' do
        before do
          source.request_access(user)
        end

        it 'does not destroy the requester', :aggregate_failures do
          expect(source.users).not_to include(user)
          expect(source.requesters.exists?(user_id: user)).to be_truthy

          described_class.new(source, user, :maintainer, current_user: user).execute

          expect(source.users.reload).not_to include(user)
          expect(source.requesters.exists?(user_id: user)).to be_truthy
        end
      end
    end

    context 'when member already exists' do
      before do
        source.add_user(user, :developer)
      end

      context 'with no current_user' do
        it 'updates the member' do
          expect(source.users).to include(user)

          described_class.new(source, user, :maintainer).execute

          expect(source.members.find_by(user_id: user).access_level).to eq(Gitlab::Access::MAINTAINER)
        end
      end

      context 'when current_user can update member', :enable_admin_mode do
        it 'updates the member' do
          expect(source.users).to include(user)

          described_class.new(source, user, :maintainer, current_user: admin).execute

          expect(source.members.find_by(user_id: user).access_level).to eq(Gitlab::Access::MAINTAINER)
        end
      end

      context 'when current_user cannot update member' do
        it 'does not update the member' do
          expect(source.users).to include(user)

          described_class.new(source, user, :maintainer, current_user: user).execute

          expect(source.members.find_by(user_id: user).access_level).to eq(Gitlab::Access::DEVELOPER)
        end
      end
    end

    context 'when `tasks_to_be_done` and `tasks_project_id` are passed' do
      it 'creates a member_task with the correct attributes', :aggregate_failures do
        task_project = source.is_a?(Group) ? create(:project, group: source) : source
        described_class.new(source, user, :developer, tasks_to_be_done: %w(ci code), tasks_project_id: task_project.id).execute

        member = source.members.last

        expect(member.tasks_to_be_done).to match_array([:ci, :code])
        expect(member.member_task.project).to eq(task_project)
      end
    end
  end
end

RSpec.shared_examples_for "bulk member creation" do
  let_it_be(:user) { create(:user) }
  let_it_be(:admin) { create(:admin) }

  describe '#execute' do
    it 'raises an error when exiting_members is not passed in the args hash' do
      expect do
        described_class.new(source, user, :maintainer, current_user: user).execute
      end.to raise_error(ArgumentError, 'existing_members must be included in the args hash')
    end
  end

  describe '.add_users', :aggregate_failures do
    let_it_be(:user1) { create(:user) }
    let_it_be(:user2) { create(:user) }

    it 'returns a Member objects' do
      members = described_class.add_users(source, [user1, user2], :maintainer)

      expect(members).to be_a Array
      expect(members.size).to eq(2)
      expect(members).to all(be_a(member_type))
      expect(members).to all(be_persisted)
    end

    it 'returns an empty array' do
      members = described_class.add_users(source, [], :maintainer)

      expect(members).to be_a Array
      expect(members).to be_empty
    end

    it 'supports different formats' do
      list = ['joe@local.test', admin, user1.id, user2.id.to_s]

      members = described_class.add_users(source, list, :maintainer)

      expect(members.size).to eq(4)
      expect(members.first).to be_invite
    end

    context 'with de-duplication' do
      it 'with the same user by id and user' do
        members = described_class.add_users(source, [user1.id, user1, user1.id, user2, user2.id, user2], :maintainer)

        expect(members).to be_a Array
        expect(members.size).to eq(2)
        expect(members).to all(be_a(member_type))
        expect(members).to all(be_persisted)
      end

      it 'with the same user sent more than once' do
        members = described_class.add_users(source, [user1, user1], :maintainer)

        expect(members).to be_a Array
        expect(members.size).to eq(1)
        expect(members).to all(be_a(member_type))
        expect(members).to all(be_persisted)
      end
    end

    context 'when a member already exists' do
      before do
        source.add_user(user1, :developer)
      end

      it 'supports existing users as expected' do
        user3 = create(:user)

        members = described_class.add_users(source, [user1.id, user2, user3.id], :maintainer)

        expect(members).to be_a Array
        expect(members.size).to eq(3)
        expect(members).to all(be_a(member_type))
        expect(members).to all(be_persisted)
      end
    end

    context 'when `tasks_to_be_done` and `tasks_project_id` are passed' do
      it 'creates a member_task with the correct attributes', :aggregate_failures do
        task_project = source.is_a?(Group) ? create(:project, group: source) : source
        members = described_class.add_users(source, [user1], :developer, tasks_to_be_done: %w(ci code), tasks_project_id: task_project.id)
        member = members.last

        expect(member.tasks_to_be_done).to match_array([:ci, :code])
        expect(member.member_task.project).to eq(task_project)
      end
    end
  end
end