diff options
author | ngala <ngala@gitlab.com> | 2024-01-24 12:46:50 +0300 |
---|---|---|
committer | ngala <ngala@gitlab.com> | 2024-01-24 12:46:50 +0300 |
commit | e5611d02989b8a94b556e0630ed0826b3453a4bd (patch) | |
tree | b577312c72dc6729c4c6df3b3d6bfe8ee9179123 | |
parent | bc8e55a3e6592001f8e29b58bc32b74c7e768d51 (diff) |
Address Quality Findingngala/ratelimit-ip-close-http-connection
-rw-r--r-- | internal/ratelimiter/middleware_test.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/internal/ratelimiter/middleware_test.go b/internal/ratelimiter/middleware_test.go index 4d3e01be..a410b8b8 100644 --- a/internal/ratelimiter/middleware_test.go +++ b/internal/ratelimiter/middleware_test.go @@ -49,7 +49,7 @@ func TestMiddlewareWithDifferentLimits(t *testing.T) { // always returns the same time require.Equal(t, http.StatusTooManyRequests, code, "req: %d failed", i) require.Contains(t, body, "Too many requests.") - assertSourceIPLog(t, remoteAddr, hook) + assertSourceIPLog(t, hook) } } }) @@ -95,7 +95,7 @@ func TestMiddlewareDenyRequestsAfterBurst(t *testing.T) { // burst is 1 and limit is 1 per second, all subsequent requests should fail require.Equal(t, tc.expectedStatus, code) - assertSourceIPLog(t, remoteAddr, hook) + assertSourceIPLog(t, hook) } blockedCount := testutil.ToFloat64(blocked.WithLabelValues("rate_limiter")) @@ -143,7 +143,7 @@ func TestMiddlewareWithDifferentLimitsWithFFCloseConnectionEnabled(t *testing.T) require.Equal(t, http.StatusTooManyRequests, code, "req: %d failed", i) require.Contains(t, body, "Too many requests.") require.Equal(t, "close", header.Get("Connection"), "req: %d connection closed", i) - assertSourceIPLog(t, remoteAddr, hook) + assertSourceIPLog(t, hook) } } }) @@ -193,7 +193,7 @@ func TestMiddlewareDenyRequestsAfterBurstWithFFCloseConnectionEnabled(t *testing // burst is 1 and limit is 1 per second, all subsequent requests should fail require.Equal(t, tc.expectedStatus, code) require.Equal(t, tc.expectedConnectionHeader, header.Get("Connection")) - assertSourceIPLog(t, remoteAddr, hook) + assertSourceIPLog(t, hook) } blockedCount := testutil.ToFloat64(blocked.WithLabelValues("rate_limiter")) @@ -296,7 +296,7 @@ func TestKeyFunc(t *testing.T) { } } -func assertSourceIPLog(t *testing.T, remoteAddr string, hook *testlog.Hook) { +func assertSourceIPLog(t *testing.T, hook *testlog.Hook) { t.Helper() require.NotNil(t, hook.LastEntry()) |