Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-pages.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorfeistel <6742251-feistel@users.noreply.gitlab.com>2021-10-01 15:00:51 +0300
committerfeistel <6742251-feistel@users.noreply.gitlab.com>2021-10-01 15:00:51 +0300
commit353564226f27a4edbb11156ccaed05bece1ef0a3 (patch)
treede345eac893276c4dba1a4030be731fe89e7c8bf
parentd2d064a81e8b69efeb4ea60cd65c9e6a49ff7a9c (diff)
test: simplify assertion
replace require.Equal with require.False/True
-rw-r--r--internal/auth/auth_test.go16
1 files changed, 8 insertions, 8 deletions
diff --git a/internal/auth/auth_test.go b/internal/auth/auth_test.go
index ff95183c..6df0afcc 100644
--- a/internal/auth/auth_test.go
+++ b/internal/auth/auth_test.go
@@ -87,7 +87,7 @@ func TestTryAuthenticate(t *testing.T) {
defer mockCtrl.Finish()
mockSource := mocks.NewMockSource(mockCtrl)
- require.Equal(t, false, auth.TryAuthenticate(result, r, mockSource))
+ require.False(t, auth.TryAuthenticate(result, r, mockSource))
}
func TestTryAuthenticateWithError(t *testing.T) {
@@ -104,7 +104,7 @@ func TestTryAuthenticateWithError(t *testing.T) {
defer mockCtrl.Finish()
mockSource := mocks.NewMockSource(mockCtrl)
- require.Equal(t, true, auth.TryAuthenticate(result, r, mockSource))
+ require.True(t, auth.TryAuthenticate(result, r, mockSource))
require.Equal(t, http.StatusUnauthorized, result.Code)
}
@@ -127,7 +127,7 @@ func TestTryAuthenticateWithCodeButInvalidState(t *testing.T) {
defer mockCtrl.Finish()
mockSource := mocks.NewMockSource(mockCtrl)
- require.Equal(t, true, auth.TryAuthenticate(result, r, mockSource))
+ require.True(t, auth.TryAuthenticate(result, r, mockSource))
require.Equal(t, http.StatusUnauthorized, result.Code)
}
@@ -153,7 +153,7 @@ func TestTryAuthenticateRemoveTokenFromRedirect(t *testing.T) {
defer mockCtrl.Finish()
mockSource := mocks.NewMockSource(mockCtrl)
- require.Equal(t, true, auth.TryAuthenticate(result, r, mockSource))
+ require.True(t, auth.TryAuthenticate(result, r, mockSource))
require.Equal(t, http.StatusFound, result.Code)
redirect, err := url.Parse(result.Header().Get("Location"))
@@ -173,7 +173,7 @@ func TestTryAuthenticateWithDomainAndState(t *testing.T) {
defer mockCtrl.Finish()
mockSource := mocks.NewMockSource(mockCtrl)
- require.Equal(t, true, auth.TryAuthenticate(result, r, mockSource))
+ require.True(t, auth.TryAuthenticate(result, r, mockSource))
require.Equal(t, http.StatusFound, result.Code)
redirect, err := url.Parse(result.Header().Get("Location"))
require.NoError(t, err)
@@ -234,7 +234,7 @@ func testTryAuthenticateWithCodeAndState(t *testing.T, https bool) {
defer mockCtrl.Finish()
mockSource := mocks.NewMockSource(mockCtrl)
- require.Equal(t, true, auth.TryAuthenticate(result, r, mockSource))
+ require.True(t, auth.TryAuthenticate(result, r, mockSource))
res := result.Result()
defer res.Body.Close()
@@ -500,7 +500,7 @@ func TestCheckResponseForInvalidTokenWhenInvalidToken(t *testing.T) {
resp := &http.Response{StatusCode: http.StatusUnauthorized, Body: io.NopCloser(bytes.NewReader([]byte("{\"error\":\"invalid_token\"}")))}
defer resp.Body.Close()
- require.Equal(t, true, auth.CheckResponseForInvalidToken(result, r, resp))
+ require.True(t, auth.CheckResponseForInvalidToken(result, r, resp))
res := result.Result()
defer res.Body.Close()
require.Equal(t, http.StatusFound, res.StatusCode)
@@ -517,5 +517,5 @@ func TestCheckResponseForInvalidTokenWhenNotInvalidToken(t *testing.T) {
resp := &http.Response{StatusCode: http.StatusOK, Body: io.NopCloser(bytes.NewReader([]byte("ok")))}
- require.Equal(t, false, auth.CheckResponseForInvalidToken(result, r, resp))
+ require.False(t, auth.CheckResponseForInvalidToken(result, r, resp))
}