Properly handle processing failures with `5xx`

Prior to this change ALL processing failures
unrelated to "file missing" would return `404`.

This is inaccurate.

Processing failures are failure of GitLab Pages
and `500` should be returned in such cases.

1 files changed, 14 insertions, 0 deletions

diff --git a/internal/httperrors/httperrors.go b/internal/httperrors/httperrors.go
index 1ae5224b..476d270c 100644
--- a/internal/httperrors/httperrors.go
+++ b/internal/httperrors/httperrors.go
@@ -3,6 +3,10 @@ package httperrors
 import (
 	"fmt"
 	"net/http"
+
+	log "github.com/sirupsen/logrus"
+
+	"gitlab.com/gitlab-org/labkit/errortracking"
 )
 
 type content struct {
@@ -177,6 +181,16 @@ func Serve500(w http.ResponseWriter) {
 	serveErrorPage(w, content500)
 }
 
+// Serve500WithRequest returns a 500 error response / HTML page to the http.ResponseWriter
+func Serve500WithRequest(w http.ResponseWriter, r *http.Request, reason string, err error) {
+	log.WithFields(log.Fields{
+		"host": r.Host,
+		"path": r.URL.Path,
+	}).WithError(err).Error(reason)
+	errortracking.Capture(err, errortracking.WithRequest(r))
+	serveErrorPage(w, content500)
+}
+
 // Serve502 returns a 502 error response / HTML page to the http.ResponseWriter
 func Serve502(w http.ResponseWriter) {
 	serveErrorPage(w, content502)