1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
|
// Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package symlink_test
import (
"context"
"io/ioutil"
"os"
"path/filepath"
"runtime"
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitlab-pages/internal/serving/disk/symlink"
"gitlab.com/gitlab-org/gitlab-pages/internal/testhelpers"
"gitlab.com/gitlab-org/gitlab-pages/internal/vfs"
"gitlab.com/gitlab-org/gitlab-pages/internal/vfs/local"
)
var fs = vfs.Instrumented(&local.VFS{})
type EvalSymlinksTest struct {
// If dest is empty, the path is created; otherwise the dest is symlinked to the path.
path, dest string
}
var EvalSymlinksTestDirs = []EvalSymlinksTest{
{"test", ""},
{"test/dir", ""},
{"test/dir/link3", "../../"},
{"test/link1", "../test"},
{"test/link2", "dir"},
{"test/linkabs", "/"},
{"test/link4", "../test2"},
{"test2", "test/dir"},
// Issue 23444.
{"src", ""},
{"src/pool", ""},
{"src/pool/test", ""},
{"src/versions", ""},
{"src/versions/current", "../../version"},
{"src/versions/v1", ""},
{"src/versions/v1/modules", ""},
{"src/versions/v1/modules/test", "../../../pool/test"},
{"version", "src/versions/v1"},
}
var EvalSymlinksTests = []EvalSymlinksTest{
{"test", "test"},
{"test/dir", "test/dir"},
{"test/dir/../..", "."},
{"test/link1", "test"},
{"test/link2", "test/dir"},
{"test/link1/dir", "test/dir"},
{"test/link2/..", "test"},
{"test/dir/link3", "."},
{"test/link2/link3/test", "test"},
{"test/linkabs", "/"},
{"test/link4/..", "test"},
{"src/versions/current/modules/test", "src/pool/test"},
}
// simpleJoin builds a file name from the directory and path.
// It does not use Join because we don't want ".." to be evaluated.
func simpleJoin(path ...string) string {
return strings.Join(path, string(filepath.Separator))
}
func testEvalSymlinks(t *testing.T, wd, path, want string) {
root, err := fs.Root(context.Background(), wd)
require.NoError(t, err)
have, err := symlink.EvalSymlinks(context.Background(), root, path)
if err != nil {
t.Errorf("EvalSymlinks(%q) error: %v", path, err)
return
}
if filepath.Clean(have) != filepath.Clean(want) {
t.Errorf("EvalSymlinks(%q) returns %q, want %q", path, have, want)
}
}
func TestEvalSymlinks(t *testing.T) {
_, tmpDir, cleanup := testhelpers.TmpDir(t, "symlink_tests")
defer cleanup()
// Create the symlink farm using relative paths.
for _, d := range EvalSymlinksTestDirs {
var err error
path := simpleJoin(tmpDir, d.path)
if d.dest == "" {
err = os.Mkdir(path, 0755)
} else {
err = os.Symlink(d.dest, path)
}
if err != nil {
t.Fatal(err)
}
}
// Evaluate the symlink farm.
for _, test := range EvalSymlinksTests {
testEvalSymlinks(t, tmpDir, test.path, test.dest)
// test EvalSymlinks(".")
testEvalSymlinks(t, simpleJoin(tmpDir, test.path), ".", ".")
// test EvalSymlinks("C:.") on Windows
if runtime.GOOS == "windows" {
volDot := filepath.VolumeName(tmpDir) + "."
testEvalSymlinks(t, simpleJoin(tmpDir, test.path), volDot, volDot)
}
// test EvalSymlinks(".."+path)
testEvalSymlinks(t,
tmpDir,
simpleJoin("test", "..", test.path),
test.dest)
}
}
func TestEvalSymlinksIsNotExist(t *testing.T) {
root, _, cleanup := testhelpers.TmpDir(t, "symlink_tests")
defer cleanup()
_, err := symlink.EvalSymlinks(context.Background(), root, "notexist")
if !os.IsNotExist(err) {
t.Errorf("expected the file is not found, got %v\n", err)
}
err = os.Symlink("notexist", "link")
if err != nil {
t.Fatal(err)
}
defer os.Remove("link")
_, err = symlink.EvalSymlinks(context.Background(), root, "link")
if !os.IsNotExist(err) {
t.Errorf("expected the file is not found, got %v\n", err)
}
}
func TestIssue13582(t *testing.T) {
root, tmpDir, cleanup := testhelpers.TmpDir(t, "symlink_tests")
defer cleanup()
dir := filepath.Join(tmpDir, "dir")
err := os.Mkdir(dir, 0755)
if err != nil {
t.Fatal(err)
}
linkToDir := filepath.Join(tmpDir, "link_to_dir")
err = os.Symlink(dir, linkToDir)
if err != nil {
t.Fatal(err)
}
file := filepath.Join(linkToDir, "file")
err = ioutil.WriteFile(file, nil, 0644)
if err != nil {
t.Fatal(err)
}
link1 := filepath.Join(linkToDir, "link1")
err = os.Symlink(file, link1)
if err != nil {
t.Fatal(err)
}
link2 := filepath.Join(linkToDir, "link2")
err = os.Symlink(link1, link2)
if err != nil {
t.Fatal(err)
}
tests := []struct {
path, want string
}{
{"dir", "dir"},
{"link_to_dir", "dir"},
{"link_to_dir/file", "dir/file"},
{"link_to_dir/link1", "dir/file"},
{"link_to_dir/link2", "dir/file"},
}
for i, test := range tests {
have, err := symlink.EvalSymlinks(context.Background(), root, test.path)
if err != nil {
t.Fatal(err)
}
if have != test.want {
t.Errorf("test#%d: EvalSymlinks(%q) returns %q, want %q", i, test.path, have, test.want)
}
}
}
|
